public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: "Štěpán Němec" <stepnem@gmail.com>, binutils@sourceware.org
Subject: Re: [PATCH] gas: Fix some typos in the Info manual
Date: Tue, 9 Aug 2022 16:33:49 +0100	[thread overview]
Message-ID: <3e1db456-5247-9ad4-0ed1-656558af3844@redhat.com> (raw)
In-Reply-To: <20220809170621+0200.788134-stepnem@gmail.com>

Hi Štěpán,

> Any reason you dropped the last hunk?

Stupidity on my part - I missed it.
I have now checked in this last part.

> Was there anything wrong with my patch? It seems you applied (most of)
> the changes by hand

Correct.

> instead of using git(-am) (the latter would have
> also preserved the correct spelling of my name).

This is because I did not know about "git am".

If I have understood correctly, I have to save the entire email to a
file, and then run "git am <file>" to have the patch applied.  But
this automatically commits the patch, even if I do not want to do so.
So then if I decide that the patch is wrong in some way I have to
revert the commit and reset the sources.  But if I like the commit
I can push it straight away.  Right ?

Cheers
   Nick




  reply	other threads:[~2022-08-09 15:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:38 Štěpán Němec
2022-08-09 14:39 ` Nick Clifton
2022-08-09 15:06   ` Štěpán Němec
2022-08-09 15:33     ` Nick Clifton [this message]
2022-08-09 21:36       ` Štěpán Němec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e1db456-5247-9ad4-0ed1-656558af3844@redhat.com \
    --to=nickc@redhat.com \
    --cc=binutils@sourceware.org \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).