From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 93F71384AB5E for ; Thu, 18 Apr 2024 20:36:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93F71384AB5E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 93F71384AB5E Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472603; cv=pass; b=o+Dc/wYeS9al5DZxfXQvDMEKdlJuvUoDJOmwH7Dcyb+g+6T6IuMkzVWF3hv9TQpCqzHFdqF1WP+0W+cbqj8OBbvnpsJyQsQeQclsL+Ew5OCOn91W35z8vu6KtYJaaANYN/sLfIpQ6KvlJAEVhrVRpkFzIerxQ8ytv1wrws6mFxI= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1713472603; c=relaxed/simple; bh=HwM+hOpxDp/Pl4bHXmKlOLwPwWdzFFn7q/tbcUFT/Ds=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=Dds5PGWCkB+tEAOsNJXoT+L1f3xYr0QKVlYCQmjw4wc5JrWayCqBVrKahhA2UJKRRurAhkvIqddhjQM2B+J1AAjXHqoV8cKvfH9aH3pt2oOzI22DXMGg+lgVkjV2qG5QfxRNraFQg1HyWaN6OM/KS4ADWnDHYimXsHw48fhRx/o= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJiXfP010571; Thu, 18 Apr 2024 20:36:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2023-11-20; bh=IXlS0YK2s/ehJ24pXtJ4ccEY8ljmA+WKxmtrA9tiWlo=; b=Rc4mHv4czRMHWdUArFkUVgEkzBPVRcJo0aAeGBsbxo3rsYvhHO9Xc/bUCwHlBglSDocn 9N/Xh3oGe6Q/d9iY72ew9nxzDvOuMt3qzzIe796os8KGBovg2ZowaEfD8aVSn4nXrXNm zIdDZiX99gtRdaNSxYuKDWTqi/AU05CYNTbAlatxsjRhCMzrWkBs6oHHH4k36TJHMZLz TzLHmPoBX0hTtAmWnl690nePichlhNy8wcGJ/e3G5GK9rvWJntwFcFcbVrs4fAh7968f CojqL9kbZkLkrSiVm64i0YV7RxHz/ar3iS6YjVD50Nuv/CYkRhRAa+RTX25G6GXN9W/k Yw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3xfgycuja7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:36:36 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 43IJCcS4028863; Thu, 18 Apr 2024 20:36:35 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2168.outbound.protection.outlook.com [104.47.56.168]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3xfggay9bf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 18 Apr 2024 20:36:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cpGA19FPBLjI8wQa30NJ2+rzw8dyRmHTn2oSvneKWr1s6+5QumvXhxJokM40LeSJbvUw8OfLk3hq/BdCKjBBq8Fiu/ATvgGgCC9+PrFAeg2fb9KxahDrqkFO1jVH59g85I4sZslgiTgXy1MyY0onHBHaiJhQjPkO488aFIWrBtJQUT9qFM+onRB4F3KY/ltbBqBJAcSZ6Rmv8o+FGv3K+gCasgNYOVxpoB5zLRSHSr7wtAukQbp+6RdYAplUPRh5S0bb9Jpx8cfEZcfY0Zgm13zukqSmhDgsU8jc9kvTGU0ASOKHiUkok9oNECbo4jvQ0zMyRsf1DOBztP5NbQUxPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IXlS0YK2s/ehJ24pXtJ4ccEY8ljmA+WKxmtrA9tiWlo=; b=KwuUVB1sDMSJEmwbfjOME/UzqVU5iyReGHi+hH/Vz3nfnNAGuhkks1XwRTt2/1HIJMMIRukNYHCH3CjEsP4UJLxJ2bi7AkVWpLJgx4/hNPQDhXlKR8tGxrRD9dOVjk938mQBT0pbynPnbBHDOwpJyxq4DW4cxjY1ZTOXc4Ls+hVX4sh55Af6MUx59WG9mLZ/dnyhhZlZ1Y60xGFMxtWhO3yGfkPYmCOHYRc5JPUTbsxXC+/elSk1v9azqMfE89qeJVJAsh+qPpNEXi0oNTNgUi/P5to7SMZGbrmBcKn1xAAFEKU3dEylMozVEsoNuMQtQjciJgPjN1p8seGBeZJPQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXlS0YK2s/ehJ24pXtJ4ccEY8ljmA+WKxmtrA9tiWlo=; b=OiHMndOwDqtOC7/k0NTuLk6iCOYteVG0k7+4YUhgOqqZaNVLGDuX/MBoREZOemR1dYraFQ+fXTTB3+ImHARkqHSM6suD5G/qxLFIkmJpZDwK6fk91cgCzF2Y0ZcPzKoVd8LpBakeghljDdwIq4wEY/AMU6IZJg/oVK9QQ7nx2kU= Received: from MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) by PH0PR10MB4455.namprd10.prod.outlook.com (2603:10b6:510:36::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.50; Thu, 18 Apr 2024 20:36:33 +0000 Received: from MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889]) by MWHPR1001MB2158.namprd10.prod.outlook.com ([fe80::6f0e:742a:270:889%5]) with mapi id 15.20.7472.037; Thu, 18 Apr 2024 20:36:33 +0000 Message-ID: <3e299073-2f45-41cd-90be-eb313ce11297@oracle.com> Date: Thu, 18 Apr 2024 13:36:33 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 12/15] gas: Don't skip SFrame FDE if .cfi_register specifies RA w/o tracking Content-Language: en-US To: Jens Remus , binutils@sourceware.org Cc: Andreas Krebbel References: <20240412144718.4191286-1-jremus@linux.ibm.com> <20240412144718.4191286-13-jremus@linux.ibm.com> From: Indu Bhagat In-Reply-To: <20240412144718.4191286-13-jremus@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MW4PR03CA0162.namprd03.prod.outlook.com (2603:10b6:303:8d::17) To MWHPR1001MB2158.namprd10.prod.outlook.com (2603:10b6:301:2d::17) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWHPR1001MB2158:EE_|PH0PR10MB4455:EE_ X-MS-Office365-Filtering-Correlation-Id: 0af742ab-3453-4efa-bc5c-08dc5fe73c4c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1ew4VyAbkKc4YO4J54UUE05B5bp7r4Ppkqa182EMQ0nrO6vkdvB04Pz0VeVEhWScpb8yQcNoFX5MXPW0UUyvmi8WXlqX9/Anfhg/W6YohjLl8Cutqc4uQTP922DukrWCAIOKEGuSuPdR4BRbTx0wnMvQB3sNzgfNELiUOhfx6iJZ1shSCPozZYkczqXVhuyhM9roG9Eebnc8zopP/Lf1FPgXwJVQTqrMsAm6chC5U004PxGLZhknNRa2A+nBfGgAWwBGk9zzI1mFn0qjR1nVk4jNRQNTi5DYh7ObXN+lIZ1a1NXp0IzRt9c95gebr3nCPmImgvdhF04cuWwoOWb9NDVbZZQVjpjCS1ef9Hb7qo6MWJJsNOnfgjfIysbl7GdhokOHmg1ATKZ0IEUBGVOLfuJYPXCoVHWP61Ue3NIK5YYzMg1NR67tMxhaV0xaa8zLwLOz/BBfIci0t2qlNVCKF+j2rAxRBtvPon1JLOHg4M2apkGKys8SldvcvRgbqqYmPxWkUNVEdeRFWDqceyGRu0CNXFYo+YaNDyOm+NC6sfqtHU0163Bmv/sAEoVVyLEJqdIZg+T7UnN7ZcVaxeNWD65DzXCmdDFxTfaGNhR11xdYUOemMiNQ1+S/hMAlcAK0VRP9hW/Aj4SRMfVvSTYsXLUUWdxGhzKqjh/2XfreFLM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2158.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OC93QmdOTnVGSlkrV3hJeFRZV2IvWU42dG5CcDNtdDVXaDJBVFcvLzR3cVFw?= =?utf-8?B?cHBtK2o5Wk1yNmtiU1lFRE1rNkpUenRyRy8rMnFrRlhiT3MvUktaSW1OZmlP?= =?utf-8?B?d2laeHFpdll5MEd5NS83V3dTcXFXT0R1aVdoUUFIeFRUaWVjTkJnM0VFL3Bs?= =?utf-8?B?Y3R1UjV1UFVKSUV6Vy8vTm5oR3BWWHVtUTlmNkJ2VW5WSWJzaEF5MkxwV1Rs?= =?utf-8?B?TEpEZUh6MW1nYlZPV3M2ZU0zVWI2cmZleDVzRGpIY0tWYWk0NXhqTTV3aTBv?= =?utf-8?B?ZlBDRngveU5GTldBbkh0OW9GUXhsY0FwVFNqNmNmQUNuRWtZc0NXbFFzdlFQ?= =?utf-8?B?S0pyN3FzMGc1ZlFyVlFxa2Vrd0RlMzJqa2Q5RmJLekZTclJkbEZabEcyYTJP?= =?utf-8?B?Rnc1bFlUNzI2RW4xSTV4MUZpZ2U0TlhablV5RkxVSGdoRDk0TXF5RElybk1u?= =?utf-8?B?N0ZndFRHOC9lU3lFMjBMM2VSejF1SmVseW55UzVibVZzdVlGYWtJR253azI4?= =?utf-8?B?cHorQWRNaHlvaDVucmVaZ1ZQS1JLZ1pUeUxrcnJQV2R0MVBVeThIU2VOaVRC?= =?utf-8?B?YTBNeTViWmJlRVpodGFkOGJ6NHl4MVAzYU5LNitrYnMvQi9PNlhIemZZYXFQ?= =?utf-8?B?ek1ISFRlbVhwd1N6RW1pSlFPOXJtV25kMldIWlY4VHprMTBMTzk0czVURlY5?= =?utf-8?B?ejFZYkxIM01XcXVLOWFNcHE2QkpFQnJYTjJ3RzFueGM1Y3huVjhRaURsUEcy?= =?utf-8?B?Tm9sTHl6QzhaRllRS045WTUxaVZoSnN1Y3Q2RVlKUEE1Y3d5NXVBQjRQaC9j?= =?utf-8?B?djNScmhjMm1wMGhMM0ZlbXJ2S3JSSzVjbStQRm1MWmFkUkc4MFBxMDg2ZGt5?= =?utf-8?B?ekNjQmpiVXBVNVJRbmtwY3lJY2FPbk1vVE9KZVQ5UFZMdnRkOGp1N3dDaUUy?= =?utf-8?B?QVRUUkx5R2FONGxuUGhyNERyd1ByTUYyaVp0VlhTZnJTT2FZRjczcGM5dE9M?= =?utf-8?B?aG5pVXdiZ3hzL2N1SUYyOHlWVjlGYWF5WEViRHlYK093bE43TU9yVlFwWFVx?= =?utf-8?B?UmttOXFFVjZ3bmd1RUpWdXBvUE40VG5oQnMvYUJqRzIxT2hNMVRJY08ya2pC?= =?utf-8?B?RVNGTFViV3VldjJLVnozRTFYcmszUGoxRS9yUEFpQWgxS2hLeVpqNSt0Z3dn?= =?utf-8?B?K1p4YnBkb2lNZm1GMis0dDBTcktKQjRTT0Roc1FBYTRYVHFUdXJEVmhxb2Vx?= =?utf-8?B?eWZRWXo5cHViQTBjV0JyVTlCTE1UYWJFZDZiODBHeWk3RHgxVkY2YXpsZElq?= =?utf-8?B?WXpyemtQVjJXRDlYS20rdjExelV5cXRQRVlSM0ZWT0ZVY2dKaTV1TEVJUHl2?= =?utf-8?B?N0VHMm9obTd3eWlCMTA3VVZIUDdwUVhsdWhjYkE4aHpjUnVPTkdqaVRDMVd6?= =?utf-8?B?eU94aEVnMmlyMnpFY3NaRUhLOE9LM1g4UGFiajhrSUJQNmx3V1dMeWc3UTZR?= =?utf-8?B?MUlVNlFIZVczMUQxYjcwVkl4bFJsL0NKeHFoZExHbFIydkNYYjYrVUU3N25o?= =?utf-8?B?WVNHakxnS0JkaTZ1R3ZUQUJZYnlJSXZ1a21xZXlRUnRYWlRiMUx1WTRFTWJo?= =?utf-8?B?clg0ekZqYVhqanpzYm5PVkwwdHhTSHJXZVhFWEV0NXJSaUJ3V3J6YmlZYzRE?= =?utf-8?B?MU4xbHprV01mSjQ2Z3EvMVFrdWE3SWZRd1pRZDFxbU1ma3E3eHBsUldES0to?= =?utf-8?B?N3BHbmJtMGZyN2lGejlXMjVJeGxRRHUzZHFMcXovLzJJWHNxNE9hK2NFMDFI?= =?utf-8?B?WEdFR2VieldGbXlSN0ZKaW4xR0huRVUzSnBVRXBZdkFpMzFCeUpyNVhCWTJP?= =?utf-8?B?M1JMSXVCUmxqZUZnVVBuWE5OanIrNU1vNmN1QUh6T1gzWW02bUZUa3gzVSs0?= =?utf-8?B?OWZ0WElKb1JwNWcxUEdtekNHYmd0dGs5SENkKzBZV09qcjFmazArbzNncDRh?= =?utf-8?B?ZHo2L2EyVDF2V3Bua0ZGWldLUEhKT01KRkcwWnhody82S3BjdWN3bVhpWWtC?= =?utf-8?B?SkkraU02RUp6Q2srZk10Z1FROUJiaGYyM0JpZnpzeTRJTnlBbWdiQnhGSFN5?= =?utf-8?B?Qk1ISEZqSVNqazcxNnN6U0dUZHkwbVVQc28rVFUySXYxakUwRUZnR3MxY3ZL?= =?utf-8?Q?q1cKKyFg8NctYCtRSgxTGBQ=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: YvwJOh2XpgPTTyWaZvz6ONluagG9z4QSV6g1kBeOkgmlLXez7k8tXOw53JQDOEYux7xzMXwqw5xDDDH6wtO1yvayVSrZkyM9fT0xT1VkGyacM7RPyZmhIA2AMqzwzt/yRQsDDkKCnu62/HXb39BnRueuNW7+eElyn9WrDyGnrWu9YKQSvGZu5RCHqSHYOl+6vdal3sxv3DFkKU8ose5JHtHVFZjG1M8oxpwfGI4hMHNBgxU/mfokC87ACE+L1lI+v5+8vJCn9v37VykHrGbtZ1TB6VJzHQ59zdxGCznG2vAgS8rdTth8wfb8Bp1/B+jqJ+AJ7B99b1LmgzIN3qZdXIZXiBtMNl/zYse8o9qK8riG1dL2PNZdPuOS36Arqfk2ZyfPy24L67w5pcdInIa5YTUyxK6sZKUAlOYzGRyR0sDmMj1rLn6uHaS5+vskdbmoV9W3vKXo51JsCulIDtSLxC/WGTaD9KDoUdA+yNTYQ06b7ho+ajRwc71aHx8fjSI+d2IDIaQgfywNlH/N8xDQbCAllo3eZWvDkzvYrDPkefKfAGHD33BbfLwbgNVpwtX+bLlCoR/aA0O7rnpmDc6yiumZA9D9Pwzd15UWqGsjfcM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0af742ab-3453-4efa-bc5c-08dc5fe73c4c X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2158.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Apr 2024 20:36:33.4087 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hhXOgc4896Ceo90XqrwhEmAV9Afgi6aVCrRnFGPiPZzFe/0+A6cgiU2s7g5wCe9uSQu3gE3rz9xmBITSUqSgPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4455 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-18_18,2024-04-17_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404180149 X-Proofpoint-ORIG-GUID: VV3SAYQtGgZzlclXWKIcgMnDI1lNVTle X-Proofpoint-GUID: VV3SAYQtGgZzlclXWKIcgMnDI1lNVTle X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/12/24 07:47, Jens Remus wrote: > Do not skip SFrame FDE if .cfi_register specifies RA register without > RA tracking being actually used. Without RA tracking the register > contents can always be restored from the stack using the fixed > RA offset from CFA. > > gas/ > * gen-sframe.c (sframe_xlate_do_register): Do not skip SFrame > FDE if .cfi_register specifies RA register without RA tracking > being used. > OK. Thanks > Signed-off-by: Jens Remus > --- > > Notes (jremus): > Changes v2 -> v3: > - New patch. > > gas/gen-sframe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gas/gen-sframe.c b/gas/gen-sframe.c > index 98166de8cc01..61c846f214ee 100644 > --- a/gas/gen-sframe.c > +++ b/gas/gen-sframe.c > @@ -1160,7 +1160,7 @@ sframe_xlate_do_register (struct sframe_xlate_ctx *xlate_ctx ATTRIBUTE_UNUSED, > stack trace information. */ > if (cfi_insn->u.rr.reg1 == SFRAME_CFA_SP_REG > #ifdef SFRAME_FRE_RA_TRACKING > - || (cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG) > + || (sframe_ra_tracking_p () && cfi_insn->u.rr.reg1 == SFRAME_CFA_RA_REG) > #endif > || cfi_insn->u.rr.reg1 == SFRAME_CFA_FP_REG) > {