From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by sourceware.org (Postfix) with ESMTPS id 1412838582B6 for ; Tue, 18 Oct 2022 05:42:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1412838582B6 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3FsFozHXq82a2p9gdfgVrQjzmeG775qyfdGyZLEN2H5WShNYFgn0v9/mrrU+NOzZLzMpc2BTmgTE5T1z47DY1kLIuRYUnuwI+SQEjy/9nTb/GUnIIyK0ow0UkCDe8CqZptTpjChFEUOGKAx0V9eF97FzbouuiwBixrbBiTRf+E4WXQ7Tks4B/pnrFVpmP1aBDiDwdL3Yll8MK8MDvH777zZIFq/IxWxQ5XaDtzZVLStd68fNmivohnN4eyoksu7IrjnePLU58YNW6GjZGVpWpp+p7z7esFueLPMoswchg5mo++kTK7kfO82pYurgi4g8iOltiL5Bz0QbfMUPAdWBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HIHaFQybtEhwFIfPnGotVhy095gkf9I7QucDs4HbbBA=; b=hxvaqOCn9fKCutst/kckfF2KhYPdmrDve+RT36LAOdzuZjzKiOD+R7FUDZiPERJrOT+5qpUWm/fWt4xtyJBlqN1kYHJveIkCBb532KfhmnrQNX96MQFo9WT91PMqZknqg693FmRK5gDOh8MGVyTqQJ5vOezCjhl/ZmAzEyqMifSwqpgrrQXhLpQ3Qj3FuN/jjTfFIsHgNp2qt4c7R6zQKHxMMxfJ53DbmpQgy8RHn4KpBy1bc0DmoGPSIHlzpOMj7wHvYBZ94w7TpPcOy6yqmG5CAzewZJaOY3nmfW+Ip9wYdSxwz+MpOdnaFfSeB9BNPgkF38TWRPETiNKMfYR30A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HIHaFQybtEhwFIfPnGotVhy095gkf9I7QucDs4HbbBA=; b=EKJYXoTiDhQQhxRN7BFwjyhTSDTBvEq1VeHfuehpfPhdXh4Ds/wOqIgxy+tny0nyHYBOAVc4MxhPuxxL++T1TGvt9OvyUw4vVplYbnMwaeBK8tbbf6olx9aD8Ix8BGC5bydmRWDGSYGxPiK6QVIgnzgdL9HHUegywzd41LvDx6qtZfrkLNuSbn6JpYh0t9wsp8H91QOmdOYKZw2S7XioQrWi3B7lu5R9pVjRKZHFsUBu3o6WpZBVAMG0FYuTGJUO6V9HLHfTyjMbFXiMzerORFGyqUV2kJQsb7YoiLrJcj3cWR+ZvmF5m5AtXV3QDU0ujw93ZfYeMr0S66CCnDJx5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PR3PR04MB7225.eurprd04.prod.outlook.com (2603:10a6:102:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Tue, 18 Oct 2022 05:42:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2459:15ae:e6cb:218a%7]) with mapi id 15.20.5723.033; Tue, 18 Oct 2022 05:42:02 +0000 Message-ID: <3e3336a8-5aab-9099-6851-a8071bd88fee@suse.com> Date: Tue, 18 Oct 2022 07:41:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH] x86: fold AVX512-VNNI disassembler entries with AVX-VNNI ones Content-Language: en-US To: "H.J. Lu" Cc: Binutils , "Jiang, Haochen" , wwwhhhyyy References: <7bac66be-535e-9051-d674-f2f5ba180e17@suse.com> <90899ac8-cc4f-52f1-9498-5e7f87fe6355@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P194CA0025.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PR3PR04MB7225:EE_ X-MS-Office365-Filtering-Correlation-Id: 1276dc1d-8613-4520-16e6-08dab0cb7b36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vUv+8wunx6a8InGFvpqK4yXwosDYJhhiXlrz/GKqsBXdl3eEaK8biTGK9UsNEWcfsqGkn3vDlax4q9qVDscRYjvl/AppTU0f/CWC2aeTI2dN4e7HsjjR0E5t3U9QzbnjbXszWBSorl/FZizznGtQA6vHWajl4/7hiVNf6RPaVTN08MYlJFRq80jQ+xxUZjLkQgL+RZwHV9KiQrRdeWRcDaBuQpHl89ehhf3ukqHHdw/0y6wb5lxvcC9R4bX64C46VfUI6L7JOfKP4rGu/wygclOgCkXl7kFHWCltR1vT7FGFDsXd1SYMVFgZ3hu4RLqglXPaDHfmwIVViyMQe6AlzC1HPUnRN7Dh2ai6mWPqKjH9i0mKRSPkLmKUJhAAHFEz0mMbOBK2TcikasPBpklv6e0AZn6uUALa4HrpnRMvK7ZZ4ddX51PODya3FAl6yjnR+3q7qc0k8P1orGGuQhfLzwL2fPH+KyrR8d+djkMo8ert6edzqCHPFthbMMMkBKE4duHJ7YYgk1K9eBnVUbBb9m18/cj0YypwlN+qFIBdexJejziV0LlWUkDRtSMUX1mU3NluKC1NTSTvFXmCigpG8t4MhuF+E3S7YQsLiHxjzL8E2hGNhRvvPoG1xtv2KJ9b6zoaEumRj+raUjwMXgfJjN68tsaJbJEwnUt+U4rVszZki6Frj5rmdyCMR70gc+Pv4BxbX7P12aa66XJctuFxy6SgEClWcC+zyajw3hokv67ZLz3xkOIX7elBSHH6YYvVuHEbxMKSOVYvu58rlSaBWaO1Ymx6qyLQekxgdfu6jNc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(376002)(366004)(396003)(346002)(451199015)(6486002)(66899015)(54906003)(4326008)(6916009)(6666004)(316002)(478600001)(8676002)(66946007)(66476007)(2616005)(66556008)(6506007)(2906002)(5660300002)(186003)(53546011)(41300700001)(8936002)(6512007)(36756003)(38100700002)(31686004)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tm04dU5lZ2p2a0E0cS82WDRhZW9TaUFyWS9TRVRYd0xqVEVKRlVjOXpCUFZj?= =?utf-8?B?amFSaFlpR1ZVUjNHRmNIblVDcWpJWWtoS08wOW1MRGZQNDhnUGlnTXZzL0lk?= =?utf-8?B?NFI2V3BCTWQyZjBhSTdmemdTTmNVNzlDMVJTdkhxZW9UQ1hoVVdTeHBCdFBp?= =?utf-8?B?ZmtzWVhZRjA0YTlPc0FHVVpSb3pReWRmOEVKQU5aVFVpWG5UTHo0cUVXTjZ0?= =?utf-8?B?YkxrUjNyMzlVUmtidVBCL0hoZ0w5cVExR1hnNTRuMDd5RjNlZ1FyamkrWGIw?= =?utf-8?B?SmU1RFpNdGtjVE56ajNqdStIYkpMRnQ3R0x4VytpSk5BQSs4c1M4aUY1MW1r?= =?utf-8?B?VjJQbWdoaFdaZmNkNzVCTkczYUdzSVZZU1oycG05WmtNam80enBYc05ySkln?= =?utf-8?B?QkNINzJ5ZU0vZ1gyRGViWm8zcGZNWEhCNGl3UVZTOEFjM0MyYnFMbHBvUTlM?= =?utf-8?B?VWtnYSswVzlrL2I1NUUvMk5mdlI0K3JCUTllSEFSR2JMUEpMTmZRM0tQWTVk?= =?utf-8?B?cUpBS1NQVUdEUHdGWXUxeXZ5M2toMnZXcnRzK2JXKzdwQitFVWNSdkk1OEFD?= =?utf-8?B?RjNSVm9EUERiK2lrT1RkeGprbWt3N0Q5dzJWSjg3K252TmVCSDg2QjQ2bVhB?= =?utf-8?B?TVNtbk5YdGRtRnRBN296aUdaTEc5KzNXS1VmMzdrTHBiNVJmRWVUdWYrbW9z?= =?utf-8?B?SWFKZDhLYzdNcXljUHB2eDA1NXhuMHIxYVg4K0djbGVDbThwS2lnVHUwQkty?= =?utf-8?B?b2orNlZwSUJXeGZ2N2FzVWhJNXFsb3NsbGtJWnVGcWFDcnRKSGdINDArMWJX?= =?utf-8?B?WmdKWGkyUUFyVVFic1dRckhMVkt4VmNnVFcxd2ZxVElpb2lOV3oyOExhcXp0?= =?utf-8?B?MkNSMnlxQVdxMC9tczEvUUM0TnAyMm0wbFBWVTBEWEFqaXpzRG5YVjVJelRW?= =?utf-8?B?T1Y0WUlaOGUwSDRCUUMxaU5lcVdmZUo0T2VFZmxhWTNwMVRMa3NBdjlDMkxw?= =?utf-8?B?Ly9TSkFhdU11QStnY005UUZ3L2ZNTW02dStYdCtLbDQ3SE9xTmRqZnlsL0FV?= =?utf-8?B?dy9Pc0oxd2lzL0ZhS1FqLzE5ZzluVWtXZ2Y4QVlvSDZWL210L1ZXQkUwVWhZ?= =?utf-8?B?MG5UQy9XWXdYZi9zTzBwV1FkcmVoYm51dGxxRVhpeXNOeVRKVTJqVVEvYVJT?= =?utf-8?B?UzZQRDlyTXljMG9GNjU4ZUN6QkN3SEQzdXFvNXhkbkd2ZzBzMEVuRDk2K0xM?= =?utf-8?B?RFE1T2loMU4rMGYzcnpaSkErTVYzY3NLYW5IV2dtZkdyajdKOG9yV2VMNU5H?= =?utf-8?B?UVFRMDBKWG1sU2o1MUd6WWZTODk5Z1l6WlI2TUVJaXNJMXYyUjlkQzdOcUh2?= =?utf-8?B?SnNYOUJTY0xGWHFXQjExcHk3cjAwNkEzQ2doVkIrT0pnZnhLeVgyRDh3dE1o?= =?utf-8?B?b1NuakZramdTMmZkaklON1FySzdoYThJWjlwTE5OalAyNXRyTktZT015a1Jy?= =?utf-8?B?YThTT0luVTBnV1NYNFlJTE1zN3Q2R0wvcksyUndQZkRRRWF4WkdsSzM4Zk5h?= =?utf-8?B?RmNpbkF6Q0hjMXN3LzB2NmF2dW15aHgwVzNwVWY2dkVaaStvT2djamQ4NFE4?= =?utf-8?B?UVFGVXRQa1hnSGpnSWZVaENrMk9uNVdPdG13S1RRZHZoUmdaRGRidERrMU5n?= =?utf-8?B?SWV4Vm1PcWRkdXVkQUYxV1JNK2p0bUJNaXY3anlCeHFTaHpYWEVRY29tTlB0?= =?utf-8?B?QUdyMU5OWkY5SE1VdE1tQmNWOHZqVVFSMktSQlNsM3BHWnkzY3QyQnZXaVMr?= =?utf-8?B?Sko4Z0pTZkJaU1ZJbDdjNXlyRFRuRVpwN0ZJbFgxTENiRGE3bTV2UG5IZ25j?= =?utf-8?B?QklSTlBUcHBsbm1hWWdkNDRsQWhMWWUzNE9PRWpDZzFGMDBXem9tSzJpN0Na?= =?utf-8?B?VS9WczdXQ3djNmQ0elJWS3E2RUl0dTFJM1E2dTJuTlJLQXFPSEdDdEhhZGJ2?= =?utf-8?B?Zzd2aFl2ZU1iOFlocm1VbEpUa0VZbzV3cEQzK1JwYTlad1AwUGIydksvUGlX?= =?utf-8?B?bUdaY3RKU1Z2M3FOS2d1SEdFamFUazB6T2VrMHdRWXp2ZnkyQms3Z04zeXUz?= =?utf-8?B?SlVZMnZFVzJtbFg5YUNEOWh2c1pwbEpXVW1tNzVPU1lTaStOcXhCdU5BUDJz?= =?utf-8?Q?GyKEWyqjLJrdHJT+YcYCigYm65DG9nR9FsCSBKSsMb4/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1276dc1d-8613-4520-16e6-08dab0cb7b36 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2022 05:42:01.9900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 06bXx2QuKyTQgZE7k7fVjjsgEJnKDX4N8uSfMgHXAgAlk7bQm91nZyzUixIUFOFrq4bBHE9YAChPhkVh2NfAXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR04MB7225 X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 17.10.2022 23:10, H.J. Lu wrote: > On Sun, Oct 16, 2022 at 11:39 PM Jan Beulich wrote: >> >> On 14.10.2022 19:28, H.J. Lu wrote: >>> On Fri, Oct 14, 2022 at 3:22 AM Jan Beulich wrote: >>>> >>>> Make %XV also print the separating blank in the VEX case, while making >>>> it do nothing for EVEX-encoded insns. This way the AVX-VNNI entries >>>> can be re-used for AVX512-VNNI, at the same time fixing the lack of >>>> EVEX.W decoding. >>>> >>>> For the AVX-VNNI ones further make sure only VEX.66 forms are actually >>>> decoded. >>>> --- >>>> Irrespective of this change I continue to disagree with the arbitrary >>>> printing of "{vex}" for the AVX-VNNI insns: If that's meant for >>>> disambiguation purposes, then EVEX-encoded insns not using EVEX-specific >>>> functionality by having VEX counterparts (vaddps %xmm0, %xmm0, %xmm0) >>>> should also be prefixed by "{evex}". >>> >>> This is done to match the assembler. There are 3 kinds of VNNI processors: >>> >>> 1. AVX512-VNNI only. >>> 2. AVX-VNNI only. >>> 3. AVX512-VNNI and AVX-VNNI. >>> >>> Since AVX512-VNNI came out first, all VNNI instructions without a prefix >>> are encoded as AVX512-VNNI. The existing VNNI instructions without >>> a prefix, generated by compiler or hand written, are encoded with EVEX. >>> If one needs VNNI with VEX encoding, the {vex} prefix should be used. >> >> ... if, as said, AVX512 wasn't turned off altogether. >> >> With your model, just look at how odd code using both AVX-VNNI and >> AVX-VNNI-INT8 then looks: >> >> vpdpbssd %ymm0, %ymm5, %ymm6 >> vpdpbsud %ymm1, %ymm5, %ymm6 >> {vex} vpdpbusd %ymm2, %ymm5, %ymm6 >> vpdpbuud %ymm3, %ymm5, %ymm6 >> >> Yes, one could further clutter this and add {vex} to every line. But >> why would anyone want to clutter their code? > > This ensures that VNNI instructions without a prefix are encoded > with EVEX. As does ".arch .noavx512f". >> Plus the same argument then applies to AVX512VL: This came out later than >> AVX, and the assembler (necessarily) requires {evex} to actually encode >> these (when there are AVX equivalents). Hence to match the assembler, the >> disassembler then also ought to emit {evex} for this subset of encodings. > > A patch is welcome. Will add to my list. That'll be a huge patch, I guess, because of the sometimes excessive testcases that were added for the various sub-features. Jan