From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 28AC738A8038 for ; Tue, 11 Jan 2022 10:13:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28AC738A8038 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-57-FkyoYTh_NSGkaqlQ10YWgQ-1; Tue, 11 Jan 2022 05:13:09 -0500 X-MC-Unique: FkyoYTh_NSGkaqlQ10YWgQ-1 Received: by mail-wm1-f71.google.com with SMTP id n25-20020a05600c3b9900b00348b83fbd0dso1572910wms.0 for ; Tue, 11 Jan 2022 02:13:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=wLVKZou3qhrv5r0eB2ctajwMNVhGKeqTXfpnDBm9Nkw=; b=arxYQh5iDDCFV6idxaEDnNCB8Y7oZMdz4gEtUeU6RX8zhp6B6IrfzA0abFqhHklId6 gIzbrGIdxBx7CSxJnOti25b8iiZG+lOK1DzoLgMCE0rOP8pH9d3eTJDbZnYyArbWKcL3 62d3CpjqXUKCZCI/+TgAXu/cH/5MW+Bfm3C4r4FVy0d/FG/jiwQzqW+s1jnzoyfDpy1F +U51rcaMr0hJLDjfPKqdunsQHruCQYLZLVReoCfD56YtsgzQm1rpy4PhEE+HY7pTA2Sj xv73fPbVmQXiAKGXqHljMDA7INuCN/IhtvLvOtqtYxIHiAMUhLM8GY2jE8K4Y8U5Z3UP 4sYA== X-Gm-Message-State: AOAM531IA7K7P8bHQOUX+N1gxadOJcvpNwDWlPyxadcHgGQTBjy/njJn ddO24dxX9Iz2cN5xTJw3fMUyuLLwtlaY4JlVffSblXLwy1DXEX93XW8QkB4yRgh5deBM+MjuTFQ lb95PjH7pE5dw4QxXuA== X-Received: by 2002:adf:f791:: with SMTP id q17mr3208596wrp.311.1641895988230; Tue, 11 Jan 2022 02:13:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJxOGtgddznXcGYiZdwOJj1s7G08X1qed0uP3PINfCw/tB/6dumLtrtUbDJfsWIYl0maru50vQ== X-Received: by 2002:adf:f791:: with SMTP id q17mr3208583wrp.311.1641895988038; Tue, 11 Jan 2022 02:13:08 -0800 (PST) Received: from [192.168.1.6] (adsl-164-239.freeuk.com. [80.168.164.239]) by smtp.gmail.com with ESMTPSA id a3sm9799306wri.89.2022.01.11.02.13.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jan 2022 02:13:07 -0800 (PST) Message-ID: <3ef64eae-e912-e84f-64b9-3b2ffbc14d80@redhat.com> Date: Tue, 11 Jan 2022 10:13:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: "H.J. Lu" , binutils@sourceware.org Cc: Alan Modra , libc-alpha@sourceware.org References: <20220108183838.1920397-1-hjl.tools@gmail.com> From: Nick Clifton Subject: Re: [PATCH v2 0/9] ld: Implement DT_RELR for x86 In-Reply-To: <20220108183838.1920397-1-hjl.tools@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-GB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 10:13:12 -0000 Hi H.J. The patch set looks good to me, but there is one problem. With the set applied there is a new linker testsuite regression for non x86 ELF based targets (eg: s390-linux, xtensa-elf, aarch64-linux-gnu to mention just a few): Executing on host: sh -c {./ld-new -o tmpdir/symbolic-func.so -z norelro -L/ld/testsuite/ld-elf -shared -Bsymbolic-functions -z nopack-relative-relocs tmpdir/symbolic-func.o 2>&1} /dev/null ld.tmp (timeout = 300) spawn [open ...] ./ld-new: warning: -z nopack-relative-relocs ignored ./ld-new: warning: -z nopack-relative-relocs ignored FAIL: -Bsymbolic-functions Please could you investigate and fix this issue ? Cheers Nick