From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2079.outbound.protection.outlook.com [40.107.20.79]) by sourceware.org (Postfix) with ESMTPS id 573CE3858C3A for ; Wed, 30 Nov 2022 07:31:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 573CE3858C3A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nNJDFzfhdfpkvKP4yDppSJ5HGWCRVCWAEu0/J0agMv3hBfyq7RPBmxBU7FFSw1iGaF0ay+NCWiji+ejAEkwDo1CxZFES4sG4glnYOL/yeiNPjbfnNnvqqWP6PiNqCZWShOZwS2bR29uc6hbVcxiv+YpSMc9/RhXGrPs2cX7v49Qrhd2CM0mXSGGROc8ZChTPPL3QduJ5NOVmXM3BZejRqo0ASU5UOBQ+SQugKAKx8+dhGzydwJ4GMpgWaFSmHwL6H5Mpf9VDHPMd/wXnXslFkkRLhxaZzwSpeaT3Sxc8uk4kQXKWrJQ2/Gj+10FoQPQOtBQSNbI6eAcSIYZ1dVSFCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfeLUwQ66E8V3h/cymVp6lYu3LqlW7qgnfLedNCQ41E=; b=EM0n1N/Re7+4g7uSIPAAx1+r9EXglCQtf0Vs8UPz/az1Tia+4EtLDeUKY+/l8728ulPao5TMgFUyFFQ58I92iRSM/CpDRE0Wr1b3C/GXlQqFYdZPA8aGdTejZAJXDcBWzQ34tjCCsAtvfCGimx6FjjiLKUR5uGogORUm9pjVyikPBv1mKC2znu8JZEF9AlKfD7LZpqPrDRh4r9hzazTjRc8MjYWtHnKMqoifHyiN+sEaneHTnOnZByerPTmKN50i/coTn5D0PHH60v0eek+gu8g5d5es7pbjorzW/5Zvs27IcOp6HdoTxs1RLesmyQfSX8zqYuHffU23GluWQ0cRVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfeLUwQ66E8V3h/cymVp6lYu3LqlW7qgnfLedNCQ41E=; b=X3R6raJ95pcRyy3Waq9UHunsVTOTmiU3ihkLydP7F2vVsQrXzhDC0gYyjnb6s/IvzQgBhqjZVLOZHUYpk/w5TXpdi1nMA5JKzPri3BZ4fWAzy7w8Pxr6cyK2TYN0wDekLZqpy+fX/oPy7RAwKsXt0L1ozKbuxw/QWfDfB5yuugcRKnUjfM2gV/Wou68tcZc7dU/Yal6O5mSpVqxixfmYfBkn/Eun+tQn2x2/dZAuhhF+GRcg5nzVYaZ5iPMiG9gHibtb2MUUENA9pWSCAQVgWrzNNXSbAXGiyfhci8pZ9s0GV8NO6x9ua8qu9nAn8XA3gUvtlddJXXYOR0AykdBa+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7697.eurprd04.prod.outlook.com (2603:10a6:20b:2d6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Wed, 30 Nov 2022 07:31:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.023; Wed, 30 Nov 2022 07:31:51 +0000 Message-ID: <3f038bc9-6188-9bc4-d73c-51cc633fd69d@suse.com> Date: Wed, 30 Nov 2022 08:31:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2] x86: Remove libopcodes dependency Content-Language: en-US To: "H.J. Lu" Cc: Binutils References: <20221122181927.251937-1-hjl.tools@gmail.com> <6a5d4918-919a-8b6b-822b-17ce38488629@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB7697:EE_ X-MS-Office365-Filtering-Correlation-Id: 88c4e9d8-a5e1-4dc1-14a2-08dad2a4f293 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mcbL5hUYr29qQ7AtprPXz5/EWHgt0SDWcdumAsZgB8wvIq4cVV4PuHVGJgC1wPxVFEZPT0HKBMYOGE+txo37EZQKGRchU86uV87SBl5ft5iNrV1MkY66qmkT5qa4UDLdot9EfwWSRMYPL+Q9XsqGUYJKkYJSJwH7Qjl1jxxrgiQYf++VfI5WC8Ornn8Q6wfNDFFvN8DaHbIFTq53HNtpw8qpS3GGOu/npFnQVPCwPfnvsz4LGJnbNjOkhE7iZ5kSpl/o8JuWlpjyXkO82mAZCNSyp10Y4gX+LMdryu+oq2QxwW9UGeMRvYZjJbBwftZMOE1NtaFRB12gue3VMxMpmGpHdLte+IMAFF7buO2gtLklK8MlD9KagFbf4KxoXx+eT9Nyxi8MdTcruJVRLXtCgBIqz0YzPGxANpbF6i1WLve0u6OhQdHXnc4M+TXq2CS7bG+94l0I8SppOJ2p+ozek4tsSvlqI1ZW+KrxD41hdc/Md/HSynndyw0chHrz8u03z5X3qIWXCaFcxmhQ6lBs6ImvJcOXVDSUZxNx9PiTEURWhgze+7lF4rB43FDciN57Gj9QjZOsjdal90Jvw3UHuw6BCO88DJDzffVDQwC+6Bg8eO42ZS2C05ZFUh8ZlWxDPHNE2SwzvDR9alxRHijm9WQcGBUan4OFeoemcy7634O0oNYp7TqI7nxWO4YnQko2lIU/kQ8/aznNOr9825oygHkWVrgkpiD8qOLEpbObgzE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(346002)(396003)(376002)(366004)(39860400002)(136003)(451199015)(31686004)(36756003)(38100700002)(2906002)(4326008)(41300700001)(83380400001)(86362001)(31696002)(6916009)(6486002)(66476007)(8676002)(2616005)(316002)(66946007)(478600001)(8936002)(5660300002)(66556008)(6666004)(26005)(186003)(6512007)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TFBORFJ1MGo1emw5eGg2a0pCTlZSdkRaSFFyMFVTM1c1aTYxTExac0NOTmpF?= =?utf-8?B?M1BGRVpDalh6NWlGN1hDUm04SWp0NnA4TER2NGsvYWIyQUxGS3N1R3ZXUXRs?= =?utf-8?B?N0tleURZOG9GOXNHQlNvMFIyRkZPQ291T3NFVmszWHhaWFZ3WkZoSkUyTjdu?= =?utf-8?B?aFpNL3FNKy9URDA4WWdpbUcxMVJPaHhDanl2Q3NGbGg2ZlBDemh0R01UdzBS?= =?utf-8?B?cldNZ0N5MUp5Wm1nVlRFN2xLamNkM20xc0xROWR1RFY0M3N6VUZLNGgxY0NH?= =?utf-8?B?SnJZdnhFY09rUHIwaXZXSkwrQ3kyclF0M2xCOHg5d01PalN5aGJhb0pMVXVz?= =?utf-8?B?bTRxbWhIK3hhTFAxdVU0dGJzTWhwYytUOWJqTnMvemhPV2pJcHF4VkhtVjlh?= =?utf-8?B?ZWZuajlTVlNuZ0hmNExmTjIxZFlXRTVSczN2U296S0krQ3RqRnVXZUFMbzZH?= =?utf-8?B?VU03YW41NEhOdHdkVHVlekxqZHYvYzF6NWpBcURKUy9XQVpPV2NzdG1HdnBu?= =?utf-8?B?OGhXM2c1bmtyblhoQUQrT3F1Nk1TVUhobG9Wby92SVhDYzRVclgwMmRYNmxH?= =?utf-8?B?dkRtb2xVc21lc1NPbXpRTlZyRGhnWnBzanlqZW9rVnl3K3NzU3ZJWms0L2Z4?= =?utf-8?B?RjVkQUl3MDVnN29aaGUzVjFZUEFUbCsrdHU4cVBXNEcwbjRDUXFtWlR0YnN3?= =?utf-8?B?WVQvWHQyc1B6NXNwTGFUVzRQSXp1Qkh5NENIUzg0SERaR1p6T3hFQWY2M2pv?= =?utf-8?B?RFo5cC8xeGNMRXFFTU5wZ1huazYyTmQ2cVMrOFZnRXFxdmZkR0p1OTdvM0dE?= =?utf-8?B?U05vV29XWllYVWFWekNhWW1rbE1GUzFrbkxtWndybkZCckpMaHY3TC9hWlBN?= =?utf-8?B?cUJFK3N4MlVPaUw4OUdCcUlKMXRsdlcwayt3QnFqZmxsd0FVMnN0UjBVNGJq?= =?utf-8?B?YURvZmV1MHhubjVkUVZ3OGpWUkp3K1Rtdk4xZE83SDNiaUVISWVjZm9WRyt1?= =?utf-8?B?cTlqL1kvMGtCeldwK2R0bEk1MXo4SGoxT2V0Qmt3K2x6NVFuN2RBL0ttVnFG?= =?utf-8?B?bHFyeHBLU3krMWNGSFp1WThOcmNtUlVRL2ExbUx6NVp4cXZTR3cwV1l2RWJr?= =?utf-8?B?alNhUnZ0OSthZ2hVUE5aOVdEYldxcWVOTXZoV2ltbk0rSjc0L2JSUGxmNXRk?= =?utf-8?B?VXNEbEZoVzUxVEVvU29hOERwamNEYmhWUTd5ZmhnSk9TTGJWU2dic01aY3Q4?= =?utf-8?B?RjllcVdSbWF6NU82cy9UU0dDZmVXdTU5VnJOcEQrWlE5M2FoQVkzTlpIZVd1?= =?utf-8?B?SEd1elFpdjZPelB2cVFDcnlvdzZFeTdIb1FlVEN1dXhYV1RVNmtXTkw2YXFS?= =?utf-8?B?SE9wMkxoZHZsNXBrL1ZSQkVMc3lpU252d3U3bElqZ3VUZnNSK0lIV3dOWXF3?= =?utf-8?B?TkRrVEh1aTNHcHZoOEVDOWVPTmZyZjhGeEViSVFJeEN5cGMxcmE2d1ZESVBH?= =?utf-8?B?Z1Z2VTJLNDN4alhlQmJuOFBaL3BpTXFCZVJvQm9WbUUyM2QzT2thUG85eHk1?= =?utf-8?B?MW1kMElFQklxZWFQbXVsTHBvTVRjOXRBczNteDRpMzFKVVNzSlZRVXV6VnNv?= =?utf-8?B?UmNkVC9CQ3pscTFjajlDZ1dYMEJDTWNFaXExWDdkSHpjclFwRDZMZU91ODR4?= =?utf-8?B?YWhGenkzNzlvTDFMOHQ3aVNTOUVyVmNPbXIxNnFwZkZvVGVneG83Wm8yZDlZ?= =?utf-8?B?RFB0djh4bUpIZml4UUZ1MjdYTGg1cHkvWEwzaktOSS9IMUs5NnBTT1RjZzZZ?= =?utf-8?B?RWtMRG14MmJnWkpkTys2c0g3c2J6YlN2RTBIVDByRHpVenpUbWFnUnZjek80?= =?utf-8?B?OVlGNEtSSUd4NVZWVUkvVFY2c3V2Rlh6OWNWSS9acXVUWUg2a1drMXQ4cDkw?= =?utf-8?B?UWF5bXVVMnRRdjRXZTVaUWcyK2ZDemVpZURqdlFKYnBQb0FNWlI5NUgwb2Vq?= =?utf-8?B?cnhUdU5rMGM0TUU2OUNKM0NuaEZ6Q2tpdTFVbXVna0tTckhVUFZTYXNxbzNr?= =?utf-8?B?V0pFV0FsRFc1b1hSZWNITUU5ZlVRZVkxRk9SamhyaU9RU2tsN3ZCaUF0QUNN?= =?utf-8?Q?WB0kBdK9DLB66XQo5DHZTvH6N?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88c4e9d8-a5e1-4dc1-14a2-08dad2a4f293 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Nov 2022 07:31:51.5822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yNzb7OWa0ByQV/xka475Z2sgi+Owmwv7sHj6ca3KUWrw5+Z9AFsGa8XxIZLASUWAQtKl3KWK98Ff5N6CUUabUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7697 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29.11.2022 20:38, H.J. Lu wrote: > On Tue, Nov 29, 2022 at 1:22 AM Jan Beulich wrote: >> >> On 29.11.2022 00:49, H.J. Lu wrote: >>> On Thu, Nov 24, 2022 at 2:19 AM Jan Beulich wrote: >>>> On 22.11.2022 19:19, H.J. Lu wrote: >>>>> --- a/gas/Makefile.am >>>>> +++ b/gas/Makefile.am >>>>> @@ -446,6 +446,12 @@ development.exp: $(BFDDIR)/development.sh >>>>> $(EGREP) "(development|experimental)=" $(BFDDIR)/development.sh \ >>>>> | $(AWK) -F= '{ print "set " $$1 " " $$2 }' > $@ >>>>> >>>>> +$(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: \ >>>>> + @MAINT@ $(srcdir)/../opcodes/i386-opc.tbl \ >>>>> + $(srcdir)/../opcodes/i386-reg.tbl \ >>>>> + $(srcdir)/../opcodes/i386-opc.h >>>>> + cd ../opcodes; make gen-i386-tbl >>>> >>>> I've made a patch to gas/Makefile.am as you have requested in reply to >>>> my series. I will want to put that through some more testing, so I will >>>> submit a v3 of that only a little later (and of course only unless you >>>> submit a v2 of your patch earlier that I would also end up being okay >>>> with). In the course of doing so I noticed a few more issues with your >>>> change: >>>> >>>> For one I don't think you can put @MAINT@ on a continued line, as the >>>> line continuation might then be hidden when @MAINT@ expands to #. The >>>> list of dependencies wants expressing via a variable, which would then >>>> be used immediately after @MAINT@ without any line continuation >>>> following. >>> >>> Fixed. >> >> No, the same problem is still there. You either need to use a very long >> line, or you need to introduce a variable holding the list of prereqs, >> like I've done in my series. > > I got > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: Note the missing line continuation here. > $(srcdir)/../opcodes/i386-opc.tbl \ > $(srcdir)/../opcodes/i386-reg.tbl \ > $(srcdir)/../opcodes/i386-opc.h \ > $(srcdir)/../opcodes/i386-gen.c > $(MAKE) -C ../opcodes gen-i386-tbl I have no idea what make makes of this standalone list of filenames. Without the line continuation these wouldn't be dependencies of the two named generated files. > and > > $(srcdir)/../opcodes/i386-init.h $(srcdir)/../opcodes/i386-tbl.h: # > $(srcdir)/../opcodes/i386-opc.tbl \ > $(srcdir)/../opcodes/i386-reg.tbl \ > $(srcdir)/../opcodes/i386-opc.h \ > $(srcdir)/../opcodes/i386-gen.c > $(MAKE) -C ../opcodes gen-i386-tbl Again these aren't dependencies of the two named generated files. > I didn't run into any problems. I'm surprised. >> One further request at least for consideration: In my v3 I've moved >> the inclusion of opcodes/i386-tbl.h quite a bit further down in >> tc-i386.c, as I think it's preferable that way (not introducing the >> static arrays earlier than necessary). > > Does it make any differences? It is simply more logical to introduce definitions (not just declarations) not among the ordinary set of #include-s. And it keeps related things closer together. Jan