From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2070.outbound.protection.outlook.com [40.107.241.70]) by sourceware.org (Postfix) with ESMTPS id CA4773858D39 for ; Wed, 15 Mar 2023 15:45:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA4773858D39 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Eq6QA/ZunCGap8PNHYfTynaSZ7EXaUnl8chm9AGkqNJX64CaB0aMZdJPvAhbMrJyhJ+IB2jqH62HD8PU9koAUlvqLdCFfCuyAAFuY79B7flEb1IrOvnL+9qkRApZqjG5KcJPpR7FrRo9ho25JlDMHuERTa+STiiPlcx54YewxKFmzqdo/hkfixAPPUCPPeHTgQTuwkkHiUavtIoM4gAjv4ao8LHFQbW0rcAKNjyK4735lxq3hhfqvGaQSyxX+Tsqh9scBTewmXdcFpnryQRxLLKRxgwKQd8Scoig2qVi6dr2e/+7EaJktBTm/puVEEEPl7cVoS5rKWhTfXQUb3+WZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q49GiNumO5Wi7yMbMGBB3wLyI9H0LAgLDZOMdh44owE=; b=XnZ3sx+DAIGGZh0hQ40CBI9UZdUA69QLrnFGGYoEMjiBM0U1kmxoe5rd3Qp1YKXsBM3LTiTaBG/IrHUCqn7z0ZNzBr/5o7w8qYxHIfSi7giKyRd8O8zBmoQ5QIi3nHYsuP+UBPkxthRnNY7BsSKzzsSdlNR/Y41EDKLa26LxKnfYNQfTwOCyDZiLKGBS78f6C3SCtnnZWZwJ8kBJwGIaJodLQeu6RhKcleR+TyGtmtzMxHcFSlbBMhboKjIt2n20Szkx6dCGrI39Bjcaw9ysJGCy+RlcgIJl2x4RUscbJNMDdesb1L3EsgbmCX/LerzBefNuHt0/gJJ6Z2ahyCI/Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q49GiNumO5Wi7yMbMGBB3wLyI9H0LAgLDZOMdh44owE=; b=vb88cbKNHsqf///5uW1nPbSuHq8QK6BYOSuXhv2McjAzVSGn+jlRqBMksu7eMn72aMvh9J5mwabV04XIJz07tt9HkWmMhCBj9cH7VxIcpO3jZoiy5F4StL/HCqg1HwTIoxMCc3kNfP4Y7HOR1owaPgIXNraoA21Uum+RRuImcsykWR53RFTaIJma5eWsQOZE8eZBuhXu7M+kvU6K0v+LHI9fmzP3CGSpw4wlKZrM7uVBOYJIUApl6t+wnW6zGZUTzgcOK5E0n5rhIb1GsakUcRNKTBfXe5q8vMBy/SW4YoamvaC14zz2vcL1o/WXcbHrCRVHOA6yvsHG5TVa3VvXqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8032.eurprd04.prod.outlook.com (2603:10a6:102:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 15:45:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%5]) with mapi id 15.20.6178.026; Wed, 15 Mar 2023 15:45:39 +0000 Message-ID: <3f3d43be-531a-9ebb-b387-a57519df7770@suse.com> Date: Wed, 15 Mar 2023 16:45:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH RFC] RISC-V: alter the special character used in FAKE_LABEL_NAME Content-Language: en-US To: Nick Clifton Cc: Palmer Dabbelt , Andrew Waterman , Jim Wilson , Nelson Chu , Binutils , Alan Modra References: <150b4184-62af-3f5c-c07b-24b0c2ae788f@suse.com> <9f769d26-f51c-4f85-f61b-330226c1cc2d@suse.com> <0a576110-624b-6339-b24d-907d6df72e09@suse.com> <67df1a4d-223f-2b4c-4957-394a299fb112@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PA4PR04MB8032:EE_ X-MS-Office365-Filtering-Correlation-Id: ded957c7-5219-42c1-24bd-08db256c5387 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0VfQXOJNs89RcqgIFKPP9n5TOOBCIGhaQwV7K6Y5K4tgCCUqOB/6jLpuzj0idd71Xj8sGIyWZ0bmNvvrA9RqJ3FBBfeOFZ4pMM11WUNXVDjTjRHKmiD6BVpVXd46/uxBB+mM7Ixk/N6hmg8RJPL517YBuxfiFJZZ8rSb4sXAYZXJ/hdqbUu0n5E5gmRp6wOdr4sjsYokYFXBHCp8nPXGZH2TEb8o3L4rASKbWdC/8zaZrbTWqPNkVFe1/SwpLwh0GIjEI9nDc4zOERnr/35Li2D7Qnc9R1SnfMoEvz7Hqpz9YjCMsyKunWrek1drqI5SKxw8AeGFS+vCKfT4i80WPy1rhmgvIaMvTbnHb/ZeRnlGdVbkb/ik8eryzQdX2ah6Z/tkiKgh4I5NW4vKpserO7+L8/F7iFDPLK0BZaNlL/fPlrVmRTDuMQYgFthrUGyPi1u31SH8LTvtRF0KDr16sNaKSJhZJ3RBzr2qy6/62Fx1/YkcdefveNDaBMaCMh6BGeVQWnHB7JoR/Otse4A1Y0xdMhLeFzQpwfU4v6Jc6C/bAEbfRywPAGsVN7qn53xUS+0EzfT1D2v7aAI7aNJTT7Lj+hP4v2wvQ4XzTBL9LjFTapRaMd2UOdVCshBf3Ex4iUXH7b5YkgQVB4QSb1jD6rUCB3Ml4Y7hz7NqFei+sBEUfe1MMNTW20weSoAIEoyO94h1gw21mAAS8eYkKhUREAgwsuXdlQxBWBMOGRrLxxE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(39860400002)(346002)(376002)(396003)(366004)(136003)(451199018)(36756003)(5660300002)(83380400001)(53546011)(6916009)(478600001)(6512007)(6486002)(2616005)(26005)(6506007)(186003)(66946007)(66556008)(41300700001)(4326008)(8936002)(66476007)(31696002)(86362001)(54906003)(316002)(38100700002)(66899018)(2906002)(31686004)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlNZcnYxVEIwaFZmY3VrUkdIMWZYR3VrdFcvQ3dnakFNTGErM2lzWUpqdWRz?= =?utf-8?B?dEFLZ2xnYUoxNkJPRmVHVlpEcHQxcnhSYUpLOFNlQXU0b1A1Z20xMStEd1ph?= =?utf-8?B?S25YcVN3SkdXam11RnBMazFFTzRyaFFpMWhRaCtYOTc0M1lLVnEwQ1FMNEMy?= =?utf-8?B?MVZobm1ETWM5bmF0YXFxODZvRW9zUnd5b2FDRDhyMk9jaUdXTmEyZEhFb3lm?= =?utf-8?B?VHV3KzlEV3ozZCtBM2VoblRQUVA3MUdqTnFvQTZYQTNBSXRDK1BESjFuR3Nn?= =?utf-8?B?RjRaT1UxWWdmYjYrQXl3VHpCNm5iT1gzOTJJdXNmdlI5RTU3YTNvWi9yUmdU?= =?utf-8?B?aXdkM2JzQ2RIKzd0YkRGWno1UDhhTzJZMmRoT2ZlYVFSUWMwRjhsNUpoRUYr?= =?utf-8?B?UDROSXhyNllMODQ5Nmp4bDZNa1M2TW5FRldZOXhYT0hvd0NmSzJMemZvVzQv?= =?utf-8?B?NEFackhzQ1daSnlNK0liVWZWQVBDMk5YRThJSzBGeEhQeE5uT0NWQUZ4SEFi?= =?utf-8?B?Z2JBdHZNaTNpNjZ2U015SE95di80YS9FWkRmU0I3MnFEQVdyUTNHcEwzMHE0?= =?utf-8?B?ejdzam0xbzdIaHNIN0NlRWU0aTBRbFU0emxkcUlLaWZrNDE3ZU5MOXA0V2xZ?= =?utf-8?B?QWx0OVJsaGw0bUt1NlA2U29yUjZPY0hDUEFIay91eER3eHN3dmI3S3RqOGxM?= =?utf-8?B?R01rQnQwMXVQOFN5bUNERlBTY0dubnBtL0V5TERJM284dDU1ZS9UbEMzMExF?= =?utf-8?B?TUhjRTFBRjBqektOV3U5R2Nta1QyVlVEUWFYamJFbHRxQlh6SEorRzl2dUtT?= =?utf-8?B?dXVBUGJ5SXY5RzltWHNyVkl4a3VLa0lna2RBVHYxckR4U2NvUUhpR0ZjOGRE?= =?utf-8?B?aGVkMDA0L3hZcFpGWnJPSUNnUjQ4VGdpSlJ1VUJLVW1zSVc3RERPZHVLdXNQ?= =?utf-8?B?S3FLdVVubTF2dlUyMWpJZjVRWS9yOGhLV2FIMC9ibW40TzVXK1BkaUNxbGVM?= =?utf-8?B?U0ZpbEpidWN6QVRhR0FlTWhldXd4dm0wMkEzZmNJeWVZOFhlWGdXMEhLZ200?= =?utf-8?B?TVhEbHZDUzRKV3Vrd2NaNVF1bTZqSU5WdE1mTkwwTE00L2hNa3RnZExvQlE0?= =?utf-8?B?S01qclE2Zm5ESXVHempIdzFNTkJheVk3UnQwZVZJYW9ra2ZFQWozSmgzYkpE?= =?utf-8?B?Vk5WREVnNGNNNGZidlU4Zk5nTVE0NEVlMXh4cnk4dmdRTzlRSEthdzFkeXhN?= =?utf-8?B?ZGV3aThwU2pkYkRGVmh5NEI5UFJZOS84bFdWd3NTcXNtYTRyRnlsRkNqV2x1?= =?utf-8?B?RjA2QzJhMmYycGVyeS8vSkIvemx6VndkVUxKakttaGJacVovVWZpZ1Q4d0RD?= =?utf-8?B?UFVRTDV3cTdzWml1aTdkY3ZYRjRFeTZnQkRJSG81bkJlOENMemZMOFJFa09X?= =?utf-8?B?SXdnT3pINisrcEdPYU02MWhrM01GNlk2R011UWw0ZXR2MUtUSVY5YnVkQVNs?= =?utf-8?B?dW5nVlp1aUxWdWdkWWVtcU9yQm1OU3VHbWFiYUdHMXpoN1RmVDBFSzBveDc0?= =?utf-8?B?WC9Xd0xNb3ZSUG9lSUVWTXg2dnhYeWlTSEVjSWVBVGNRdERTOUh6Q1p5dWhV?= =?utf-8?B?Q0dielozSFp0QVVoVTJJZklYQ0NWRWNTYTBDUG9XcmdYQjE4aWQvRTQvcXBE?= =?utf-8?B?d2R3UjJLelQ0N1k1djBVbEpXbDZZYzdFamFGc2JFbG9iaW5KUG4zU1BMT2NO?= =?utf-8?B?QjBFYzMwSTUzeXlXdmROZVBNaWMzZE5MbXdmcjA0bnl5RnJnOFNoajhjN0dQ?= =?utf-8?B?Ujd2OStoZjdManVXSlJ3L0svMDNjVFhUWmtGRUxvaHBSeTRaMWpqWEp3TlV6?= =?utf-8?B?TmxqbktxZmdmOTZ0d2dmZXByRUFqbHU4T2ZRNlBzd3I5MW5hNHJjTUxrSUo5?= =?utf-8?B?clA3bWxxNXpmdG44V2Z4ZnBYMWg3MDl5MkYwRUxXUmg5dTlFZ0dEQzczVnFZ?= =?utf-8?B?V1duSFhQWjBuL3JJSENFdzRKSWFhRDB1bVhKNDFBZDVDamFRK3pwWTZuU1pN?= =?utf-8?B?blgwaDJQVjlObWU5bjlkS0lJSUlIVEs3Vm5JZG1OZE96YUtMa0s5S1ZqN2I2?= =?utf-8?Q?0DGyzjmeujfm/MBvMxhXYQuuy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ded957c7-5219-42c1-24bd-08db256c5387 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Mar 2023 15:45:39.2524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qo17Fah6tcWOfghBj9SsoNY+YCyAQ+pcV17owfkg5WWXRabj7Huc1BMxpjvC1lwbLRJUEgiSyHxwHbN0Vb5NIw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8032 X-Spam-Status: No, score=-3028.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15.03.2023 12:08, Nick Clifton wrote: >> I wonder therefore whether S_IS_LOCAL() and S_IS_EXTERNAL() can't be made >> true opposites of one another (with perhaps one of the two simply expanding >> to a call to the other, inverting the result). > > I think that they are actually testing different things. The way I see it, > S_IS_LOCAL() should return true for any symbol that is not intended to be > seen by anyone disassembling the code. (Unless of course a command line > has been used to change this behaviour). So for example labels like .L1 > or ^B1. This does not however mean the same thing as ELF's STB_LOCAL > binding. Local ELF symbols can be found in disassemblies, should be present > in symbol tables, and represent something intelligible to the user, rather > than something invented by the assembler. > > S_IS_EXTERNAL() on the other hand is meant to return true for symbols which > are not only exposed to the disassembler, but which also have visibility > outside of the file which is currently being assembled. ie in ELF terms > symbols which have a binding other than STB_LOCAL. Oh, I was mislead by the name of the function (would perhaps better be something like S_IS_INTERNAL()). And I should have looked at the doc of course ... So one thing to do would be to, as you did suggest earlier, actually honor BSF_GLOBAL. Another difference is the treatment of reg_section symbols - should S_IS_EXTERNAL() perhaps return "false" for those, ignoring BSF_GLOBAL? It would look to me as if there shouldn't be any symbol for which both functions can return true (which could be achieved by having S_IS_EXTERNAL() first call S_IS_LOCAL() and return "false" if that one returned "true"). Honoring BSF_GLOBAL won't be enough to deal with the quoted symbols aspect, though. I guess we will need a new flag then which identifies symbols the user created (and certain equivalents); this might even be limited to symbols whose names were quoted at the point of creation (at which point "certain equivalents" would not be relevant as long as internally created "real" symbols don't contain any special characters, which I think is the case), as all we need is something to bypass the looking at their names. Jan