From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-sender-0.a4lg.com (mail-sender.a4lg.com [153.120.152.154]) by sourceware.org (Postfix) with ESMTPS id F25E63858D1E for ; Tue, 13 Sep 2022 16:58:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F25E63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=irq.a4lg.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=irq.a4lg.com Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 5E606300089; Tue, 13 Sep 2022 16:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irq.a4lg.com; s=2017s01; t=1663088309; bh=ZSA5peGFAjyb1h5ALs+sNldN+eN1BNWhQ9eni6SbJ+c=; h=Message-ID:Date:Mime-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=B+pRuKZ9OiYkJXnigG6EVLeRRG/e8vh7lb0KKQvAuOTkk2QSIinxcfAve/Ed5ZCIe rpWJ1vIRTRSRsvImst5cbHIOVckgemP9CGrmatncK9W9xrCSakdfTmuOpOmmHhT9RD +TI+a92AV0qbUGKop4FeF0dIbe6gjCMu1jhTETFU= Message-ID: <404479c2-9ba0-d648-77ad-49262ea9d524@irq.a4lg.com> Date: Wed, 14 Sep 2022 01:58:27 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 0/3] RISC-V: alias insn adjustments Content-Language: en-US To: Jan Beulich Cc: Binutils References: <7cb92a0b-d1ef-e3db-4773-0b6cd5183272@suse.com> <60d3c0a8-ea0e-0d80-0371-d47a77a8c308@suse.com> From: Tsukasa OI In-Reply-To: <60d3c0a8-ea0e-0d80-0371-d47a77a8c308@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022/09/14 1:11, Jan Beulich wrote: > On 13.09.2022 16:54, Tsukasa OI wrote: >> On 2022/09/13 21:59, Jan Beulich via Binutils wrote: >>> 1: re-arrange opcode table for consistent alias handling >>> 2: drop stray INSN_ALIAS flags >>> 3: add alias for SLLI.UW >>> >>> In particular the 3rd patch may want considering to be at least slightly >>> RFC. >>> >>> Jan >>> >> >> +1 to PATCH 1-2/3 except we can just add -M no-aliases to existing tests >> zbkb-32.d and fence-tso.d just like my submission (they don't test any >> aliases): > > I'd consider that wrong - disassembly should work correctly in both modes, > so both modes would better be tested. After all it was just one of the > two modes which didn't work. > > One might further consider generalization, forcing most (all?) tests to be > done both ways. Good point and I'm convinced. Then, how about using like "-noalias" instead of "-na"? I like the names that can be understood without looking the source code and we rarely use acronyms on RISC-V GAS tests. Thanks, Tsukasa > >> https://sourceware.org/pipermail/binutils/2022-July/121674.html > > Oh, I guess I did see this earlier patch of yours and then forgot about > its existence, re-doing the work. > > Jan >