From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2081.outbound.protection.outlook.com [40.107.21.81]) by sourceware.org (Postfix) with ESMTPS id E12F23858D33 for ; Tue, 24 Jan 2023 07:29:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E12F23858D33 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HCG241J954YXn23O7m2r6WsW4tiQHbwu95A9NwMEpBOFOQNs+CaxgVy6BgclXjd3BELv69UkT24tb8vAxX/68Ts3Dh+iWWqNi8072V+LxJV+taxkxfRRCh9x+Xh94W47+kxh92PSCBJCLtUhfY2t8vBtXqE98OQjjiSiVM6D+/+H30kyny4epzXgMQIY+kr272sMEVFHhTFNng7qxWBgCs/m5jLmTYkeWVmX1RUwdQkgVpOnh/eUX1NsMyxbwGcQcClvlM+Bg0T4XyZib3W3BuhBk4o5xUAhLA2vSMFSjtnzI4AOxNW18EmCL5QQ1B8lf0YPDrS9nbAf4IPmFKVKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jh8paY5XItZDSFDH1Lu67UJ0pd37x8W5muAvxE9gi7s=; b=f+JQ/TVwagn6/aBazZg4Fv0t/CARdAyzgNGH9RsCMp3FK1EinW0jaCfrpG/HGBqg1rC4mySBw3ABzyv9m964asSGTS5w2NgOn1BoCwa/BUCH4RQdhLCIWkuiIlk6HEz+lpTIY/4s8XTN9s7TsHNUqIcYMALvSvMTAbl38ytgMnWMFmpM8Ubd20AQOUTT8WWzqmKy7YFbkmxRdhy/NH6jJGyasauID3iIygHAK9YRBAdIdDfXOp91QzFwAanSHpLP5oaE6viICidxGfPtDmDAww6tbd4cA2pl4wOzevYDqhopLs0jptIs+ZDm2gfr8deVnwanWLVuXgWTbVrSE0LkIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jh8paY5XItZDSFDH1Lu67UJ0pd37x8W5muAvxE9gi7s=; b=KmWtlqzYP/6c1he4CQ3anYSbolEvZPVlAvaS3wKN+yVFdYLfjnXRZ00n3ueeg1yyFWGgCX/24IcpPfqllPovnU38U43tYbnE8m+7lCWs+6QAq+79yQ1tIHaO+RmbQpKpTsnNYzuj0pqCFcXiECnOk1gcLEt9Y79YgfIUutIP9XE/XHgSAfD6UUX9RKm7bHAYJHz7GXXFgwd5VHkbudsa2WhNXhzYfi3K4MhI5SNgp+DFqezmkV/KvfV8eYKLF7A2ZGhu1yh+N7wwWQqE8JswxGEqZy6OTkxvsRa95v4jO9Xz4PhiAVNEhUvS6KHjm3oiVStmw21xa1Vatmsu1xJp9w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7381.eurprd04.prod.outlook.com (2603:10a6:10:1a2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 07:29:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::2991:58a4:e308:4389%7]) with mapi id 15.20.6002.033; Tue, 24 Jan 2023 07:29:51 +0000 Message-ID: <406a3491-8dc6-e027-092b-f8c4b5a0215b@suse.com> Date: Tue, 24 Jan 2023 08:29:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ld: Add pdb support to aarch64-w64-mingw32 Content-Language: en-US To: Mark Harmstone References: <20230123230154.17957-1-mark@harmstone.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20230123230154.17957-1-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0021.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DBAPR04MB7381:EE_ X-MS-Office365-Filtering-Correlation-Id: d193be05-8130-4fc1-6b7b-08dafddcc7c4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lXwSZZOkN1g9WzLlOVzVJa29jF7/LPUFGtf5nWHgKZ6RPbGPEGsb1iaQGIRi1KhwmUql5ciVa3HSLkZnmo/uk53mictdWGLqWEa2uxCEayccqW/cug69+2AH0rG3VNWsENiNNiqQtHExcVdV7bey34ZC9a1CiNkbuN6YjdEU0cfBi64Q7rTn5Cx9E3CSZviS48VoGtS3qKbQCqDRXDPMCoGReWLDzHE12EUNhfPtzluoHTDhwYDQ1wb6hXXCJqymxu10auIEwqWwdaBipHF9NlIySNOVvTIUOppxcMI3AHpt4ETbUsONR15THIiUuuXot0AJfq3LEAdUzYPEuAHYrDWppz8ZeymllwH3cy7mm+Zss18eM8Jnz/FYg6OAHp8b4b6uUvc92DaybF0iMgwOZp8+/MQxANH79a3p4sxcw0tKYbY7CWG4dziASBBqbgrpQ4bUGNVLsVchYtzsCZoRaEZh3Y2hn6A7u5ylcMCfz0dxys9q2h5eAzPxeZcnBCoViQMazSbZTuy60Qhjl+BvwtZHnJRv49i8VwkS+qbd0l0lHj2Cco1lcQS1ZJB40tUfEECQQTWmgyyINV2krFHisKTq15Z4tqczymRRqT4yrUURtzLKnMd2yS+eC2miSqbcyMgPHRwgGYePYPRJ4CIlLaZL8duuM3+T00lJyX8PP0OPvaqMa9HqLwW6n6ifgqADeDBa+rUr7zYSbitbp1IUzrUGIFCPg67L9kVHFpcTM0k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(346002)(376002)(39860400002)(136003)(451199015)(38100700002)(41300700001)(86362001)(4744005)(2906002)(5660300002)(8936002)(4326008)(8676002)(6512007)(26005)(53546011)(6916009)(6506007)(186003)(316002)(66476007)(66556008)(2616005)(478600001)(6486002)(66946007)(31686004)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VllOeWRINlhzaUVpc3hVUGcyU1loNHRvWlBrcU1BUHV2QzRONWpyT3BqTW5L?= =?utf-8?B?OUZtK1R4UkdvemhyVk96UEdrUkFYd050ZFBQejNab3FuSzRjZ3BmV1hrcDBm?= =?utf-8?B?SHUwMEQrbUhjWXI4bEQwTUtKWnN4OVhDUFV4anJuSGNKTHB5Y21wOEJCV3BN?= =?utf-8?B?SVg5NDRrbk96MUs1Y1FCelJKMkxiY0hDRVFKVVhMK0ZrNE8vbnV5VmphUzM2?= =?utf-8?B?V2JhM3JoYkI0ajNIUU9Na3ZQaFhpRWFRWCtub1RHYVVGWFArSHZkWVRENVVS?= =?utf-8?B?Y0hYMWRpOFNabjFDdnB4d0JicWZqbThFV2tqVjhPalR4WXdJdFVOZUxrNDJW?= =?utf-8?B?MUJWZjVKYkt4VkxIaXVGQThNNVowWVFxZnJ3NjdaN3c3T3pUSXRiWlJ3V3BY?= =?utf-8?B?dktBUTJEbjFMR3pGMFJjUDRTVWFJYXJJZ3RTemk0UXprbFUvRmNsbnRNVmRK?= =?utf-8?B?cFd6Vnl5d0pZNS9jZlYwN2FIaE9SLzNrd0JoNUtrUm9qL0I4MkxqeUhTSjIz?= =?utf-8?B?YkN3Z3dRRlVMZXJGWkd0TGRaTjdNaTZFdEJETXJIOVNOa3VuS01GdytQQktR?= =?utf-8?B?UDZBYUF2ODNPZzY4Ri9XdmZLOENYbmdYMzE1M2JOVUUzWVoySXhKc3FvR0J6?= =?utf-8?B?djdVaTJZSUhRdDZxMUdlWHFicEk4Y0RteSswZGIwMkZSSjU0b01XZGlVdjlY?= =?utf-8?B?UEdPSlFFUHlTODZ2M3l4WHRUUEpJczFhcmYrbU81bUhjOGErbWxtZ3BQWFBW?= =?utf-8?B?aWR2RnoxaHJ5ZFZlNDEwYmE4OU1DeHV4TlFJcUlCTVdpWDJZclluTW1oS0hZ?= =?utf-8?B?TXdtYkpLVmlDVXZzS29KZ29PN3pZRkpyNXZpNThjV2VrS29zTWFCQU93ZVhs?= =?utf-8?B?QzU0L3dxQ1hRTENmeHFFSkRsWFdxeFpvb0FsSGt1MmxXd0Q2REdiV2c0Zndi?= =?utf-8?B?MXZMQWlvV3FLb3RMRmZScFhMVHZlT1dCR1p1bFpnOHdVcWdMR1E4S2ExOGFF?= =?utf-8?B?WXhuTmE5VWxQQWgzYy9JQytIOXhSVmppN2hZdWJERFZIZU1GTkU1d0dneG0w?= =?utf-8?B?M3FQOXRsNXBodUNqS3NCQ3Z4UzBNTHhjVEJWZTJFaG14TSs5SnBnSno4bFdh?= =?utf-8?B?WERvMjlOWGhZc1VGMGpKU0pUMHluRDVETVpQSXBNUzNuSjU4MDM1NlBYbFE3?= =?utf-8?B?cEV3d1J6SmNrTFJXMFFxWndDWkdndm5tRTBFSGdnYmRIdTJ3OWQ0bHlLd0x3?= =?utf-8?B?SUdZalFHak5udVVET2xDWUtlMGtHcktva2xlazZlZlhJT24razcyaFoySHh2?= =?utf-8?B?OGZnOGp0TWVEd3ZGazlzRHlYaU5QSHpyWnMvVElWWVFmSW53QlFyMUZYcER5?= =?utf-8?B?c0VQL2UvTHJuSUZOeTJBcXc1aUtTMGkxL1lPNU1xeGxaMmgvRnZmYVEzVzY1?= =?utf-8?B?c0FobWdKaVlYdVQrRzNTOGpXTytpdTgyMEp6ZUt4WVZnTTRDQ1pIMnhJUzBO?= =?utf-8?B?S3NUdUIvZDhxMnlTNVhzWWtFZjZlWFdZWGtEcjY1UFhWMjVvNlJuTVpqVVpH?= =?utf-8?B?dEh3dGVUUm9yemhGOFovMVNnN0RHeHM1bUNvTkJqYXgxSUlGMEZTK2pLNHhj?= =?utf-8?B?bVVMWU1FNVEzelROd25ZN0JEeE9XeEVDK3czOHpYM2FtTlVEOUVEN2VLWEV2?= =?utf-8?B?aU5NUkN1bVVXdDZIdURPbGJtZnY1QVorSVRoK0hzd2UydTJmc3l4K3B1Nk8z?= =?utf-8?B?amhQWEcxWnFyUWtpbDBDZmJLSlF3Y3BUTk51K2dBanpNUE1jZlU0WVZGQWsz?= =?utf-8?B?OU1JbXRNTHVTYWx4dVVVTHJWYnp4TVpSSnh1ZUl0OS8wb0NBN0l6RnNmbjV6?= =?utf-8?B?Sk1ISy9IY3BldHZpUitrcVEvVnFRQnVEWTArazA3Qk84UGMrVTA4ZzYwY0Vy?= =?utf-8?B?TXJWYktpOHhUN0NoYzJZNDU1VElERGxrUndBRFBtSzdBQzZJa2h2ZGQrVjV0?= =?utf-8?B?QjNKb0poemszSXBneXF4M2IwRzI4Rkd4Q2s1dWtUQmwyYmRieTl4a2xZc0ly?= =?utf-8?B?TFZWMUE1dXRKU0dQU0FDcUwxK2lYd0ZSdFVZaGdNc2VSSHpGZzA2cTFhbFAw?= =?utf-8?Q?8teDJeCuc4qxRIaTW1cIuOP7r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d193be05-8130-4fc1-6b7b-08dafddcc7c4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 07:29:51.7048 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WZvkX278KhyZhu8uUUo+r28RHsa2oxhZswgJYXbcOk6XqolridFCjr0FiChB4ISwKgsubC0bmhTx67CPAY5Omw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7381 X-Spam-Status: No, score=-3029.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.01.2023 00:01, Mark Harmstone wrote: > This extends PDB support to the aarch64 PE targets. > > The changes to the test files are just to make it so they can be assembled as > either x86, x86_64, or aarch64, mainly by changing the comment style. > The only actual code change here is in adding the architecture constants > to pdb.c. Lgtm, so feel free to commit. One question though: > --- a/ld/testsuite/ld-pe/pdb.exp > +++ b/ld/testsuite/ld-pe/pdb.exp > @@ -19,7 +19,8 @@ > # MA 02110-1301, USA. > > if {![istarget i*86-*-mingw*] > - && ![istarget x86_64-*-mingw*]} { > + && ![istarget x86_64-*-mingw*] > + && ![istarget aarch64-*-mingw*]} { > return > } Why only *-*-mingw* targets here? What about the others also permitting PDB generation? Jan