From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2057.outbound.protection.outlook.com [40.107.247.57]) by sourceware.org (Postfix) with ESMTPS id E3074385220E for ; Thu, 24 Nov 2022 07:24:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3074385220E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWmurtEWyEIQoP3hEOoOvd4RDrDmq8zw7tucEgbOM//JYpRVcYI+fTdIPaPSByH3PxQowcrtBjJ7LRMiambSW+1RiRlNOXh40o+EMCCe2WP66SeLV/68e1qTJW2r6tpYQxyPLzYR6XzdOb4tNJ4CJnAT69R4zjy9efwBuWGdAz9QhNbbMYyA64LsXD4ME6o9ZmaARQTS+y8QiiL9sJSwYLIcz91vqGcSRTsYNDV5TZqOkrnsTIqaIdvFeNQMiKYxBQeLlmLuTNYfyQJh6l235V1Js9iVxxtRHHWLtpUWirWG0Fpix9f50wkIy9f8qbLiyDgiL4w+KRE9QoVQZC1k4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c5fSbEa/XsSkweKcdHwINAb94Q4C3+iemsG6N1FJdfE=; b=ROVvOsFqqfUuYgXGGeOkHoEgFWZi9WsJseEm1AhSyUGfBP/wgKOmbU34ZEE4Z91rYpA7ZUde0WtTsQzTuT/1lgUfKoYZ/oOXlzV8fm5xofTfniweVjhQ3rSKDESpx3XHnNgnKVX5CkHLJeQIQ/tx1o2BfP62Z4UzF5ZkEeh0uR6ztMjVJsaAM3CW7WQ0XiYtptT6jPPIMIkEAtCtFllN7d2WJxJp9wHfZQebAmPDEkk4dq7KnV0YMMUMHMPUwS6J6d5lS2xCgrr/I+RndzQVvsDgGc3em2kx0oWwlzhEVYHqn4+477ruNkXF1L18l+hbKCk8cMcWhn38dg6vt38ZjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c5fSbEa/XsSkweKcdHwINAb94Q4C3+iemsG6N1FJdfE=; b=em4xAeZCu0oxoccwogyhiMX5V8z12aHopcvfnJ02/ojFVObCL/UmmOgTz1qb8V3zd0l9m2ydZtV1vj1R083Fg0grsh3SyoRJ7XhuIRfotK0M26evU5m7kesOXQonbaKSgfENfizyYVywrevV7KssoZH/VxH/2ToXKi3N8TH+vERnXDsUrdllVdC5/w87XoTiwIs4GMEK4CjqIebZco4LixLAB+wdoKHZcSOaXe/KUjJ0nZ7xVp8pUHgdPywoevUKfi+IOGDM53irxn7pTSchRREMH7B2Yp8fd1a/cL3j1qwtqgJYJqfXGw8n9FE6DMYdZ2ItD/SalJ6KMMghLbGe2Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7495.eurprd04.prod.outlook.com (2603:10a6:20b:295::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.19; Thu, 24 Nov 2022 07:24:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::4da2:ea8b:e71e:b8d8%4]) with mapi id 15.20.5857.019; Thu, 24 Nov 2022 07:24:49 +0000 Message-ID: <407401e6-1e62-7287-8fe4-ea4b436fd5ea@suse.com> Date: Thu, 24 Nov 2022 08:24:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] ld: Generate PDB string table Content-Language: en-US To: Mark Harmstone References: <20221124034051.11711-1-mark@harmstone.com> Cc: binutils@sourceware.org From: Jan Beulich In-Reply-To: <20221124034051.11711-1-mark@harmstone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9e::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7495:EE_ X-MS-Office365-Filtering-Correlation-Id: 16e93a28-ff37-4d0f-782b-08dacdecf8b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hXQMtGVzfSkyzOboTXrsjoAvhXpqDSjc9eK7SoDfoF1RsqZwdAHuQlcNfH1Qb3cYeDXs1YubPmujIEhsntR2aH0JK1CSeCUwQuTJOJvfPRJLdvnFul/n6Uk6Gi9ri2VddQX4rX6MZAxxXgo8ds/vJXDxyJ92rL7wgY5j6gzdDQ5x3PSnKKfEn0M2vAz67TE82IYbv2NesteBtpNFK1vtMgfGmGQk42hCGWF3BKzkpbHLedLb7H3IRu8y7CnnMscNqMh5La+VMUNY09ZVbAk2P69O0tvJE5b4FUISBWFnl5OUSumv4XV1f/Dquzh22QDyf7WY1t2OTwH7YJ4hBV4XzJjlnV/pSm6jmp84/XqbBt+pdOQZw+zZHdgbuGEthXFwT5oRXOWyP27tmBITLTPZxEI7TGlDIDUtWNJzJzjwVruznBI5c1MqCKSbEPPp+tQHvfbCrZ//YpV9sxNCEqBa6W4B9nr6Ykw4MaSU7YxDY6F1waM1IA/0c43bNbG/xoRE9rD8+j7lC66gz+1G81UF7IBn+Xj87KhFbPvtdEe93QL2UmkAyoWmU1ZFFJtx+DU/ee10S0RQa7Vbdz8zTudBXRRE2eGHoyWO25y9wljqJu59DclVOCbcpBerMALTVO1fcsHXAPmWNZdbaMirNpv/3kJ2/VC6f4veyr7d2RLr+IbkDDlOifU/6VEwc7qdN+vL1DrPleqmbeglqcEWYAujr77LHbdcDHLVORAQZZsMtj8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(39860400002)(136003)(396003)(366004)(376002)(346002)(451199015)(36756003)(31686004)(86362001)(8676002)(66476007)(4326008)(66946007)(66556008)(6916009)(31696002)(38100700002)(478600001)(6506007)(53546011)(2616005)(6512007)(26005)(2906002)(41300700001)(316002)(4744005)(5660300002)(186003)(8936002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODB4emtKSWNGNVJBR0tXMGtpOEo2elRSdkRScmwwZ0ZaRnVjQ0dPamNxd0Ft?= =?utf-8?B?bTZxZS9QV1dFUisyeVdIZzZzRitMaktLa1FyOGR1TmUwSTBWQ3NaamdyOXpV?= =?utf-8?B?ckk1NEpkM1UzUTE1bnZQTStMbis2dU1QZUEwZjhQVUFSZnYzVGRndDhNWUw4?= =?utf-8?B?a1BGTlRFU3FUK3lNWjFuY3R1cngyU3F5Q1duVlJUOWZ3L0JnblJvN2k0ck54?= =?utf-8?B?S0p1R08raUJXWDdRQ3U2S1Vwc1gvRnN5NWZOMStaRk94ci9iY0Rsdm9vNHhN?= =?utf-8?B?SWpZTE92UmorZ0k3aEFYd3VMdGRFcUV2WHA5ZE5IaVRiUEdYc2FGN3dlYVpi?= =?utf-8?B?Q3ozQm5UNGxiMzJXMVNqTFdRNVYvWVh5ZGZ2RHp5NVlBUXF3TVc2cFhRT0Rw?= =?utf-8?B?cjdvMUo2QXk2YmRJSkxORUtOVzgwdWQ5TzFnWXBiUGdHeXQ5RzZQM0lXdDhy?= =?utf-8?B?Tm5ZZndueVVCNys3TVJTSEtIakFTaERoMFZSdk1IQjNwR3EyR1J0NW5TSjd5?= =?utf-8?B?RE9WaWZERW0yTEFleWwySlNRbVk5NCtYejdVTzBlVkx2a3pvMGZpWHZ0eXc0?= =?utf-8?B?dXl1V2U3QUF4SldoV2dTemFyaGFOUWNwVkg2U21YR0NIQzd1dm5Ba2NjWnBy?= =?utf-8?B?ZHpxR0VnTHl3a0dVanRmVDNyeW9Hc2dWcGphcCtvbHZqOTR2UUZkYjYyYmNa?= =?utf-8?B?Z2RKUnA3ZWJKV2NKTER1eHFCNk9HZmpKZkJtZzYvRnpLZWtZQ2d6YlVDYk1k?= =?utf-8?B?bEttV1U4K2dkWm5MVysrbFV4VFBQblNrMlE5R2lZVXplbmFLTFcxSlN0TnA0?= =?utf-8?B?MUpZTWF6WC81Tnljck1QUUdiRUYxOTAyMDhPTWhqZW5CZVNYam5RSjRNWEZa?= =?utf-8?B?L0sveGsrYW1ZcllhMmlITk9MbkM4SitBR2lpaUtxYmZETFBmaUIwSGFwZ3o4?= =?utf-8?B?N0tuUFFrREJvVHZPMlAxcUh4M0lnK0xpLytZQUN0WXVuTG1NRmpIRHUwYS9i?= =?utf-8?B?OTlEV1c0Y3YyOUhrSFcyamZ5dnhpUzlKSHZLWUZxS3h1bUp2K09WY2toeDNn?= =?utf-8?B?SXdrWHN4a25oeWcwM0RjdlRvTExFL3VzdHc5aDhRaWtXVnlkbmRhRyt2bjhP?= =?utf-8?B?OWVGMGd1V3hvMUpBYzA2T3drckdZMGYwNWJleVAzY21Wa2hwdUNHSkJiditD?= =?utf-8?B?WFZEZ0EvTEtTMjFZaW91eXFacVVVbGxGMHNNY0kvYVNMUDA0ZHd5WWRoeEl3?= =?utf-8?B?RTRzMHJGQXRlajgyWGgxOTgyZVlScm5lTm9ORzNJdUFYVm9GMTFRR1dyMkgx?= =?utf-8?B?K2pmdmVSN3BNMXdUUWNPU1FoSVhiQkliYlJ4VVp2cFU5RmlKZ3Z6ODNMbmFD?= =?utf-8?B?d2pyZDJWTHFjMlJNN2VBZUNRams5WFVjOGxpTUJPM2ZLckNQbk5jR2FtaXVa?= =?utf-8?B?YlZ6bEtiSlhiZk82VWNBMm1URTZxdlFpR3FHT0JkWWJSRUdRSXY4YWRNc0tj?= =?utf-8?B?d0U5STZOelMvWWgzdDZGUFdPZGRrSUQxa1B4cnlKYldVai9PNUcyTG5KRGNp?= =?utf-8?B?TkhrbUJqN05kbVYyWVRxU1dFY1F5bVlicVZ2eU5oM3l3ZmFYZk4xY0VscURP?= =?utf-8?B?KzdBeFJoMldjdzZrWEVsYXFOYm1YZ1VNd2cwdEsrbDVaVEkyN2IxVjJ2OTlX?= =?utf-8?B?dEJQQjBHdW1jRzBTd0kwWFFRQW5nU0k3N3NSQ1cxMVI0QStEWGZtd0FTbGgz?= =?utf-8?B?QzNONDJCTDMrRTVOSUMvYWFqWU5zZDF3KzVpR1doK2QyK3g5bXNkZEFFMVNN?= =?utf-8?B?TTRpaEFIWCsyUUdtclVFNHN4VmQ2UDd4ZXhTNS9OWERlR1NoS3R1L2FWWXBz?= =?utf-8?B?cGhkZzhCcGNyQ0Fla2JZdnZ0Y0g0QjRDRVFVYkpobHdhM2VEZ0o0MnFBQmVV?= =?utf-8?B?SVpENGpWZUJDMndpUWtoaHJuNnFabEJsRzhMNllPWC9EK2QwallFRTM4cUhE?= =?utf-8?B?VDBITlNiZUU2cHgzMEpzdDQ2SnM1SjVwQldPNVB0OHd3SmZxTGhieXhpUU9B?= =?utf-8?B?aHBBakRWZnlady9IbGtqL1dwVkpRTmFHTmgyRXpYclBXbmg3N0JjdGNET2Zo?= =?utf-8?Q?hRV131snP19RkK5kAXOvTQHyl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16e93a28-ff37-4d0f-782b-08dacdecf8b9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Nov 2022 07:24:49.7101 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7qHyFO1maOL4Lxws0MNYqfLaGDL2xKbd4IdM4jyqtsd4j5M5KgSU2e9honwIyKPqYXBezjZMvBTuOCZgo7zElA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7495 X-Spam-Status: No, score=-3029.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24.11.2022 04:40, Mark Harmstone wrote: > --- A little bit of a description would be nice in almost every patch. Beyond that just one remark for the moment (I may be able to get to this later): > +/* Return the hash of an entry in the string table. */ > +static hashval_t > +hash_string_table_entry (const void * p) > +{ > + struct string *s = (struct string *) p; Whenever possible please avoid casting away const (or modifiers in general). Here I don't see a need for a cast in the first place: "const void *" converts find to "const struct ... *" in C. Jan