public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* RFA: fix fill size output in map file for cross-linking
@ 2004-05-06 13:57 Joern Rennecke
  2004-05-07 14:51 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Joern Rennecke @ 2004-05-06 13:57 UTC (permalink / raw)
  To: binutils

The linker prints out four bytes of garbage as the top half of the size
of a fill when generating a linker map for i686-pc-linux-gnu X sh-elf .
This patch fixes it:

2004-05-06  J"orn Rennecke <joern.rennecke@superh.com>

	* ldlang.c (print_padding_statement): Cast size_t to bfd_vma
	before printing it with %W.

Index: ldlang.c
===================================================================
RCS file: /cvs/src/src/ld/ldlang.c,v
retrieving revision 1.143
diff -p -r1.143 ldlang.c
*** ldlang.c	30 Apr 2004 14:26:09 -0000	1.143
--- ldlang.c	6 May 2004 13:51:00 -0000
*************** print_padding_statement (lang_padding_st
*** 2490,2496 ****
    addr = s->output_offset;
    if (s->output_section != NULL)
      addr += s->output_section->vma;
!   minfo ("0x%V %W ", addr, s->size);
  
    if (s->fill->size != 0)
      {
--- 2490,2496 ----
    addr = s->output_offset;
    if (s->output_section != NULL)
      addr += s->output_section->vma;
!   minfo ("0x%V %W ", addr, (bfd_vma) s->size);
  
    if (s->fill->size != 0)
      {

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: RFA: fix fill size output in map file for cross-linking
  2004-05-06 13:57 RFA: fix fill size output in map file for cross-linking Joern Rennecke
@ 2004-05-07 14:51 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2004-05-07 14:51 UTC (permalink / raw)
  To: Joern Rennecke; +Cc: binutils

Hi Joern,

>The linker prints out four bytes of garbage as the top half of the size
>of a fill when generating a linker map for i686-pc-linux-gnu X sh-elf .
>This patch fixes it:
>
>2004-05-06  J"orn Rennecke <joern.rennecke@superh.com>
>
>	* ldlang.c (print_padding_statement): Cast size_t to bfd_vma
>	before printing it with %W.
>  
>
Approved - please apply.

Cheers
  Nick

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-07 14:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-05-06 13:57 RFA: fix fill size output in map file for cross-linking Joern Rennecke
2004-05-07 14:51 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).