From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-33495-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 12113 invoked by alias); 7 May 2004 15:19:16 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 12095 invoked from network); 7 May 2004 15:19:15 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sources.redhat.com with SMTP; 7 May 2004 15:19:15 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i47FJE0m024199
	for <binutils@sources.redhat.com>; Fri, 7 May 2004 11:19:14 -0400
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i47FJDv07091;
	Fri, 7 May 2004 11:19:13 -0400
Received: from [172.31.0.98] (vpnuser11.surrey.redhat.com [172.16.9.11])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id i47FJ9Ad026295;
	Fri, 7 May 2004 16:19:10 +0100
Message-ID: <409BA9E3.5010407@redhat.com>
Date: Fri, 07 May 2004 15:19:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 0.6 (X11/20040502)
MIME-Version: 1.0
To: "H. J. Lu" <hjl@lucon.org>
CC: binutils@sources.redhat.com
Subject: Re: PATCH: Fix readelf unwind dump for section group
References: <20040503231536.GB32025@lucon.org>
In-Reply-To: <20040503231536.GB32025@lucon.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-05/txt/msg00170.txt.bz2

Hi H. J.

>2004-05-03  H.J. Lu  <hongjiu.lu@intel.com>
>
>	* readelf.c (section_groups): New.
>	(group_count): New.
>	(section_headers_groups): New.
>	(process_section_groups): Populate group_count, section_groups
>	and section_headers_groups.
>	(process_unwind): Support section group.
>	(process_object): Always call process_section_groups. Free
>	section_groups and section_headers_groups.
>  
>
Approved - please apply.

There is a small typo in one of your comments:

>+      /* Without loaded section headers and section grpups we
>  
>
"grpups" should be "groups".

Cheers
  Nick