From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id 842453870852 for ; Fri, 5 Jan 2024 14:45:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 842453870852 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 842453870852 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::234 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704465925; cv=none; b=ZRzdobYSA1XRryrk65iFUK02oGZOaukuld2u0xKcMvKhO564LorrGTdo4xMkC7shfDwjZgmGqicJowta84tavJyIV6MuiMWwupFIzbjfA4rfVFj9HiUmt+pp12Ijysj3UGQHHBMP1w7SS87wsZj2Tvb4hwnBAsR/aAahpIqMkLg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704465925; c=relaxed/simple; bh=vNCOjw/pE6aahH0MAwUzTmjHA5uWwyqzXG+rmSL7og8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rMSYqJQe2PP7fzCGmvDREgIad4iC28uGL/qs2PNyghyTtw6dFXFQUEM8teGZnTILXvNG/0N4KCKvn2xYCaPEiJU0GgZFtjWIRZx+cNSKpARHOP3x1wUXliXAIuOdQRDqBJ8seDcwTK82zLgB22WHVsNKcoyV1XOLTFr4u2vuP5I= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2ccabf5a4beso19952581fa.2 for ; Fri, 05 Jan 2024 06:45:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704465921; x=1705070721; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VyTWehBahQsaAR98VxWygcLUfhhnLbGJt4F0pwqqB9A=; b=NWnTJ+q8+5LxviUcXJML17PcN5r8+BhHAghqHK8dYRZ/5vzr8plBfJAdVKDnKKrhnF 5OorXlj1qaXB9ZKli6VkSLbbmOWZr9Z1ZVeJgdyCj9nm2b2Kh7IzgH0/dRv/5v98gKkA V2LVEmQAE6x5EN0GJk5n2INpx3IjmnbUycoV87dZ8BKE7RGM+1NbjnHwUnuSiia7IKw9 gT2z5SzXOtFzXFsZPCwusF/tHOtA3/4HuQ8vcuqmAUIkYzEwtcJJv9DBc7+m2nm1TeSL 7EdzoizMnjCJsosSkmIbyQaKx4RlvY3yJ8SoDd7pBX95CSynCyS+aWMe7tnwHZ4Ig63a tCRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704465921; x=1705070721; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VyTWehBahQsaAR98VxWygcLUfhhnLbGJt4F0pwqqB9A=; b=k0CwUEHfynPwh8JgqMxlYm+Y6tvTlcKkbmHssQRhIATAFwJBEFPHYwtTtl1V8elsT4 R7Ims+fXNHEt3l5gn92gFn00t4srWMwx/clRZW3nfBJXt4pi0P5fqjAGPisLvWU8Xi44 FhBBr/DK7Tewlfa+HBWWLcY6d4yrYLF0keDS2izQUxg47osJDLfXsf9/rTDg1ybR1kTW Pp5SSc7JQi78/v5kQD9jQTA2uoOkicct8usMkIwTAWK8CnGbXOZ7c0N/noql8f0qmXX9 ei0WG85c3t/HduyG8cG4XN2HWHR5vaRIQHevJGjqe6n51PgNugerAGM2fFxRVeriwUXt qweg== X-Gm-Message-State: AOJu0YzUVgChJQKopiena6OeqDtlDiCGpcE3n2QoQUSyRXTHB8APnPuC diUbqHCgpur9MZubl90UMRZLgZuWo1HD X-Google-Smtp-Source: AGHT+IHkasbRjFBk9ogq7UcTZ6dbpw4LuJoA3ZXJgX9ERCYI4b7864OmsRu5JEnoxBY7TXScSeKM0g== X-Received: by 2002:a2e:aaa3:0:b0:2cc:6666:168d with SMTP id bj35-20020a2eaaa3000000b002cc6666168dmr524947ljb.69.1704465920956; Fri, 05 Jan 2024 06:45:20 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id 26-20020a5d9c5a000000b007bb778b2840sm444694iof.48.2024.01.05.06.45.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 06:45:20 -0800 (PST) Message-ID: <410d3556-9921-47dc-8eb1-b2a679ff20e5@suse.com> Date: Fri, 5 Jan 2024 15:45:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 1/9] Support APX GPR32 with rex2 prefix Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, binutils@sourceware.org References: <20231228012714.2989658-1-lili.cui@intel.com> <20231228012714.2989658-2-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231228012714.2989658-2-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.12.2023 02:27, Cui, Lili wrote: > @@ -4168,11 +4201,11 @@ static void establish_rex (void) > } > } > > - if (i.rex == 0 && i.rex_encoding) > + if (i.rex == 0 && i.rex2 == 0 && (i.rex_encoding || i.rex2_encoding)) Any reason the indentation of this line was changed (to now be wrong)? > @@ -7015,6 +7080,43 @@ VEX_check_encoding (const insn_template *t) > return 0; > } > > +/* Check if Egprs operands are valid for the instruction. */ > + > +static bool > +check_EgprOperands (const insn_template *t) > +{ > + if (!t->opcode_modifier.noegpr) > + return 0; > + > + for (unsigned int op = 0; op < i.operands; op++) > + { > + if (i.types[op].bitfield.class != Reg) > + continue; > + > + if (i.op[op].regs->reg_flags & RegRex2) > + { > + i.error = register_type_mismatch; > + return 1; > + } > + } > + > + if ((i.index_reg && (i.index_reg->reg_flags & RegRex2)) > + || (i.base_reg && (i.base_reg->reg_flags & RegRex2))) > + { > + i.error = unsupported_EGPR_for_addressing; > + return 1; > + } > + > + /* Check if pseudo prefix {rex2} is valid. */ > + if (i.rex2_encoding) > + { > + i.error = invalid_pseudo_prefix; > + return 1; > + } > + > + return 0; > +} A function with return type "bool" would better return true/false, not 1/0, with "true" representing success / okay / good. Jan