public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: binutils@sourceware.org
Subject: Re: [PATCH] opcodes: Make i386-init.h depend on i386-tbl.h
Date: Thu, 1 Dec 2022 18:08:07 +0100	[thread overview]
Message-ID: <411154b1-3dd3-d4dd-9d58-eb8b80d680fb@suse.com> (raw)
In-Reply-To: <20221201162038.421271-1-hjl.tools@gmail.com>

On 01.12.2022 17:20, H.J. Lu via Binutils wrote:
> i386-gen will generate both i386-tbl.h and i386-init.h in one go.  Since
> both i386-tbl.h and i386-init.h depend on i386-gen, it leads to a race
> condition for i386-gen.

This is not true - the use of a pattern rule was specifically introduced
(not very long ago) to signal to make the creation of multiple files by
a single command / rule. What you describe would happen if this rule
wasn't a pattern one. You are in fact ...

>  Make i386-init.h depend on i386-tbl.h to avoid
> the race condition.

... proposing to re-introduce the original problem (just in the
opposite direction) - see commit 79d635fc64ba.

Jan

  reply	other threads:[~2022-12-01 17:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 16:20 H.J. Lu
2022-12-01 17:08 ` Jan Beulich [this message]
2022-12-01 18:16   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=411154b1-3dd3-d4dd-9d58-eb8b80d680fb@suse.com \
    --to=jbeulich@suse.com \
    --cc=binutils@sourceware.org \
    --cc=hjl.tools@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).