From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by sourceware.org (Postfix) with ESMTPS id 00E493857022 for ; Mon, 12 Sep 2022 09:26:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 00E493857022 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAIirGZGxjKqyRiu76xY2K4Bb0zvkSJQTCNTFxtR2XRJQXE4Z55fnFsPMnidtJi0dtUwXenVHU4IW20Cud/Zxq2vE+cIFfzUpUykostPSMlKz5f3ajgtcCx+RUkSRgnAXivb9bsdbEteyJKhMLI9O9WTM+FjqzsbHMVhPcMvFZo3cSSc1PNmDwB+b0cg5iRvIbrATKtlonC9iR+jYWpdDf6Y+tEDc+YieOy97OP6qiXqr6VRhYVtCgJjHoucuRkCN1Y9cZxYLOTWTILQnzy2KULHUcZxWWOneQjDvj6TXUH3PEzT0E51WGs3OIlz2Hgy5BK4X84iSeJYG1PuKg9T/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mZG2IdjfvxlSodmnkzzHoryeMqKTsf0QryRkKbybZA8=; b=CADM9Hj8oM0HyyzD15bgP/b8RGOBN3FrOV4s65olOAIJeZDTb5NQNkN6Wsrfsut5Ym+LY7y6ZYnffuyEo13LRx34NE8pLiJOzoGQDgk1Lhyw0DHvRelpU/Itd3l/fbBb3MilcXP+6lqLUPBBCMCyiEpukW75TYxUWvm9QcjGc89XwEhDM4PLBHASBsFYa/+JlCj7vkEwDYT3D7PiXlUou7IJ4plDcFIkt/T1NbylLOuf4s3CGfgzuUJhkX0hrXjJTQ1TWr7Pa3cNE94x0y7iZk4NIOt7lQxaJT5Rot/LrAXAGjd+NHIkNqnmZLlpy5zXHCYYyJgIT+Ehe+HkDZfoqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mZG2IdjfvxlSodmnkzzHoryeMqKTsf0QryRkKbybZA8=; b=wvPbhDJzBO6u2T7eLWG7Hc9ROyb32hNhyrrKeO01ktUH3JDM/xIdRsjK+zS2qLdbfQjqc43i5Z+x+Cac6o8PXfye+4ZES8bmL1FL/Tj/hp0VK6jofncD0bwyZct1aaqAkM7sD1yQfEjrxhNqXLCUWxWER/PVmw8aS6hjlDSeWieRP5AutAwAjLUF4gCCWAU8qFX3BUd1QnpxnspvQct5W5raJnazIKMP0Oc6CKTFQHV68zss1BzN7J4ubek7JPXKEVwbkg99mWtJIbWGUen/1RRJUtCtH1Dcx3r+R8aTWCpy8u42k4ZM/5XvVCSgIng30iF7Vh4lECYDxakP8aCjJQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7768.eurprd04.prod.outlook.com (2603:10a6:20b:2a4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.22; Mon, 12 Sep 2022 09:26:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::59bc:901a:98a7:76d4%5]) with mapi id 15.20.5612.022; Mon, 12 Sep 2022 09:26:54 +0000 Message-ID: <4126583a-2eac-9920-bdbb-9bd83dadbb1b@suse.com> Date: Mon, 12 Sep 2022 11:26:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Content-Language: en-US To: Binutils Cc: "H.J. Lu" From: Jan Beulich Subject: [PATCH] x86: correct build dependencies in opcodes/ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AS8PR04MB7768:EE_ X-MS-Office365-Filtering-Correlation-Id: 81fd0892-6da7-44c2-fdb0-08da94a0ee66 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tcfVpCJXhSeS17lC7ZjuGLtLfqYcluPr5QM3aJnwlYZaXVKWDrIYMKspJ6doIe5gOGcNYGdtXkDKgvXRelx15N3KtgG0af1pVt+dHGppVtEPRQ247qVsHfg9jULytLOWRXe3+DfQ2c5JS3nWhQE9BkSTc/Hh+me3tWmiwstM0dAF+EXvUxKUT5VYJtzHsc0/QY+7mXuYF29yGiStMb7fcbbv0M7T11Ump1mP4614RdZ5lKVKwVG1Sw9FCFxQd2igJH+T2LllTgCHKuFj87Vie4d9VfCvptFbpcOk8TBh9ZD2NtrCQqNkltMGeZACOt6k52zwtdqNozaDpwR7JFVBNh70u+fpTlu8RkMknEanngshCwGS4wqj1p6SAa+iVETYYMjQOqauwGRWW8XRTeAej2sKaffTnpwYGcjEzEGgCDdZ2Y0q8S+UzNzQjZoW/uKfeu1OQsLBtwhuuL1cXZ2HjNJvzGaJHnEBbeTT+Vid8j15WKyxr4yVRk/MKCVvUEG19bAGYAHkRYoOuihfdwuyQYX2xhiK1n2LxcpIKVktIUgSo74zyC+GfLRzMpIPPdryVtN0LLbFl/s4C7DnYs0Mvd067TvcLQyR5XBtafHnpACegcTNQjHRQtOhWibknNctvQpRSfKSlMc7xOFzpgfX60z/PngPqxRK6XEKiI1XWqtlp4lHY876oWT4HnTtNSSQ7ORcjppJMnCzh6NxUa14BTnE8jMiOeONcj9qFNSVcJvUOfptuisKOq2MBO5U258QGIH0Et8Q2LCxrl84QZ4AhFKxnCfkuSEszOVUFaPrcpQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(136003)(39860400002)(376002)(346002)(2616005)(186003)(38100700002)(8936002)(36756003)(316002)(31686004)(66476007)(66556008)(2906002)(5660300002)(6916009)(4326008)(8676002)(66946007)(26005)(86362001)(6486002)(6506007)(478600001)(6512007)(31696002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yi9wOC9sbzVTc21tblpzYXRDWVZoTXljWkpHY1pDRWF1TVZEMGN3eHJoY3pl?= =?utf-8?B?aUhuNkN0T2VYYlBDaTJSNGVKdmlGY3lSbU1aY0tvWVpxdHVNM1ZqU1VlUzUv?= =?utf-8?B?TkQ4VmlXeUp1VnV3cHd0ZXBVcTVSK3hMZlU2THVTRnJzTDhPeWpKeWtSZmVQ?= =?utf-8?B?eWVObHVNb1k3RlZ6UnRPa25tN3JaenZnZHhEaUYxYkMxc25DVlVDUlJDQW5s?= =?utf-8?B?VGpEdFdBbE5SVUFvS3cxZHEzSURaYjR5NU40SDdNcXVubG41eGVmbEo2NFpa?= =?utf-8?B?WHNYVU5vVVBzSHJkMkwwaHFwYVVrcGo0UkRMWmVyN2huckVTcjNvYnZFaksz?= =?utf-8?B?VGNoWXJ2azFiUUVRdDFmRE4rcXV4QlA1REs3SWN2c1NqTThkNThKWFZaT2RB?= =?utf-8?B?WWhmUnZJMUlSNEtCbDlGMndOS201OWNZU1pmRmpUR1FIbWlTNGJkbkVxRmFk?= =?utf-8?B?TTJPbjI3R0hDUFVOQUszd0pOS2Fpd1pwZFoxcmFWeUNrcmkweEowUmNrUUZU?= =?utf-8?B?RXU5Y014YVVEallTMmN4a1ZqK1dnNDZsV3oyQU90WkdtR1J4ZWNHK1hWY0dj?= =?utf-8?B?NDBKMi9pN1poRlFWcXVjdEJlOUtUUGFRTzFPcHFFVDMrVDRWa3Azc2lzT051?= =?utf-8?B?M2JHUnMyZlhrSFEweWhGN0pCcmovcHdpQkNyTEZJWmp6dEZxRURKeWpwUXdM?= =?utf-8?B?Q2szTnRsVVkyQTFtZHVEQkxBMmlKd0tzREtJSjdQRGdQcytrT2ZqWHBLenZz?= =?utf-8?B?MFBqSFhVV3dZc3FyR3dMY1RqVmRGa1NhK3lCYnpiaVNaV3o5TjBHeFNWbDFM?= =?utf-8?B?TnNyZ28wcWgxTEkybGg5bVNSQk91aDdGWWt6UkszTXJFaEN3ZUhKZlZlbFZz?= =?utf-8?B?M0dnTjU4QUNTTG1oaHJKTmVBbjVJeldWVmFCUnJGL1RNN25UQXlNekZxNzNa?= =?utf-8?B?THgvZHpBUzQ0T3ZQaGQrZEdvM0dHN2kwZEs4SHlmTlAwZnFWSG9wY3JCcnc5?= =?utf-8?B?SW16WWN4Vi8wRUkrWUN5SDJOZ1dxcFgwLy9sVnJ2U3BBbFlmVTdyUnE3cCsw?= =?utf-8?B?aTRRaDlDTThmK2lKb3VCMFlQSUwxUUJZWmhnUUhoVHhQQlJCTUg4ekZrNTEv?= =?utf-8?B?clJUeWhVQ21uckE1ZDQ4RmlXT3NxSUUrQ0JZZUpwS21JdTRab0dFSkdtQk9O?= =?utf-8?B?UmhSZTgvVW0rOXRSZldNWUpsVmNYcDBma3N1a3RzSEN2Z1NWZGU3SFR3WVV2?= =?utf-8?B?eGhWc0UrVTE5eW50YXhzcHhYMlZCK3g2M3A0QjhuMXBENFNONmhLbWlRK3Ur?= =?utf-8?B?YUVZUm55dEdCYUtxV0h4Qlo5blNtcnNVM3dJTFI4b3YvQjdkdU5rNEFzZVp5?= =?utf-8?B?bU9yQlJORmhpVlRnbURuTDZiZDZ6c1I1ZVVibWg4cUQvamtPanI5WEZWdHdO?= =?utf-8?B?MTB0MDJ3TFBNc2NFNDh3ZGZUT24rcUliclRUMXN1Tkx1cHdvUW9YNmRCSXM4?= =?utf-8?B?ZUpudm1NcmxJRGs3WUtFaTNTNWsvdytzRExOWXVvWDFQcXBQM3M3VDA4LzRu?= =?utf-8?B?ZS9jWkpCNEdDSjlMUndMM29Fa2tHOGlaTE42eU9xTnIwaUZJcXI4ekxJSDl2?= =?utf-8?B?UzJ5M1VDd2dsV0daMlgxYjZ1N3BjeXRjdmEzaFJwMTJ1UXZsQ3N6TVI0Z2FT?= =?utf-8?B?clJkelE3U01CaFEwcFp3QWp3SEVHdmZhaU0zU0ZwcVRhUnI0bWtBbzBUTHhW?= =?utf-8?B?cmx6eWJoOXBSSHVscGZHYlUzZUw0dEJCM0I2MXFUZnpxMXJZTWZQUUdOMzVu?= =?utf-8?B?bXVtcE9KMkk0a3pJc2k5enQyQ21BU0lSRnd3RjJabzZ3ZkNZaVdTM2ZXS3Uy?= =?utf-8?B?R01NSUd3S0ZrVkI2bEV5Qll1S3Z0TU85cXFtYmNPS25Ba3ZLUGNwWFQ2ekgx?= =?utf-8?B?M0NRMzhXbStGeSszdUNiUDg2dHNpVUMvNmJVdTJhamRKVnB4VE1EM0xpRzFJ?= =?utf-8?B?OVppZEIvVjEza3lYVGpEZmN3OW1tbWxxSmx5aU9SdHViUHJLbHdZeEIvMXE0?= =?utf-8?B?NUwvS2dWZUVqZ1J2THI5ZE96WHltTnBFZmxpOFZFWmNXOHZ5MEc0aWdndWNR?= =?utf-8?Q?fy/kBHQGh5/sYZ8jxSMbjpNv6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81fd0892-6da7-44c2-fdb0-08da94a0ee66 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2022 09:26:54.2689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Iis4JmCHMtbceRsfpfp+oj2m94KbwhcNBpWQ1yLv3yKcCBJ/UTUiMsapZ1F6aFJhEhnmnfyDqsJSCR0klTkXow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7768 X-Spam-Status: No, score=-3030.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: With the command in the rule merely being "echo", i386-tbl.h won't be rebuilt if missing, when at the same time i386-init.h is present and up-to-date. Use a pattern rule instead to express the multiple targets correctly (the &: rule separator is supported only by GNU make 4.3 and newer). Note that now, for the opposite case to work (i386-tbl.h is up-to-date but i386-init.h is missing), i386-init.h also needs mentioning as a dependency somewhere: Add a fake dependency for i386-opc.lo ("fake" because i386-opc.c doesn't include that header). At the same time use $(AM_V_GEN) in the actual rule, replacing the earlier (open-coded) "echo". And while there also drop a duplicate dependency of i386-gen.o on i386-opc.h. --- a/opcodes/Makefile.am +++ b/opcodes/Makefile.am @@ -552,18 +552,20 @@ i386-gen$(EXEEXT_FOR_BUILD): i386-gen.o i386-gen.o: i386-gen.c i386-opc.h $(srcdir)/../include/opcode/i386.h \ $(INCDIR)/ansidecl.h $(INCDIR)/getopt.h $(INCDIR)/hashtab.h \ $(INCDIR)/libiberty.h $(INCDIR)/opcode/i386.h $(INCDIR)/safe-ctype.h \ - config.h i386-opc.h sysdep.h + config.h sysdep.h $(COMPILE_FOR_BUILD) -c $(srcdir)/i386-gen.c -$(srcdir)/i386-tbl.h: $(srcdir)/i386-init.h - @echo $@ - -$(srcdir)/i386-init.h: @MAINT@ i386-gen$(EXEEXT_FOR_BUILD) i386-opc.tbl i386-reg.tbl i386-opc.h - $(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) - \ +# i386-gen will generate both headers in one go. Use a pattern rule to properly +# express this, with the inner dash ('-') arbitrarily chosen to be the stem. +$(srcdir)/i386%tbl.h $(srcdir)/i386%init.h: @MAINT@ i386-gen$(EXEEXT_FOR_BUILD) i386-opc.tbl i386-reg.tbl i386-opc.h + $(AM_V_GEN)$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) - \ < $(srcdir)/i386-opc.tbl \ | ./i386-gen$(EXEEXT_FOR_BUILD) --srcdir $(srcdir) i386-opc.lo: $(srcdir)/i386-tbl.h +# While not really a dependency, specify i386-init.h here as well to make sure +# it is generated even if i386-tbl.h is present and up-to-date. +i386-opc.lo: $(srcdir)/i386-init.h ia64-gen$(EXEEXT_FOR_BUILD): ia64-gen.o $(BUILD_LIB_DEPS) $(AM_V_CCLD)$(LINK_FOR_BUILD) ia64-gen.o $(BUILD_LIBS) --- a/opcodes/Makefile.in +++ b/opcodes/Makefile.in @@ -1527,18 +1527,20 @@ i386-gen$(EXEEXT_FOR_BUILD): i386-gen.o i386-gen.o: i386-gen.c i386-opc.h $(srcdir)/../include/opcode/i386.h \ $(INCDIR)/ansidecl.h $(INCDIR)/getopt.h $(INCDIR)/hashtab.h \ $(INCDIR)/libiberty.h $(INCDIR)/opcode/i386.h $(INCDIR)/safe-ctype.h \ - config.h i386-opc.h sysdep.h + config.h sysdep.h $(COMPILE_FOR_BUILD) -c $(srcdir)/i386-gen.c -$(srcdir)/i386-tbl.h: $(srcdir)/i386-init.h - @echo $@ - -$(srcdir)/i386-init.h: @MAINT@ i386-gen$(EXEEXT_FOR_BUILD) i386-opc.tbl i386-reg.tbl i386-opc.h - $(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) - \ +# i386-gen will generate both headers in one go. Use a pattern rule to properly +# express this, with the inner dash ('-') arbitrarily chosen to be the stem. +$(srcdir)/i386%tbl.h $(srcdir)/i386%init.h: @MAINT@ i386-gen$(EXEEXT_FOR_BUILD) i386-opc.tbl i386-reg.tbl i386-opc.h + $(AM_V_GEN)$(CPP) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(AM_CPPFLAGS) $(CPPFLAGS) - \ < $(srcdir)/i386-opc.tbl \ | ./i386-gen$(EXEEXT_FOR_BUILD) --srcdir $(srcdir) i386-opc.lo: $(srcdir)/i386-tbl.h +# While not really a dependency, specify i386-init.h here as well to make sure +# it is generated even if i386-tbl.h is present and up-to-date. +i386-opc.lo: $(srcdir)/i386-init.h ia64-gen$(EXEEXT_FOR_BUILD): ia64-gen.o $(BUILD_LIB_DEPS) $(AM_V_CCLD)$(LINK_FOR_BUILD) ia64-gen.o $(BUILD_LIBS)