From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id D3E583851C1C for ; Fri, 2 Jul 2021 18:08:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3E583851C1C Received: by mail-pl1-x62f.google.com with SMTP id l19so775061plg.6 for ; Fri, 02 Jul 2021 11:08:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=rMpNIOMNAesjTZbb49Dp6Fouko6qt04x5KlD9g1G39E=; b=estkNB7ztNG4hNer/YUojuGztdjwFPPgjqrWlKFsLdZTeq5oZYphs39DPBC12+yQ0p 5iNNKbWCdlciiTfyrb1euR1kHq9GWdqUsTgNDG4yjrS0LFm9wElHq/Appo/tYaK4Mw+u 0vKfuedTrt9/ddFwGJqHeDSCrwBW7g5RvnT52xNvUmG7XlsK8lglAv3J3xU0dRTsmjFx jaNzDzgKoXK1fDjvaUeAa+b/LaDO7MfmMg+sRgQcn/j3K9eUAe6sUZf6OGOFpg4QRFwJ JKfhBW23R+Dah3dGXtIqKbvtqZ+g74PjPgDgzZtiyh2PLTYOEfO4g5fmor53Xx42iC1E 4V6g== X-Gm-Message-State: AOAM531bJXLFEzIB5Q0Hsc01efPyDEjjhsilnVYbCFAq3//4CsP/+AhA vlmuhtPuwJwqJlReZev1JOMG5248b//B1Q== X-Google-Smtp-Source: ABdhPJz6h4jOvCwxXdjAi1InebXwcE5QjePxsroUE1nWyu3BhZKtGoxB6BGKvZoPOtvtbkS91UXnqA== X-Received: by 2002:a17:90a:3d0d:: with SMTP id h13mr990721pjc.20.1625249308815; Fri, 02 Jul 2021 11:08:28 -0700 (PDT) Received: from [192.168.1.35] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id a130sm4571498pfa.90.2021.07.02.11.08.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 11:08:28 -0700 (PDT) Subject: Re: Fix minor NDS32 renaming snafu To: Alan Modra , binutils@sourceware.org References: From: Jeff Law Message-ID: <412af712-5dac-5de6-af31-c30690351970@gmail.com> Date: Fri, 2 Jul 2021 12:08:25 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: binutils@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Binutils mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 18:08:31 -0000 On 7/2/2021 5:21 AM, Alan Modra via Binutils wrote: > Some extern declarations differ in constness to their definitions too. > Let's make sure this sort of thing doesn't happen again, but putting > the externs in a header where they belong. > > gas/ > * config/tc-nds32.c (nds32_keyword_gpr): Don't declare. > (md_begin): Constify k. > opcodes/ > * nds32-dis.c (nds32_find_reg_keyword): Constify arg and return. > (nds32_parse_audio_ext, nds32_parse_opcode): Constify psys_reg. > (nds32_field_table, nds32_opcode_table, nds32_keyword_table), > (nds32_opcodes, nds32_operand_fields, nds32_keywords), > (nds32_keyword_gpr): Move declarations to.. > * nds32-asm.h: ..here, constifying to match definitions. Thanks.  Both nds targets in my tester started failing yesterday, but I hadn't dug into why yet.  I bet you've fixed it. Jeff