MinGW PECOFF dlltool: Revert internal_name patches.

MinGW PECOFF dlltool: Revert internal_name patches.

[Aaron W. LaFramboise]

Discussion on the mingw-users@sourceforge.net list has come to a general
consensus that these three patches caused incorrect semantics and should
be reverted:

2004-09-06  Danny Smith  <dannysmith@users.sourceforge.net>

        * doc/binutils.texi (dlltool): Update --add-underscore, --kill-at
        documentation.

2004-09-04  Danny Smith  <dannysmith@users.sourceforge.net>

        * dlltool.c (make_one_lib_file): Test if internal_name was
        specified by user before using it.

2004-09-02  Carlo Wood  <carlo@alinoe.com>

        PR binutils/351
        * dlltool.c (make_one_lib_file): For IDATA6 take the name from
        exp->internal_name if it is present.

See this thread: "Re: DEF file internalname example"
<http://sourceforge.net/mailarchive/message.php?msg_id=9470769>.

PR binutils/351 is, in fact, not a bug.

There is a valid problem that needs to be addressed though, relating to
importing symbols from MSVC-created DLLs that contain both stdcall and
cdecl exports.  Carlo Wood and I agreed the best prospective way to fix
this is by adding a command line option that causes binutils to do the
same sort of stdcall name translation that MS LINK does.

Aaron W. LaFramboise

Re: MinGW PECOFF dlltool: Revert internal_name patches.

[Nick Clifton]

Hi Aaron,

> Discussion on the mingw-users@sourceforge.net list has come to a general
> consensus that these three patches caused incorrect semantics and should
> be reverted:
> 
> 2004-09-06  Danny Smith  <dannysmith@users.sourceforge.net>
> 
>         * doc/binutils.texi (dlltool): Update --add-underscore, --kill-at
>         documentation.
> 
> 2004-09-04  Danny Smith  <dannysmith@users.sourceforge.net>
> 
>         * dlltool.c (make_one_lib_file): Test if internal_name was
>         specified by user before using it.
> 
> 2004-09-02  Carlo Wood  <carlo@alinoe.com>
> 
>         PR binutils/351
>         * dlltool.c (make_one_lib_file): For IDATA6 take the name from
>         exp->internal_name if it is present.

Ok - I have now applied your patch to do this:

> 2004-10-08  Aaron W. LaFramboise  <aaron98wiridge9@aaronwl.com>
> 
> 	* dlltool.c (make_one_lib_file): Revert 2004-09-02 and 2004-09-04
> 	patches.
> 	* doc/binutils.texi (dlltool): Revert 2004-09-06 patch.
> 

Cheers
   Nick