public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gas: Fix comment on definition of frag_grow()
@ 2020-05-28 10:26 Alex Coplan
  2020-05-28 13:31 ` Nick Clifton
  0 siblings, 1 reply; 2+ messages in thread
From: Alex Coplan @ 2020-05-28 10:26 UTC (permalink / raw)
  To: binutils

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

Hello,

The attached patch fixes two obvious typos and updates the comment
describing frag_grow() to better reflect what the function actually
does. The previous wording implied that the function may never return.

I don't have commit access so a maintainer will need to commit on my
behalf.

Thanks,
Alex

---

gas/ChangeLog

2020-05-28  Alex Coplan  <alex.coplan@arm.com>

	* frags.c (frag_grow): Fix comment.

[-- Attachment #2: patch.diff --]
[-- Type: text/x-diff, Size: 657 bytes --]

diff --git a/gas/frags.c b/gas/frags.c
index 12cbe6c671..4fe98dd511 100644
--- a/gas/frags.c
+++ b/gas/frags.c
@@ -89,9 +89,9 @@ frag_alloc (struct obstack *ob)
 }
 \f
 /* Try to augment current frag by nchars chars.
-   If there is no room, close of the current frag with a ".fill 0"
-   and begin a new frag. Unless the new frag has nchars chars available
-   do not return. Do not set up any fields of *now_frag.  */
+   If there is no room, close off the current frag with a ".fill 0"
+   and begin a new frag. Until the new frag has nchars chars available
+   do not return. Do not set up any fields of *frag_now.  */
 
 void
 frag_grow (size_t nchars)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gas: Fix comment on definition of frag_grow()
  2020-05-28 10:26 [PATCH] gas: Fix comment on definition of frag_grow() Alex Coplan
@ 2020-05-28 13:31 ` Nick Clifton
  0 siblings, 0 replies; 2+ messages in thread
From: Nick Clifton @ 2020-05-28 13:31 UTC (permalink / raw)
  To: Alex Coplan, binutils

Hi Alex,

> 2020-05-28  Alex Coplan  <alex.coplan@arm.com>
> 
> 	* frags.c (frag_grow): Fix comment.

Approved and applied.  With just a little tweaking of the text...:-)

Cheers
  Nick



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-28 13:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 10:26 [PATCH] gas: Fix comment on definition of frag_grow() Alex Coplan
2020-05-28 13:31 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).