[PATCH] Coldfire 5249 gas bug

[PATCH] Coldfire 5249 gas bug

[Linus Nielsen Feltzing]

Hi all!

Using the latest CVS version of binutils, assembling the following 
instruction fails on the mcf5249 target:

         move.l %acc1,%d0

m68k-elf-as fails with the following message:

Assembler messages:
Internal error, aborting at ../../binutils-040922/gas/config/tc-m68k.c 
line 4357 in select_control_regs
Please report this bug.

select_control_regs() is missing a case for the mcf5249 target. Here's 
the patch to cure it:

Index: gas/config/tc-m68k.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-m68k.c,v
retrieving revision 1.57
diff -u -r1.57 tc-m68k.c
--- gas/config/tc-m68k.c        17 Aug 2004 12:19:57 -0000      1.57
+++ gas/config/tc-m68k.c        23 Sep 2004 05:52:04 -0000
@@ -4341,6 +4341,7 @@
        break;
      case mcf5200:
      case mcf5206e:
+    case mcf5249:
      case mcf5307:
      case mcf5407:
        control_regs = mcf_control_regs;


Have fun,

Linus Nielsen Feltzing

Re: [PATCH] Coldfire 5249 gas bug

[Nick Clifton]

Hi Linus,

> Using the latest CVS version of binutils, assembling the following 
> instruction fails on the mcf5249 target:
> 
>         move.l %acc1,%d0
> 
> m68k-elf-as fails with the following message:
> 
> Assembler messages:
> Internal error, aborting at ../../binutils-040922/gas/config/tc-m68k.c 

Thanks very much for reporting this bug and supplying a patch to fix it.

I have applied your patch along with this ChangeLog entry:

gas/ChangeLog
2004-09-30  Linus Nielsen Feltzing  <linus@haxx.se>

	* config/tc-m68k.c (select_control_regs): Add mcf5249.

Cheers
   Nick