From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id AE0B13857B93 for ; Fri, 5 Jan 2024 14:36:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE0B13857B93 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE0B13857B93 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704465370; cv=none; b=GYza7icmx9TuVX0321JgBLM1FyC+XvVygRI6E3965UiNbfHLgGEvRDnqfAjC0QD0vk0OLazuWJbWJfZ3YySYhrLkvAYE9y+Pjvi5A/AWFMh2p04R2is9OUzlrUQgFVFt5lRN89tr942eFJiUAq2DRx/+8Dkto8q/yvumsBJ+LV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704465370; c=relaxed/simple; bh=qPuewYW/klcNBZVLRmnPKyDO2gieFkIa5LSmfBevQ98=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=fV3XQ00QWMACVgi2uiVVZx0vj+2L65BkbhKUKFSqfF867VPU5jvjXqMNIWi064AWxvBuNLjHwnCRMxYsdUZyARca3pyU7HOX1gr7ttFVUBxhFUaSOVIELJRzWCpbd1to4hM83WWFQCPwwq/kc7zRG/9/1hBNl5LQ7uzQsLigu5g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-a28ee72913aso114376966b.1 for ; Fri, 05 Jan 2024 06:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1704465366; x=1705070166; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5rfFPTUHlzNoCI91LGgorunPUxBmIcOJHMaqQcXO3iI=; b=XP590YObOLGCj5Y12BS+K6CyO+uh6GqqczSdMxwrjR94L6nsk1CMCnaMTqc5Jpnsw8 NIqaNX0FIqKz9xZC0azgiRScXcGuyawoVjUzDQYKjDHIEoz6xJD3THh1Amiuj9OGOwC0 UQH18XYEG96sPHgAe2/Tg6K+CbnHQ602xozSZ6JFUzqvtzGuj2gA5ul6/Psi1hXhcfyf dP6fmVGY0NwZdFlkCzNwIvcg8f5X6gbarB4t+8f1jIsHJpN51IhgmNIQKKIoMhmDZeNt pG+KajttzT24DwXuHNfLBHgnvOpgOf0RJettOKb8HDG+h8kkXxrAG0X1eGeHOiLp4R+u ZYww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704465366; x=1705070166; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5rfFPTUHlzNoCI91LGgorunPUxBmIcOJHMaqQcXO3iI=; b=VekNPE5g7uauwpuOX7Ku1d875PLt0JP9MeQ7ISGLNIm8XaugFvpQqTDvTwBqg1ihKu tRHhmT7SyeGScEZF+F4DYL0KxK4Fzil/9uTcutWPJb8PEdMRmib1sSLzBO3GwRScJ3Qu ZIfBuImgIxCwhx0byA9GBN86T/WAf7SZMeF0QGi5tD81Gg247CzkYnCDbX4ehTbD4Kpp 9jFx1zc+KJ2hM9/gmZkTrCkCmjzw2ToJm6qs2eoCKVvTLJsIjB+q1M8htTwZt38uAzVR SkmUQ8x3BBcW1BKzCBv2dtFTe70NyhQdVahn71pgwfexUNX6s37TbCLNz+xO+UK8DIZv g6BQ== X-Gm-Message-State: AOJu0YwFmaNi3UpEbUDtuRWEcjJgZaxsr65s8EFPSgd3U+NDW87hV/Qe fRgrE1uN7tubftCUmwc6tBwm3FLRtKIR X-Google-Smtp-Source: AGHT+IEew5TVwBNnpyRhkNiNEnaEXZ+scaRergqx91LlLVECyswSpqgVM6llVlShnrzQpuiJoJwzDw== X-Received: by 2002:a17:907:9704:b0:a28:e1a4:ae46 with SMTP id jg4-20020a170907970400b00a28e1a4ae46mr2711039ejc.13.1704465366330; Fri, 05 Jan 2024 06:36:06 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id bi5-20020a05663819c500b0046df8c8f7basm435875jab.23.2024.01.05.06.36.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jan 2024 06:36:05 -0800 (PST) Message-ID: <416c0efb-8cc0-4f5b-9bbe-177a21226a77@suse.com> Date: Fri, 5 Jan 2024 15:36:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V5 8/9] Support APX NDD optimized encoding. Content-Language: en-US To: "Cui, Lili" Cc: hongjiu.lu@intel.com, "Hu, Lin1" , binutils@sourceware.org References: <20231228012714.2989658-1-lili.cui@intel.com> <20231228012714.2989658-9-lili.cui@intel.com> From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20231228012714.2989658-9-lili.cui@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3026.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 28.12.2023 02:27, Cui, Lili wrote: > @@ -7754,6 +7804,60 @@ match_template (char mnem_suffix) > i.memshift = memshift; > } > > + /* If we can optimize a NDD insn to legacy insn, like > + add %r16, %r8, %r8 -> add %r16, %r8, > + add %r8, %r16, %r8 -> add %r16, %r8, then rematch template. > + Note that the semantics have not been changed. */ > + if (optimize > + && !i.no_optimize > + && i.vec_encoding != vex_encoding_evex > + && t + 1 < current_templates.end > + && !t[1].opcode_modifier.evex > + && t[1].opcode_space <= SPACE_0F38 > + && t->opcode_modifier.vexvvvv == VexVVVV_DST > + && (i.types[i.operands - 1].bitfield.dword > + || i.types[i.operands - 1].bitfield.qword)) While you check the last operand's type here, ... > + { > + unsigned int match_dest_op = can_convert_NDD_to_legacy (t); > + > + if (match_dest_op != (unsigned int) ~0) > + { > + size_match = true; > + /* We ensure that the next template has the same input > + operands as the original matching template by the first > + opernd (ATT). To avoid someone support new NDD insns and > + put it in the wrong position. */ > + overlap0 = operand_type_and (i.types[0], > + t[1].operand_types[0]); > + if (t->opcode_modifier.d) > + overlap1 = operand_type_and (i.types[0], > + t[1].operand_types[1]); > + if (!operand_type_match (overlap0, i.types[0]) > + && (!t->opcode_modifier.d > + || !operand_type_match (overlap1, i.types[0]))) > + size_match = false; .. why is it the first one's here? That may be a memory operand, which in AT&T mode cannot possibly have a size. Jan