public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: Andrew STUBBS <andrew.stubbs@st.com>, binutils@sources.redhat.com
Subject: Re: Broken SH2a patches
Date: Fri, 29 Oct 2004 10:39:00 -0000	[thread overview]
Message-ID: <41821F69.4020604@redhat.com> (raw)
In-Reply-To: <oroeim37nq.fsf@livre.redhat.lsd.ic.unicamp.br>

Hi Alex,  Hi Andrew,

>>Hi Alexandre,
>>A (long) while back you send this message:
>>http://sources.redhat.com/ml/binutils/2004-07/msg00439.html
>>Have you made any progress with this problem yet?

> Erhm...  Sort of.  I got Nick to promise to look into the issues, and
> then didn't worry about them any more.

Err, you did ?  It must have been while I was drunk...

> Nick, I take it that you didn't make any progress on them?

That would be correct.

Anyway as I understand it the problem is that the inheritance tree in 
sh-opc.h does not include the SH2A, right ?  Judging from Alex's and 
Andrew's comments there are two possible fixes for this, a simple one 
that just adds the SH2A-nofpu and SH2A inheritance off the SH2E:
-----------------------------------------------------------------------
/* Below are the 'architecture sets'.
    They describe the following inheritance graph:

                  SH1
                  |
                 SH2
    .------------'|`--------------------.
   /              |                      \
SH-DSP          SH3-nommu               SH2E
  |               |`--------.             |`--------.
  |               |          \            |          \
  |              SH3     SH4-nommu-nofpu  |          |
  |               |           |           |          |
  | .------------'|`----------+---------. |          |
  |/                         /           \|          |
  |               | .-------'             |          |
  |               |/                      |          |
SH3-dsp         SH4-nofpu               SH3E    SH2A-nofpu
  |               |`--------------------. |          |
  |               |                      \|          |
  |              SH4A-nofpu              SH4        SH2A
  | .------------' `--------------------. |
  |/                                     \|
SH4AL-dsp                               SH4A
-------------------------------------------------------------------------
And a complex one that invents a fake intermediate architecture to show 
the fact that the SH4, SH4A and SH2A share some instructions.  To my 
mind however there is no satisfactory way of showing this, and instead I 
would like to suggest using a dotted line to show partial inheritance:
-------------------------------------------------------------------------
/* Below are the 'architecture sets'.
    They describe the following inheritance graph:
   (The .... between SH4A and SH2A-nofpu is a partial inheritance).

                 SH1
                  |
                 SH2
    .------------'|`--------------------.
   /              |                      \
SH-DSP          SH3-nommu               SH2E
  |               |`--------.             |`------.
  |               |          \            |        \
  |              SH3     SH4-nommu-nofpu  |         |
  |               |           |           |         |
  | .------------'|`----------+---------. |         |
  |/                         /           \|         |
  |               | .-------'             |         |
  |               |/                      |         |
SH3-dsp         SH4-nofpu               SH3E       |
  |               |`--------------------. |         |
  |               |                      \|         |
  |              SH4A-nofpu              SH4        |
  | .------------' `--------------------. |         |
  |/                                     \|         |
SH4AL-dsp                               SH4A       |
                                          .         |
					 ......... |
					         . |
					         SH2A-no-fpu
                                                    |
                                                  SH2A
-----------------------------------------------------------------------

What do you think ?

Cheers
   Nick

  reply	other threads:[~2004-10-29 10:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-13 17:00 Andrew STUBBS
2004-10-28 20:33 ` Alexandre Oliva
2004-10-29 10:39   ` Nick Clifton [this message]
2004-10-29 12:11     ` Andrew STUBBS
2004-10-29 12:28       ` [OT] " Dave Korn
2004-10-29 12:59         ` Andrew STUBBS
2004-10-29 13:03           ` Dave Korn
2004-10-29 13:21             ` Andrew STUBBS
2004-10-29 13:59       ` Ian Lance Taylor
2004-10-29 14:35         ` Andrew STUBBS
2004-10-29 14:58           ` Ian Lance Taylor
2004-10-29 15:44             ` Andrew STUBBS
2004-11-08  9:04       ` Nick Clifton
2004-11-08 15:12         ` Andrew STUBBS
2004-11-08 16:27           ` Joern RENNECKE
2004-11-08 16:36           ` Joern RENNECKE
2004-12-15 17:11           ` Nick Clifton
2004-12-16 13:24             ` Andrew STUBBS
2004-12-20 17:18               ` Nick Clifton
2005-01-05 13:27                 ` Andrew STUBBS
2005-01-06 11:28                 ` Andrew STUBBS
2005-01-12 16:23                   ` Nick Clifton
2005-01-07 12:55                 ` Andrew STUBBS
2005-01-10 13:31                   ` Joern RENNECKE
2005-01-11 18:01                 ` Andrew STUBBS
2004-12-02 12:19 Andrew STUBBS

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41821F69.4020604@redhat.com \
    --to=nickc@redhat.com \
    --cc=andrew.stubbs@st.com \
    --cc=aoliva@redhat.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).