From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16198 invoked by alias); 3 Nov 2004 15:26:53 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 16176 invoked from network); 3 Nov 2004 15:26:52 -0000 Received: from unknown (HELO relay3.mail.uk.clara.net) (80.168.70.143) by sourceware.org with SMTP; 3 Nov 2004 15:26:52 -0000 Received: from adsl-2-solo-173-195.claranet.co.uk ([80.168.173.195] helo=[172.31.0.98]) by relay3.mail.uk.clara.net with esmtp (Exim 4.34) id 1CPN24-000LSX-Er; Wed, 03 Nov 2004 15:26:44 +0000 Message-ID: <4188F96A.1020409@redhat.com> Date: Wed, 03 Nov 2004 15:26:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040803) MIME-Version: 1.0 To: Hans-Peter Nilsson CC: raeburn@raeburn.org, binutils@sources.redhat.com Subject: Re: RFC: gas .warning "msg" and .error "msg" directives? References: <200411031418.iA3EIHdK010398@ignucius.se.axis.com> In-Reply-To: <200411031418.iA3EIHdK010398@ignucius.se.axis.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00055.txt.bz2 Hi Hans-Peter, >>Why not make it default to something that actually describes the >>situation, e.g., ".error directive invoked in source file". >>Conceptually, you could also make the message be required -- for .error >>that just means you print a slightly different message if it's omitted >>("missing .error parameter" for example), the practical difference is >>whether .warning without a message would be an error or not. :-) > > > All valid points. Consider them merged with my suggestion, with: > An .error without a string should be compatible with ".err" and > just emit ".error directive invoked in source file". A .warning > should just warn, with the default message being...you guessed > it ".warning directive invoked in source file". Ok - if you would care to post a patch like that, along with a case or two for the testsuite then I would be happy to review it. Cheers Nick