RE: [PATCH] Maxq port

public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed

* RE: [PATCH] Maxq port
@ 2004-11-16 14:55 Inderpreet Singh Baweja
  2004-11-18 16:22 ` Nick Clifton
  0 siblings, 1 reply; 4+ messages in thread
From: Inderpreet Singh Baweja @ 2004-11-16 14:55 UTC (permalink / raw)
  To: Nick Clifton; +Cc: binutils, inderpreetb, config-patches

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]

 
Hi Nick,

There is no problem with the patch.
It is working fine on my system.

                === gas Summary ===
# of expected passes            46
../as-new 20041116


                === binutils Summary ===

# of expected passes            21
# of untested testcases         6



NOTE: It may be because while configuring u require
'--enable-bfd-assembler' option.

I am sending both the config.sub patch and the testsuite patch.
Change log basically remains the same.

Thanks,
Inder



> -----Original Message-----
> From: binutils-owner@sources.redhat.com 
> [mailto:binutils-owner@sources.redhat.com] On Behalf Of 
> Inderpreet Singh Baweja
> Sent: Tuesday, November 09, 2004 9:32 PM
> To: Nick Clifton
> Cc: binutils@sources.redhat.com
> Subject: RE: [PATCH] Maxq port
> 
>  
> Hi Nick,
> 
> Thanks for accepting the patch.
> I have update the patch for the maxq port. 
> Can u please apply this to the mainline.
> 
> Thanks,
> Inderpreet
> 

[-- Attachment #2: maxq_config_patch1 --]
[-- Type: application/octet-stream, Size: 1763 bytes --]

Index: config.sub
===================================================================
RCS file: /cvs/src/src/config.sub,v
retrieving revision 1.49
diff -c -3 -p -r1.49 config.sub
*** config.sub	16 Nov 2004 01:18:39 -0000	1.49
--- config.sub	16 Nov 2004 14:27:58 -0000
*************** case $basic_machine in
*** 237,243 ****
  	| h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
  	| i370 | i860 | i960 | ia64 \
  	| ip2k | iq2000 \
! 	| m32r | m32rle | m68000 | m68k | m88k | mcore \
  	| mips | mipsbe | mipseb | mipsel | mipsle \
  	| mips16 \
  	| mips64 | mips64el \
--- 237,243 ----
  	| h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
  	| i370 | i860 | i960 | ia64 \
  	| ip2k | iq2000 \
! 	| m32r | m32rle | m68000 | m68k | m88k | maxq | mcore \
  	| mips | mipsbe | mipseb | mipsel | mipsle \
  	| mips16 \
  	| mips64 | mips64el \
*************** case $basic_machine in
*** 311,317 ****
  	| m32r-* | m32rle-* \
  	| m68000-* | m680[012346]0-* | m68360-* | m683?2-* | m68k-* \
  	| m88110-* | m88k-* | mcore-* \
! 	| mips-* | mipsbe-* | mipseb-* | mipsel-* | mipsle-* \
  	| mips16-* \
  	| mips64-* | mips64el-* \
  	| mips64vr-* | mips64vrel-* \
--- 311,317 ----
  	| m32r-* | m32rle-* \
  	| m68000-* | m680[012346]0-* | m68360-* | m683?2-* | m68k-* \
  	| m88110-* | m88k-* | mcore-* \
! 	| maxq-* | mips-* | mipsbe-* | mipseb-* | mipsel-* | mipsle-* \
  	| mips16-* \
  	| mips64-* | mips64el-* \
  	| mips64vr-* | mips64vrel-* \
*************** case $basic_machine in
*** 646,651 ****
--- 646,654 ----
  	m88k-omron*)
  		basic_machine=m88k-omron
  		;;
+ 	maxq)
+ 		basic_machine=maxq
+ 		;;
  	magnum | m3230)
  		basic_machine=mips-mips
  		os=-sysv

[-- Attachment #3: patch_maxq --]
[-- Type: application/octet-stream, Size: 4044 bytes --]

Index: gas/testsuite/gas/maxq10/call.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq10/call.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 call.d
*** gas/testsuite/gas/maxq10/call.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq10/call.d	9 Nov 2004 15:16:14 -0000
***************
*** 1,36 ****
! #objdump:  -dw
! #name: call operations
! 
! .*: +file format .*
! 
! Disassembly of section .text:
! 0+000 <foo>:
!    0:	02 3d [ 	]*CALL  #02h
!    2:	00 0b [ 	]*MOVE  PFX\[0\], #00h
! 
! 0+004 <SmallCall>:
!    4:	0d 8c [ 	]*RET 
!    6:	0d ac [ 	]*RET C
!    8:	0d 9c [ 	]*RET Z
!    a:	0d dc [ 	]*RET NZ
!    c:	0d cc [ 	]*RET S
!    e:	8d 8c [ 	]*RETI 
!   10:	8d ac [ 	]*RETI C
!   12:	8d 9c [ 	]*RETI Z
!   14:	8d dc [ 	]*RETI NZ
!   16:	8d cc [ 	]*RETI S
!   18:	10 7d [ 	]*MOVE  LC\[1\], #10h
!   1a:	00 3d [ 	]*CALL  #00h
!   1c:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
!   1e:	10 7d [ 	]*MOVE  LC\[1\], #10h
!   20:	00 3d [ 	]*CALL  #00h
! 	...
!  422:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  424:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
! 
!  426:	8d 8c [ 	]*RETI 
!  428:	8d ac [ 	]*RETI C
!  42a:	8d 9c [ 	]*RETI Z
!  42c:	8d dc [ 	]*RETI NZ
!  42e:	8d cc [ 	]*RETI S
! 	...
--- 1,42 ----
! #objdump: -dw
! #name: call operations
! 
! .*: +file format .*
! 
! Disassembly of section .text:
! 0+000 <foo>:
!    0:	03 3d [ 	]*CALL  #03h
!    2:	04 0b [ 	]*MOVE  PFX\[0\], #04h
!    4:	28 3d [ 	]*CALL  #28h
! 
! 0+006 <SmallCall>:
!    6:	0d 8c [ 	]*RET 
!    8:	0d ac [ 	]*RET C
!    a:	0d 9c [ 	]*RET Z
!    c:	0d dc [ 	]*RET NZ
!    e:	0d cc [ 	]*RET S
!   10:	8d 8c [ 	]*RETI 
!   12:	8d ac [ 	]*RETI C
!   14:	8d 9c [ 	]*RETI Z
!   16:	8d dc [ 	]*RETI NZ
!   18:	8d cc [ 	]*RETI S
!   1a:	10 7d [ 	]*MOVE  LC\[1\], #10h
! 
! 0+01c <LoopTop>:
!   1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
!   20:	10 7d [ 	]*MOVE  LC\[1\], #10h
! 
! 0+022 <LoopTop1>:
!   22:	00 3d [ 	]*CALL  #00h
! 	...
!  424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
! 
! 0+428 <LongCall>:
!  428:	8d 8c [ 	]*RETI 
!  42a:	8d ac [ 	]*RETI C
!  42c:	8d 9c [ 	]*RETI Z
!  42e:	8d dc [ 	]*RETI NZ
!  430:	8d cc [ 	]*RETI S
! 	...
Index: gas/testsuite/gas/maxq10/range.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq10/range.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 range.d
*** gas/testsuite/gas/maxq10/range.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq10/range.d	9 Nov 2004 15:16:14 -0000
*************** Disassembly of section .text:
*** 46,49 ****
    4c:	81 4a [ 	]*ADD  #81h
    4e:	ff 0b [ 	]*MOVE  PFX\[0\], #ffh
    50:	7f 4a [ 	]*ADD  #7fh
! 
--- 46,49 ----
    4c:	81 4a [ 	]*ADD  #81h
    4e:	ff 0b [ 	]*MOVE  PFX\[0\], #ffh
    50:	7f 4a [ 	]*ADD  #7fh
! 	...
Index: gas/testsuite/gas/maxq20/call.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq20/call.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 call.d
*** gas/testsuite/gas/maxq20/call.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq20/call.d	9 Nov 2004 15:16:14 -0000
*************** Disassembly of section .text:
*** 24,37 ****
  
  0+01c <LoopTop>:
    1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ LC\[1\], #ffh
    20:	10 7d [ 	]*MOVE  LC\[1\], #10h
  
  0+022 <LoopTop1>:
    22:	00 3d [ 	]*CALL  #00h
  	...
   424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ LC\[1\], #1ch
  
  0+428 <LongCall>:
   428:	8d 8c [ 	]*RETI 
--- 24,37 ----
  
  0+01c <LoopTop>:
    1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
    20:	10 7d [ 	]*MOVE  LC\[1\], #10h
  
  0+022 <LoopTop1>:
    22:	00 3d [ 	]*CALL  #00h
  	...
   424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
  
  0+428 <LongCall>:
   428:	8d 8c [ 	]*RETI 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Maxq port
  2004-11-16 14:55 [PATCH] Maxq port Inderpreet Singh Baweja
@ 2004-11-18 16:22 ` Nick Clifton
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2004-11-18 16:22 UTC (permalink / raw)
  To: Inderpreet Singh Baweja; +Cc: binutils, inderpreetb, config-patches

Hi Inderpreet,

> There is no problem with the patch.
> It is working fine on my system.

> NOTE: It may be because while configuring u require
> '--enable-bfd-assembler' option.

This was the problem.  Since it is obviously your intent that the maxq 
port should work with bfd-assembler enabled,  have fixed this in the 
configuration file and then applied your patch.

Cheers
   Nick

gas/ChangeLog
2004-11-18  Inderpreet Singh   <inderpreetb@nioda.hcltech.com>

	* configure.in: Enable bfd_assembler for the MAXQ port.
	* configure: Regenerate.

gas/testsuite/ChangeLog:
2004-11-18  Inderpreet Singh   <inderpreetb@nioda.hcltech.com>

	* gas/maxq10/call.d: Fix expected results now that bfd assembler
	support is enabled by default.
	* gas/maxq10/range.d: Likewise.
	* gas/maxq20/call.d: Likewise.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Maxq port
  2004-11-09 16:05 Inderpreet Singh Baweja
@ 2004-11-10 10:53 ` Nick Clifton
  0 siblings, 0 replies; 4+ messages in thread
From: Nick Clifton @ 2004-11-10 10:53 UTC (permalink / raw)
  To: Inderpreet Singh Baweja; +Cc: binutils

Hi Inderpreet,

> Thanks for accepting the patch.
> I have update the patch for the maxq port. 
> Can u please apply this to the mainline.

No sorry, but I am not going to apply this patch.  The changes to the 
GAS testsuite do not fix any failures and in fact they introduce more 
failures.

Meanwhile the patch to config.sub needs to be submitted to the config 
files maintainer at:  <config-patches@gnu.org>.

Cheers
   Nick

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] Maxq port
@ 2004-11-09 16:05 Inderpreet Singh Baweja
  2004-11-10 10:53 ` Nick Clifton
  0 siblings, 1 reply; 4+ messages in thread
From: Inderpreet Singh Baweja @ 2004-11-09 16:05 UTC (permalink / raw)
  To: Nick Clifton; +Cc: binutils

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

 
Hi Nick,

Thanks for accepting the patch.
I have update the patch for the maxq port. 
Can u please apply this to the mainline.

Thanks,
Inderpreet

[-- Attachment #2: patch_maxq --]
[-- Type: application/octet-stream, Size: 5708 bytes --]

? bfd/doc/bfd.info
? gas/doc/as.info
Index: config.sub
===================================================================
RCS file: /cvs/src/src/config.sub,v
retrieving revision 1.48
diff -c -3 -p -r1.48 config.sub
*** config.sub	4 Sep 2004 07:53:53 -0000	1.48
--- config.sub	9 Nov 2004 15:16:13 -0000
*************** case $basic_machine in
*** 237,243 ****
  	| h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
  	| i370 | i860 | i960 | ia64 \
  	| ip2k | iq2000 \
! 	| m32r | m32rle | m68000 | m68k | m88k | mcore \
  	| mips | mipsbe | mipseb | mipsel | mipsle \
  	| mips16 \
  	| mips64 | mips64el \
--- 237,243 ----
  	| h8300 | h8500 | hppa | hppa1.[01] | hppa2.0 | hppa2.0[nw] | hppa64 \
  	| i370 | i860 | i960 | ia64 \
  	| ip2k | iq2000 \
! 	| m32r | m32rle | m68000 | m68k | m88k | maxq |mcore \
  	| mips | mipsbe | mipseb | mipsel | mipsle \
  	| mips16 \
  	| mips64 | mips64el \
*************** case $basic_machine in
*** 311,317 ****
  	| m32r-* | m32rle-* \
  	| m68000-* | m680[012346]0-* | m68360-* | m683?2-* | m68k-* \
  	| m88110-* | m88k-* | mcore-* \
! 	| mips-* | mipsbe-* | mipseb-* | mipsel-* | mipsle-* \
  	| mips16-* \
  	| mips64-* | mips64el-* \
  	| mips64vr-* | mips64vrel-* \
--- 311,317 ----
  	| m32r-* | m32rle-* \
  	| m68000-* | m680[012346]0-* | m68360-* | m683?2-* | m68k-* \
  	| m88110-* | m88k-* | mcore-* \
! 	| maxq-* | mips-* | mipsbe-* | mipseb-* | mipsel-* | mipsle-* \
  	| mips16-* \
  	| mips64-* | mips64el-* \
  	| mips64vr-* | mips64vrel-* \
*************** case $basic_machine in
*** 642,647 ****
--- 642,650 ----
  	m88k-omron*)
  		basic_machine=m88k-omron
  		;;
+ 	maxq)
+                 basic_machine=maxq
+                 ;;
  	magnum | m3230)
  		basic_machine=mips-mips
  		os=-sysv
Index: gas/testsuite/gas/maxq10/call.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq10/call.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 call.d
*** gas/testsuite/gas/maxq10/call.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq10/call.d	9 Nov 2004 15:16:14 -0000
***************
*** 1,36 ****
! #objdump:  -dw
! #name: call operations
! 
! .*: +file format .*
! 
! Disassembly of section .text:
! 0+000 <foo>:
!    0:	02 3d [ 	]*CALL  #02h
!    2:	00 0b [ 	]*MOVE  PFX\[0\], #00h
! 
! 0+004 <SmallCall>:
!    4:	0d 8c [ 	]*RET 
!    6:	0d ac [ 	]*RET C
!    8:	0d 9c [ 	]*RET Z
!    a:	0d dc [ 	]*RET NZ
!    c:	0d cc [ 	]*RET S
!    e:	8d 8c [ 	]*RETI 
!   10:	8d ac [ 	]*RETI C
!   12:	8d 9c [ 	]*RETI Z
!   14:	8d dc [ 	]*RETI NZ
!   16:	8d cc [ 	]*RETI S
!   18:	10 7d [ 	]*MOVE  LC\[1\], #10h
!   1a:	00 3d [ 	]*CALL  #00h
!   1c:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
!   1e:	10 7d [ 	]*MOVE  LC\[1\], #10h
!   20:	00 3d [ 	]*CALL  #00h
! 	...
!  422:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  424:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
! 
!  426:	8d 8c [ 	]*RETI 
!  428:	8d ac [ 	]*RETI C
!  42a:	8d 9c [ 	]*RETI Z
!  42c:	8d dc [ 	]*RETI NZ
!  42e:	8d cc [ 	]*RETI S
! 	...
--- 1,42 ----
! #objdump: -dw
! #name: call operations
! 
! .*: +file format .*
! 
! Disassembly of section .text:
! 0+000 <foo>:
!    0:	03 3d [ 	]*CALL  #03h
!    2:	04 0b [ 	]*MOVE  PFX\[0\], #04h
!    4:	28 3d [ 	]*CALL  #28h
! 
! 0+006 <SmallCall>:
!    6:	0d 8c [ 	]*RET 
!    8:	0d ac [ 	]*RET C
!    a:	0d 9c [ 	]*RET Z
!    c:	0d dc [ 	]*RET NZ
!    e:	0d cc [ 	]*RET S
!   10:	8d 8c [ 	]*RETI 
!   12:	8d ac [ 	]*RETI C
!   14:	8d 9c [ 	]*RETI Z
!   16:	8d dc [ 	]*RETI NZ
!   18:	8d cc [ 	]*RETI S
!   1a:	10 7d [ 	]*MOVE  LC\[1\], #10h
! 
! 0+01c <LoopTop>:
!   1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
!   20:	10 7d [ 	]*MOVE  LC\[1\], #10h
! 
! 0+022 <LoopTop1>:
!   22:	00 3d [ 	]*CALL  #00h
! 	...
!  424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
! 
! 0+428 <LongCall>:
!  428:	8d 8c [ 	]*RETI 
!  42a:	8d ac [ 	]*RETI C
!  42c:	8d 9c [ 	]*RETI Z
!  42e:	8d dc [ 	]*RETI NZ
!  430:	8d cc [ 	]*RETI S
! 	...
Index: gas/testsuite/gas/maxq10/range.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq10/range.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 range.d
*** gas/testsuite/gas/maxq10/range.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq10/range.d	9 Nov 2004 15:16:14 -0000
*************** Disassembly of section .text:
*** 46,49 ****
    4c:	81 4a [ 	]*ADD  #81h
    4e:	ff 0b [ 	]*MOVE  PFX\[0\], #ffh
    50:	7f 4a [ 	]*ADD  #7fh
! 
--- 46,49 ----
    4c:	81 4a [ 	]*ADD  #81h
    4e:	ff 0b [ 	]*MOVE  PFX\[0\], #ffh
    50:	7f 4a [ 	]*ADD  #7fh
! 	...
Index: gas/testsuite/gas/maxq20/call.d
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/maxq20/call.d,v
retrieving revision 1.1
diff -c -3 -p -r1.1 call.d
*** gas/testsuite/gas/maxq20/call.d	8 Nov 2004 13:17:42 -0000	1.1
--- gas/testsuite/gas/maxq20/call.d	9 Nov 2004 15:16:14 -0000
*************** Disassembly of section .text:
*** 24,37 ****
  
  0+01c <LoopTop>:
    1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ LC\[1\], #ffh
    20:	10 7d [ 	]*MOVE  LC\[1\], #10h
  
  0+022 <LoopTop1>:
    22:	00 3d [ 	]*CALL  #00h
  	...
   424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ LC\[1\], #1ch
  
  0+428 <LongCall>:
   428:	8d 8c [ 	]*RETI 
--- 24,37 ----
  
  0+01c <LoopTop>:
    1c:	00 3d [ 	]*CALL  #00h
!   1e:	ff 5d [ 	]*DJNZ  LC\[1\], #ffh
    20:	10 7d [ 	]*MOVE  LC\[1\], #10h
  
  0+022 <LoopTop1>:
    22:	00 3d [ 	]*CALL  #00h
  	...
   424:	00 0b [ 	]*MOVE  PFX\[0\], #00h
!  426:	1c 5d [ 	]*DJNZ  LC\[1\], #1ch
  
  0+428 <LongCall>:
   428:	8d 8c [ 	]*RETI 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2004-11-18 16:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-11-16 14:55 [PATCH] Maxq port Inderpreet Singh Baweja
2004-11-18 16:22 ` Nick Clifton
  -- strict thread matches above, loose matches on Subject: below --
2004-11-09 16:05 Inderpreet Singh Baweja
2004-11-10 10:53 ` Nick Clifton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).