public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Bob Wilson <bwilson@tensilica.com>
Cc: binutils@sources.redhat.com, Daniel Jacobowitz <drow@false.org>,
	 Alan Modra <amodra@bigpond.net.au>
Subject: Re: [PATCH] inconsistent DWARF2 sections generated by --gdwarf2
Date: Mon, 22 Nov 2004 12:19:00 -0000	[thread overview]
Message-ID: <41A1DA5E.8080700@redhat.com> (raw)
In-Reply-To: <419CE636.9090807@tensilica.com>

Hi Bob,

> I just tried --gstabs and --gstabs+ for several input files, and I don't 
> see any problems.
> 
> I think your concern is misplaced, i.e., the patch might not be correct, 
> but it shouldn't cause GAS to generate "extra" dwarf2 debugging output.  
> Look at it this way: the patch removes one of the conditions required 
> for dwarf2_finish to return without doing anything.  It can only 
> increase the number of situations where dwarf2_finish does nothing.

Fair enough.  Thank you for running the extra checks.  Please consider 
this patch approved and apply it when you can.

Cheers
   Nick


      parent reply	other threads:[~2004-11-22 12:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-15 19:27 Bob Wilson
2004-11-18  3:31 ` Alan Modra
2004-11-18  8:39   ` Nick Clifton
2004-11-18  8:59     ` Alan Modra
2004-11-18  9:18       ` Nick Clifton
2004-11-18 11:58         ` Alan Modra
2004-11-18 14:22           ` Daniel Jacobowitz
2004-11-18 18:14             ` Bob Wilson
2004-11-18 18:42               ` Daniel Jacobowitz
2004-11-22 12:19               ` Nick Clifton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41A1DA5E.8080700@redhat.com \
    --to=nickc@redhat.com \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    --cc=bwilson@tensilica.com \
    --cc=drow@false.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).