From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-36549-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 2699 invoked by alias); 22 Nov 2004 12:19:50 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 2481 invoked from network); 22 Nov 2004 12:19:40 -0000
Received: from unknown (HELO relay3.mail.uk.clara.net) (80.168.70.143)
  by sourceware.org with SMTP; 22 Nov 2004 12:19:40 -0000
Received: from adsl-2-solo-172-103.claranet.co.uk ([80.168.172.103] helo=[172.31.0.98])
	by relay3.mail.uk.clara.net with esmtp (Exim 4.34)
	id 1CWDAP-000FQt-D5; Mon, 22 Nov 2004 12:19:37 +0000
Message-ID: <41A1DA5E.8080700@redhat.com>
Date: Mon, 22 Nov 2004 12:19:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 0.7.3 (X11/20040803)
MIME-Version: 1.0
To: Bob Wilson <bwilson@tensilica.com>
CC:  binutils@sources.redhat.com, Daniel Jacobowitz <drow@false.org>, 
 Alan Modra <amodra@bigpond.net.au>
Subject: Re: [PATCH] inconsistent DWARF2 sections generated by --gdwarf2
References: <41990311.3060504@tensilica.com> <20041118033117.GD17083@bubble.modra.org> <419C60C8.3020501@redhat.com> <20041118085901.GB21809@bubble.modra.org> <419C69DD.5030106@redhat.com> <20041118115814.GA22378@bubble.modra.org> <20041118142206.GA29928@nevyn.them.org> <419CE636.9090807@tensilica.com>
In-Reply-To: <419CE636.9090807@tensilica.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-11/txt/msg00304.txt.bz2

Hi Bob,

> I just tried --gstabs and --gstabs+ for several input files, and I don't 
> see any problems.
> 
> I think your concern is misplaced, i.e., the patch might not be correct, 
> but it shouldn't cause GAS to generate "extra" dwarf2 debugging output.  
> Look at it this way: the patch removes one of the conditions required 
> for dwarf2_finish to return without doing anything.  It can only 
> increase the number of situations where dwarf2_finish does nothing.

Fair enough.  Thank you for running the extra checks.  Please consider 
this patch approved and apply it when you can.

Cheers
   Nick