From: Andrew STUBBS <andrew.stubbs@st.com>
To: binutils <binutils@sources.redhat.com>
Subject: [SH64 Patch] Add diagnostic messages to gas
Date: Wed, 15 Dec 2004 14:39:00 -0000 [thread overview]
Message-ID: <41C04BDE.B40032D3@st.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 359 bytes --]
SHmedia PT instructions are not permitted to have expressions as
arguments. This is currently tested, but instead of giving an error
message the bad code is just ignored.
The attached patch adds a simple error message. This should be enough to
bring the problem to the user's attention.
--
Andrew Stubbs
andrew.stubbs@st.com
(aka. andrew.stubbs@superh.com)
[-- Attachment #2: sh64-diagnostic.patch --]
[-- Type: text/plain, Size: 1023 bytes --]
2004-12-14 Andrew Stubbs <andrew.stubbs@st.com>
* config/tc-sh64.c (shmedia_build_Mytes): Emit an error message rather
than just ignoring bad code.
--- src/gas/config/tc-sh64.c 2004-01-14 21:07:45.000000000 +0000
+++ src/gas/config/tc-sh64.c 2004-12-15 14:17:43.000000000 +0000
@@ -2672,7 +2711,10 @@ shmedia_build_Mytes (shmedia_opcode_info
/* Don't allow complex expressions here. */
if (opjp->immediate.X_op_symbol != NULL)
- return 0;
+ {
+ as_bad(_("invalid operand: expression in PT target"));
+ return 0;
+ }
if (opjp->reloctype == BFD_RELOC_32_PLT_PCREL)
init = max = min = SH64PCRELPLT;
@@ -2709,7 +2751,10 @@ shmedia_build_Mytes (shmedia_opcode_info
/* Don't allow complex expressions here. */
if (opjp->immediate.X_op_symbol != NULL)
- return 0;
+ {
+ as_bad(_("invalid operand: expression in PT target"));
+ return 0;
+ }
if (opjp->reloctype == BFD_RELOC_32_PLT_PCREL)
init = max = min = SH64PCRELPLT;
reply other threads:[~2004-12-15 14:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C04BDE.B40032D3@st.com \
--to=andrew.stubbs@st.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).