From: Nick Clifton <nickc@redhat.com>
To: Prafulla Thakare <PrafullaT@KPITCummins.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Readelf patch to group common symbols.
Date: Thu, 16 Dec 2004 11:54:00 -0000 [thread overview]
Message-ID: <41C178DA.6080006@redhat.com> (raw)
In-Reply-To: <4A1BE23A7B777442B60F4B4916AE0F1303B6ACCB@sohm.kpit.com>
Hi Prafulla,
> Please find attached the patch for readelf. This is developed to group
> all the common symbols from different compilation unit if built in debug
> mode.
Thanks for submitting this patch. Unfortunately I have some issues with it:
* Why is this feature necessary ? Surely this information can be
gleaned from the switches already supported by readelf ?
* Does KPIT have an FSF assignment in place ? I could only find one:
KPIT InfoSystems Ltd. 2002-02-26
Assigns past and future changes. (tc-sh.c)
anandk@kpit.com (Anandkumar Keshavan)
* The new code in the patch does not follow the GNU Coding Standard.
* Since this patch adds a new feature to readelf there should be
patches to binutils/NEWS to announce it and binutils/doc/binutils.texi
to document it.
* A binutils testsuite entry to check the new functionality provided
by the patch would be very welcome.
I hope that you will consider these issues and get back to us with a
revised patch.
Cheers
Nick
next prev parent reply other threads:[~2004-12-16 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-13 13:32 Prafulla Thakare
2004-12-16 11:54 ` Nick Clifton [this message]
2004-12-21 6:43 Prafulla Thakare
2004-12-21 17:48 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41C178DA.6080006@redhat.com \
--to=nickc@redhat.com \
--cc=PrafullaT@KPITCummins.com \
--cc=binutils@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).