public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Kris Warkentin <kewarken@qnx.com>
To: binutils@sources.redhat.com
Subject: [patch] (OB?) Fix for QNX Neutrino core file floating point handler
Date: Tue, 21 Dec 2004 22:34:00 -0000	[thread overview]
Message-ID: <41C8A4E2.8070900@qnx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

We weren't generating the floating point register core file sections 
properly.  Instead of .reg2/tid we were getting .reg2/pid which was 
confusing gdb.  This patch fixes that.  Okay to commit?

cheers,

Kris


ChangeLog:

2004-12-21  Kris Warkentin  <kewarken@qnx.com>
	* elf.c (elfcore_grok_nto_gregs): Change name to ..._nto_regs.
	Add 'base' argument for constructing register sections.
	Reformat.
	(elfcore_grok_nto_note): Call elfcore_grok_nto_regs for both
	gp and fp regs.  Reformat.



[-- Attachment #2: bfd.diff --]
[-- Type: text/plain, Size: 1832 bytes --]

Index: elf.c
===================================================================
RCS file: /cvs/src/src/bfd/elf.c,v
retrieving revision 1.258
diff -u -r1.258 elf.c
--- elf.c	10 Dec 2004 14:04:55 -0000	1.258
+++ elf.c	21 Dec 2004 22:22:46 -0000
@@ -7382,14 +7382,17 @@
 }
 
 static bfd_boolean
-elfcore_grok_nto_gregs (bfd *abfd, Elf_Internal_Note *note, pid_t tid)
+elfcore_grok_nto_regs (bfd *abfd,
+		       Elf_Internal_Note *note,
+		       pid_t tid,
+		       char *base)
 {
   char buf[100];
   char *name;
   asection *sect;
 
-  /* Make a ".reg/%d" section.  */
-  sprintf (buf, ".reg/%d", tid);
+  /* Make a "(base)/%d" section.  */
+  sprintf (buf, "%s/%d", base, tid);
 
   name = bfd_alloc (abfd, strlen (buf) + 1);
   if (name == NULL)
@@ -7407,7 +7410,7 @@
 
   /* This is the current thread.  */
   if (elf_tdata (abfd)->core_lwpid == tid)
-    return elfcore_maybe_make_sect (abfd, ".reg", sect);
+    return elfcore_maybe_make_sect (abfd, base, sect);
 
   return TRUE;
 }
@@ -7427,11 +7430,16 @@
 
   switch (note->type)
     {
-    case BFD_QNT_CORE_INFO:   return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note);
-    case BFD_QNT_CORE_STATUS: return elfcore_grok_nto_status (abfd, note, &tid);
-    case BFD_QNT_CORE_GREG:   return elfcore_grok_nto_gregs (abfd, note, tid);
-    case BFD_QNT_CORE_FPREG:  return elfcore_grok_prfpreg (abfd, note);
-    default:                  return TRUE;
+    case BFD_QNT_CORE_INFO:
+	 return elfcore_make_note_pseudosection (abfd, ".qnx_core_info", note);
+    case BFD_QNT_CORE_STATUS:
+	return elfcore_grok_nto_status (abfd, note, &tid);
+    case BFD_QNT_CORE_GREG:
+	return elfcore_grok_nto_regs (abfd, note, tid, ".reg");
+    case BFD_QNT_CORE_FPREG:
+	return elfcore_grok_nto_regs (abfd, note, tid, ".reg2");
+    default:
+	return TRUE;
     }
 }
 

             reply	other threads:[~2004-12-21 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-21 22:34 Kris Warkentin [this message]
2004-12-22  4:34 ` Alan Modra
2004-12-22 14:45   ` Commited:[patch] (OB?) Fix for QNX Neutrino core file floating point h andler Kris Warkentin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41C8A4E2.8070900@qnx.com \
    --to=kewarken@qnx.com \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).