From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11340 invoked by alias); 5 Jan 2005 13:46:51 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 10987 invoked from network); 5 Jan 2005 13:46:19 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 5 Jan 2005 13:46:19 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j05DkJSo011947 for ; Wed, 5 Jan 2005 08:46:19 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j05DkIr00712; Wed, 5 Jan 2005 08:46:18 -0500 Received: from [172.31.0.98] (vpnuser2.surrey.redhat.com [172.16.9.2]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j05DkH0a011729; Wed, 5 Jan 2005 13:46:17 GMT Message-ID: <41DBF16F.9010809@redhat.com> Date: Wed, 05 Jan 2005 13:46:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0RC1 (X11/20041201) MIME-Version: 1.0 To: "H. J. Lu" CC: binutils@sources.redhat.com Subject: Re: PATCH: Check if DW_OP_fbreg has DW_AT_frame_base References: <20050104183237.GA28216@lucon.org> <20050104221035.GA31566@lucon.org> <20050104231454.GA32690@lucon.org> In-Reply-To: <20050104231454.GA32690@lucon.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-01/txt/msg00045.txt.bz2 Hi H. J. > 2005-01-04 H.J. Lu > > * readelf.c (have_frame_base): New. > (need_base_address): Likewise. > (saved_base_address): Likewise. > (decode_location_expression): Return 1 if DW_AT_frame_base is > needed. > (debug_info): Add base_address and a have_frame_base pointer. > (read_and_display_attr_value): Replace saved_DW_AT_low_pc with > saved_base_address. Record base address. Set have_frame_base. > Record if a location list has DW_AT_frame_base. Display if a > location expression has no DW_AT_frame_base but needs one. Set > saved_base_address only if needed. > (process_debug_info): Clear have_frame_base, saved_base_address > and set need_base_address. > (display_debug_loc): Display if a location expression has no > DW_AT_frame_base but needs one. Display if start >= end. Don't > adjust for section address. Properly handle base address. > (process_object): Free the have_frame_base pointer in > debug_info. Approved - please apply. Cheers Nick