public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Inderpreet Singh Baweja <Inderpreet.Baweja@noida.hcltech.com>
Cc: binutils@sources.redhat.com, "Naveen Sharma,
	Noida" <naveen.sharma@noida.hcltech.com>
Subject: Re: [PATCH]: binutils patch for maxq target.
Date: Mon, 10 Jan 2005 16:36:00 -0000	[thread overview]
Message-ID: <41E2B0C5.40507@redhat.com> (raw)
In-Reply-To: <33BC33A9E76474479B76AD0DE8A16972015C97@exch-ntd.nec.noida.hcltech.com>

Hi Inderpreet,

> Thanks for reviewing my patch and I do appreciate you for pointing
> Out my mistakes. Thanks for that.
> 
> Here I have separated down individual patches this will be the 
> first of the series.
> 
> This patch will enable the maxq target to
> differentiate between machine types( MAXQ10 and MAXQ20 ).

Thanks - I have applied this patch but I still had to fix up a few problems:

   1) You did not supply a ChangeLog entry for the changes to the 
include/coff/maxq.h file.

   2) You added a function called "compatible" in bfd/cpu-maxq.c that is 
not used.

   3) The field "the_default" for the maxq10 architecture description in 
bfd/cpu-maxq.c was set to true even when in fact it is not the default.

Cheers
   Nick


  reply	other threads:[~2005-01-10 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-06  9:58 Inderpreet Singh Baweja
2005-01-10 16:36 ` Nick Clifton [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-12-28 14:09 Inderpreet Singh Baweja
2005-01-05  9:48 ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41E2B0C5.40507@redhat.com \
    --to=nickc@redhat.com \
    --cc=Inderpreet.Baweja@noida.hcltech.com \
    --cc=binutils@sources.redhat.com \
    --cc=naveen.sharma@noida.hcltech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).