From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-37246-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 32046 invoked by alias); 19 Jan 2005 11:27:56 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 32004 invoked from network); 19 Jan 2005 11:27:52 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 19 Jan 2005 11:27:52 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j0JBRq4h021014
	for <binutils@sources.redhat.com>; Wed, 19 Jan 2005 06:27:52 -0500
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j0JBRpO08061
	for <binutils@sources.redhat.com>; Wed, 19 Jan 2005 06:27:51 -0500
Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j0JBRneq014097;
	Wed, 19 Jan 2005 11:27:49 GMT
Message-ID: <41EE4639.9010000@redhat.com>
Date: Wed, 19 Jan 2005 11:27:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Richard Sandiford <rsandifo@redhat.com>
CC: binutils@sources.redhat.com
Subject: Re: RFC: .sleb128 and bignums
References: <wvnis64ghb0.fsf@talisman.cambridge.redhat.com>	<41EBE4F6.2060100@redhat.com> <wvnzmz6lvg1.fsf@talisman.cambridge.redhat.com>
In-Reply-To: <wvnzmz6lvg1.fsf@talisman.cambridge.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-01/txt/msg00241.txt.bz2

Hi Richard,

> gas/
> 	* read.c (convert_to_bignum): New function, split out from...
> 	(emit_expr): ...here.  Handle the case where X_add_number is
> 	positive and the input value is negative.
> 	(output_big_sleb128): Fix setting of continuation bit.  Check whether
> 	the final byte needs to be sign-extended.  Fix size-shrinking loop.
> 	(emit_leb128_expr): When generating a signed leb128, see whether the
> 	sign of an O_constant's X_add_number matches the sign of the input
> 	value.  Use a bignum if not.
> 
> gas/testsuite/
> 	* gas/all/sleb128.[sd]: New test.
> 	* gas/all/quad.[sd]: New test.
> 	* gas/all/gas.exp: Run them.

Approved - please apply.

Cheers
   Nick