From: Nick Clifton <nickc@redhat.com>
To: Richard Sandiford <rsandifo@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: Target-specific FDE pointer sizes (2/3)
Date: Mon, 31 Jan 2005 11:17:00 -0000 [thread overview]
Message-ID: <41FE15A5.8080308@redhat.com> (raw)
In-Reply-To: <87zmys1szw.fsf@redhat.com>
Hi Richard,
> As with the bfd patch, we need to distinguish between the official
> LP64 ABI and the not-so-official ILP32 variant. In the case of bfd,
> it was important that we get the size right, and we had to punt if
> we weren't sure. In the case of readelf, I think we just want a
> "best guess", since we have to output _something_.
I think that if readelf has to guess it should inform the user that it
is doing so. That way the user has a chance to realise that readelf
might have guessed incorrectly and that is why its output does not match
their expectations.
> binutils/
> * readelf.c (eh_addr_size): New variable.
> (find_section): Move earlier in file. Return empty sections too.
> (process_program_headers): Use find_section to find .dynamic.
> (process_section_headers): Initialize eh_addr_size.
> (dump_ia64_unwind, slurp_ia64_unwind_table, ia64_process_unwind)
> (dump_hppa_unwind, slurp_hppa_unwind_table, hppa_process_unwind)
> (display_debug_frames): Use it instead of local addr_size variable.
> (size_of_encoded_value): Get pointer size from eh_addr_size rather
> than is_32bit_elf.
Approved - with the addition of a warning message when readelf is forced
to guess.
Cheers
Nick
next prev parent reply other threads:[~2005-01-31 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-29 9:02 Target-specific FDE pointer sizes (1/3) Richard Sandiford
2005-01-29 9:31 ` Target-specific FDE pointer sizes (2/3) Richard Sandiford
2005-01-29 9:58 ` Target-specific FDE pointer sizes (3/3) Richard Sandiford
2005-01-31 11:17 ` Nick Clifton [this message]
2005-01-31 11:37 ` Target-specific FDE pointer sizes (2/3) Richard Sandiford
2005-01-31 11:47 ` Nick Clifton
2005-01-31 12:15 ` Richard Sandiford
2005-01-31 16:20 ` Nick Clifton
2005-01-31 20:42 ` Richard Sandiford
2005-01-31 11:12 ` Target-specific FDE pointer sizes (1/3) Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE15A5.8080308@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=rsandifo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).