From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29335 invoked by alias); 31 Jan 2005 11:17:00 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 27952 invoked from network); 31 Jan 2005 11:16:01 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 31 Jan 2005 11:16:01 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j0VBG1Et027401 for ; Mon, 31 Jan 2005 06:16:01 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j0VBG0O19864 for ; Mon, 31 Jan 2005 06:16:00 -0500 Received: from [172.31.0.98] (vpnuser9.surrey.redhat.com [172.16.9.9]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j0VBFx0W004286; Mon, 31 Jan 2005 11:15:59 GMT Message-ID: <41FE15A5.8080308@redhat.com> Date: Mon, 31 Jan 2005 11:17:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Richard Sandiford CC: binutils@sources.redhat.com Subject: Re: Target-specific FDE pointer sizes (2/3) References: <874qh038y1.fsf@redhat.com> <87zmys1szw.fsf@redhat.com> In-Reply-To: <87zmys1szw.fsf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-01/txt/msg00537.txt.bz2 Hi Richard, > As with the bfd patch, we need to distinguish between the official > LP64 ABI and the not-so-official ILP32 variant. In the case of bfd, > it was important that we get the size right, and we had to punt if > we weren't sure. In the case of readelf, I think we just want a > "best guess", since we have to output _something_. I think that if readelf has to guess it should inform the user that it is doing so. That way the user has a chance to realise that readelf might have guessed incorrectly and that is why its output does not match their expectations. > binutils/ > * readelf.c (eh_addr_size): New variable. > (find_section): Move earlier in file. Return empty sections too. > (process_program_headers): Use find_section to find .dynamic. > (process_section_headers): Initialize eh_addr_size. > (dump_ia64_unwind, slurp_ia64_unwind_table, ia64_process_unwind) > (dump_hppa_unwind, slurp_hppa_unwind_table, hppa_process_unwind) > (display_debug_frames): Use it instead of local addr_size variable. > (size_of_encoded_value): Get pointer size from eh_addr_size rather > than is_32bit_elf. Approved - with the addition of a warning message when readelf is forced to guess. Cheers Nick