From: Nick Clifton <nickc@redhat.com>
To: Zack Weinberg <zack@codesourcery.com>
Cc: Binutils Mailing List <binutils@sources.redhat.com>
Subject: Re: Better diagnostics for undefined symbols in assignments to dot
Date: Mon, 14 Feb 2005 16:38:00 -0000 [thread overview]
Message-ID: <421084EA.5030105@redhat.com> (raw)
In-Reply-To: <1108167916.4309.55.camel@localhost.localdomain>
Hi Zack,
> Since no one seems interested in helping me with this,
Sorry :-(
> I have redone it
> in a way which at least does not break anything. I'm not hugely
> enthused about adding a file-global state flag,
I agree - but your way is certainly the cleanest and simplest way of
solving the problem.
> * ldexp.c (assigning_to_dot): New global flag.
> (fold_name): If assigning_to_dot is true, object immediately to
> an undefined symbol.
> (exp_fold_tree): Set and clear assigning_to_dot around the
> recursive call to exp_fold_tree to process the right-hand side
> of an assignment to the location counter.
>
> testsuite:
> * ld-scripts/align.exp: Rename existing "ALIGN" test to "align1".
> Add dump tests "align2a", "align2b", "align2c".
> * ld-scripts/align2.t, ld-scripts/align2a.s, ld-scripts/align2a.d
> * ld-scripts/align2b.s, ld-scripts/align2b.d
> * ld-scripts/align2c.s, ld-scripts/align2c.d: New files.
Approved - please apply.
Cheers
Nick
prev parent reply other threads:[~2005-02-14 10:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-09 1:19 Zack Weinberg
2005-02-13 12:36 ` Zack Weinberg
2005-02-14 16:38 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=421084EA.5030105@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=zack@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).