public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: Alan Modra <amodra@bigpond.net.au>
Cc: binutils@sources.redhat.com
Subject: Re: Making generic ld testcases pass on more targets
Date: Wed, 16 Feb 2005 17:03:00 -0000	[thread overview]
Message-ID: <42133911.2010905@redhat.com> (raw)
In-Reply-To: <20050216115635.GR10128@bubble.modra.org>

Hi Alan,

> +#ifdef BFD_ASSEMBLER
> +  {"dc.a", cons, 0},
> +#endif

I like this, but why make the pseudo specific to BFD_ASSEMBLERs ?


> +#ifdef BFD_ASSEMBLER
> +  if (nbytes == 0)
> +    {
> +      /* Choose smallest of 1, 2, 4, 8 bytes that is large enough to
> +	 contain an address.  */
> +      nbytes = (stdoutput->arch_info->bits_per_address - 1) / 8;

It might make sense to allow for individual targets to override this 
computation with their own value if they so wish.

Cheers
   Nick


  reply	other threads:[~2005-02-16 12:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-16 14:15 Alan Modra
2005-02-16 17:03 ` Nick Clifton [this message]
2005-02-16 18:48   ` Alan Modra
2005-02-16 19:48     ` Nick Clifton
2005-02-17  7:44 ` Hans-Peter Nilsson
2005-02-17 12:26   ` Hans-Peter Nilsson
2005-02-17 12:58   ` Alan Modra
2005-02-17 13:02     ` Hans-Peter Nilsson
2005-02-21 15:51       ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42133911.2010905@redhat.com \
    --to=nickc@redhat.com \
    --cc=amodra@bigpond.net.au \
    --cc=binutils@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).