From: Nick Clifton <nickc@redhat.com>
To: clm@cm00re.com
Cc: binutils@sourceware.org
Subject: Re: [PATCH] Additional TC_EQUAL_IN_INSN check
Date: Wed, 16 Feb 2005 17:54:00 -0000 [thread overview]
Message-ID: <42133AF4.2070602@redhat.com> (raw)
In-Reply-To: <200502151337.j1FDb4u2012330@mx3.redhat.com>
Hi Catherine,
> This patch adds an argument to TC_EQUAL_IN_INSN so that the current string
> can be checked.
Why is this needed ? Do you have a port where the current semantics for
TC_EQUAL_IN_INSN are insufficient ? [The string 's' can be deduced from
input_line_pointer, so why pass it as an extra argument ?]
> It also adds an additional check for TC_EQUAL_IN_INSN in
> read_a_source_file.
Again - why is is this necessary ? Couldn't the if-statement be
rearranged so that there was only one invocation of TC_EQUAL_IN_INSN ?
Cheers
Nick
next parent reply other threads:[~2005-02-16 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200502151337.j1FDb4u2012330@mx3.redhat.com>
2005-02-16 17:54 ` Nick Clifton [this message]
2005-02-17 21:34 ` Catherine Moore
[not found] ` <20050217183642.EVRM13037.imta01ps.mx.bigpond.com@psmam02.bigpond.com>
2005-02-18 12:36 ` Alan Modra
[not found] <200502181605.j1IG5t7e028779@mx1.redhat.com>
2005-02-18 22:14 ` Nick Clifton
[not found] <200502171836.j1HIaXgg006973@mx1.redhat.com>
2005-02-18 21:41 ` Nick Clifton
2005-02-18 21:43 ` Catherine Moore
2005-02-15 18:10 Catherine Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42133AF4.2070602@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=clm@cm00re.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).