From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-37999-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 17322 invoked by alias); 16 Feb 2005 12:56:57 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 17237 invoked from network); 16 Feb 2005 12:56:50 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 16 Feb 2005 12:56:50 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1GCuoHo023311
	for <binutils@sources.redhat.com>; Wed, 16 Feb 2005 07:56:50 -0500
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1GCuoO07602;
	Wed, 16 Feb 2005 07:56:50 -0500
Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1GCumMR027997;
	Wed, 16 Feb 2005 12:56:49 GMT
Message-ID: <42134588.1060708@redhat.com>
Date: Wed, 16 Feb 2005 19:22:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Ian Lance Taylor <ian@airs.com>
CC: binutils@sources.redhat.com
Subject: Re: Fix for compile time warning in binutils/nlmconv.c
References: <m3oeelansx.fsf@redhat.com> <m3wtt93gp4.fsf@gossamer.airs.com>
In-Reply-To: <m3wtt93gp4.fsf@gossamer.airs.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-02/txt/msg00371.txt.bz2

Hi Ian,

> However, your patch is not a good idea.  There are undoubtedly systems
> out there which declare localtime with different parameter types--in
> particular omitting the const--so your patch will change those
> systems from a warning to an error.
> 
> Better to remove the declaration entirely.  Modern systems don't need
> the declaration, and older systems will most likely be OK with the
> warning.

Thanks for the explanation - I agree that removing the prototype is the 
simplest solution for now, so I have checked in the obvious patch to do 
this.

Cheers
   Nick

binutils/ChangeLog
2005-02-16  Nick Clifton  <nickc@redhat.com>

	* nlmconv.c: Remove prototype for localetime altogether.  It
	should not be needed on modern systems and older systems can live
	with the warning.