From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4964 invoked by alias); 18 Feb 2005 14:34:13 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 4932 invoked from network); 18 Feb 2005 14:34:07 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 18 Feb 2005 14:34:07 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1IEY6HS031018; Fri, 18 Feb 2005 09:34:06 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1IEY5O11429; Fri, 18 Feb 2005 09:34:05 -0500 Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1IEY4MR014005; Fri, 18 Feb 2005 14:34:04 GMT Message-ID: <4215FF5D.8040208@redhat.com> Date: Fri, 18 Feb 2005 21:41:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: clm@cm00re.com CC: binutils@sourceware.org Subject: Re: [PATCH] Additional TC_EQUAL_IN_INSN check References: <200502171836.j1HIaXgg006973@mx1.redhat.com> In-Reply-To: <200502171836.j1HIaXgg006973@mx1.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00440.txt.bz2 Hi Catherine, > I don't think passing an extra argument is a big deal. If s is available, > why not use it instead of deducing it? Well my point was: "why make an unnecessary change ?" > It turns out that the only port > (other than the one I'm working on) which uses this macro is the hppa and > the hppa port doesn't look at the string. I've reworked the patch to pass s > and not input_line_pointer to the TC_EQUAL_IN_INSN macro and also to use > only one invocation of the macro as you suggested. Okay to install, now? Yes, with the proviso that you fix the documentation as Alan suggested. > * read.c (read_a_source_file): Check TC_EQUAL_IN_INSN if c is '='. > * doc/internals.texi (TC_EQUAL_IN_INSN): Pass current string instead of > input_line_pointer. Approved. > If you define this macro, it should return nonzero if the instruction is > permitted to contain an @kbd{=} character. GAS will call it with two > arguments, the character before the @kbd{=} character, and the value of > ! @code{s} at that point. GAS uses this macro to decide if a > @kbd{=} is an assignment or an instruction. How about "and the string that follows after the equals sign" ? Cheers Nick