From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24548 invoked by alias); 22 Feb 2005 16:18:01 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 24494 invoked from network); 22 Feb 2005 16:17:58 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 22 Feb 2005 16:17:58 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1MGHw43004981 for ; Tue, 22 Feb 2005 11:17:58 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1MGHvK06743; Tue, 22 Feb 2005 11:17:57 -0500 Received: from [172.31.0.98] (vpn83-133.boston.redhat.com [172.16.83.133]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1MGHqMR010064; Tue, 22 Feb 2005 16:17:53 GMT Message-ID: <421B5DC3.50809@redhat.com> Date: Tue, 22 Feb 2005 18:45:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Alan Modra CC: "H. J. Lu" , binutils@sources.redhat.com Subject: Re: PATCH: Fix "FAIL: objcopy (simple copy)" for tic54x-coff References: <20050221210909.GA14151@lucon.org> <20050222005716.GE900@bubble.modra.org> In-Reply-To: <20050222005716.GE900@bubble.modra.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00509.txt.bz2 Hi Alan, Hi H.J. >> * coffcode.h (coff_write_relocs): Clear the r_reserved field >> if COFF_REL_HAS_R_RESERVED is defined before swapping out >> relocation. > This should really be done by defining a coff_SWAP_reloc_out function > for these targets. I agree with Alan - why not define the SWAP_OUT_RELOC_EXTRA macro for the tic54x-coff port and have that write out zeros for the r_reserved field ? Cheers Nick