From: Nick Clifton <nickc@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Fix buffer overflows in readelf
Date: Mon, 28 Feb 2005 17:16:00 -0000 [thread overview]
Message-ID: <42233A27.2010004@redhat.com> (raw)
In-Reply-To: <20050225131917.GA4777@sunsite.mff.cuni.cz>
Hi Jakub,
> 2005-02-25 Jakub Jelinek <jakub@redhat.com>
>
> * readelf.c (get_file_type, get_machine_name, get_osabi_name,
> get_segment_type, get_section_type_name, get_elf_class,
> get_data_encoding, get_group_flags, dynamic_section_mips_val,
> get_symbol_binding, get_symbol_type, get_TAG_name, get_FORM_name,
> get_AT_name, process_mips_specific, process_gnu_liblist,
> get_note_type, get_netbsd_elfcore_note_type): Use snprintf instead of
> sprintf where needed.
> (get_dynamic_type): Likewise. Increase buff to 64 bytes.
> (get_elf_section_flags): Increase buff to 33 bytes. Avoid
> using strcat.
> (get_dynamic_flags): Renamed to...
> (print_dynamic_flags): ... this. Print the flags to stdout instead
> of returning them as string.
> (process_dynamic_section): Adjust caller.
Approved - please apply.
Cheers
Nick
prev parent reply other threads:[~2005-02-28 15:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-25 16:02 Jakub Jelinek
2005-02-28 17:16 ` Nick Clifton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42233A27.2010004@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).