From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14973 invoked by alias); 28 Feb 2005 15:30:05 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 8617 invoked from network); 28 Feb 2005 15:23:36 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 28 Feb 2005 15:23:36 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j1SFNa81020990 for ; Mon, 28 Feb 2005 10:23:36 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j1SFNZK27430; Mon, 28 Feb 2005 10:23:35 -0500 Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j1SFNZJp023670; Mon, 28 Feb 2005 15:23:35 GMT Message-ID: <42233A27.2010004@redhat.com> Date: Mon, 28 Feb 2005 17:16:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Jakub Jelinek CC: binutils@sources.redhat.com Subject: Re: [PATCH] Fix buffer overflows in readelf References: <20050225131917.GA4777@sunsite.mff.cuni.cz> In-Reply-To: <20050225131917.GA4777@sunsite.mff.cuni.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-02/txt/msg00689.txt.bz2 Hi Jakub, > 2005-02-25 Jakub Jelinek > > * readelf.c (get_file_type, get_machine_name, get_osabi_name, > get_segment_type, get_section_type_name, get_elf_class, > get_data_encoding, get_group_flags, dynamic_section_mips_val, > get_symbol_binding, get_symbol_type, get_TAG_name, get_FORM_name, > get_AT_name, process_mips_specific, process_gnu_liblist, > get_note_type, get_netbsd_elfcore_note_type): Use snprintf instead of > sprintf where needed. > (get_dynamic_type): Likewise. Increase buff to 64 bytes. > (get_elf_section_flags): Increase buff to 33 bytes. Avoid > using strcat. > (get_dynamic_flags): Renamed to... > (print_dynamic_flags): ... this. Print the flags to stdout instead > of returning them as string. > (process_dynamic_section): Adjust caller. Approved - please apply. Cheers Nick