From: Nick Clifton <nickc@redhat.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] more ARC opcodes cleanups.
Date: Thu, 03 Mar 2005 14:51:00 -0000 [thread overview]
Message-ID: <4227273A.8090503@redhat.com> (raw)
In-Reply-To: <422705D4.2070005@codito.com>
Hi Ramana,
> These are more small cleanups in the backend for the disassembler for
> ARC. I have just named values given to the decode class as macros and
> used them . Also removed a redundant case in the switch for the
> decodingClass.
>
> Tested as arc-elf32 cross with no regressions on i686-linux
>
> Can I commit this as obvious ?
Sorry no.
There are three problems:
1. You are using a set of #define's for the arithmetic classes, which
is better than the straight constants that were being used before, but
for something like this an enum is the correct way to go.
2. When you add comments, please make sure that they follow the
guidelines for comment format. In this case they should be treated as
full sentences and end with a full stop followed by two spaces before
the */ characters.
3. You appear to be adding in extra blank lines for no really good
reason.
If you would like to fix these issues then you may apply the patch.
Cheers
Nick
next prev parent reply other threads:[~2005-03-03 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-03 12:41 Ramana Radhakrishnan
2005-03-03 14:51 ` Nick Clifton [this message]
2005-03-03 15:32 ` Ramana Radhakrishnan
2005-03-03 15:37 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4227273A.8090503@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sources.redhat.com \
--cc=ramana.radhakrishnan@codito.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).