From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1533 invoked by alias); 3 Mar 2005 14:51:59 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 1020 invoked from network); 3 Mar 2005 14:51:41 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 3 Mar 2005 14:51:41 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j23EpeXv013712 for ; Thu, 3 Mar 2005 09:51:40 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j23EpeK12101; Thu, 3 Mar 2005 09:51:40 -0500 Received: from [172.31.0.98] (vpnuser1.surrey.redhat.com [172.16.9.1]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j23EpdZc028132; Thu, 3 Mar 2005 14:51:39 GMT Message-ID: <4227273A.8090503@redhat.com> Date: Thu, 03 Mar 2005 14:51:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Ramana Radhakrishnan CC: binutils@sources.redhat.com Subject: Re: [PATCH] more ARC opcodes cleanups. References: <422705D4.2070005@codito.com> In-Reply-To: <422705D4.2070005@codito.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00105.txt.bz2 Hi Ramana, > These are more small cleanups in the backend for the disassembler for > ARC. I have just named values given to the decode class as macros and > used them . Also removed a redundant case in the switch for the > decodingClass. > > Tested as arc-elf32 cross with no regressions on i686-linux > > Can I commit this as obvious ? Sorry no. There are three problems: 1. You are using a set of #define's for the arithmetic classes, which is better than the straight constants that were being used before, but for something like this an enum is the correct way to go. 2. When you add comments, please make sure that they follow the guidelines for comment format. In this case they should be treated as full sentences and end with a full stop followed by two spaces before the */ characters. 3. You appear to be adding in extra blank lines for no really good reason. If you would like to fix these issues then you may apply the patch. Cheers Nick