From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id B69113858C41 for ; Mon, 5 Feb 2024 07:32:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B69113858C41 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B69113858C41 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707118350; cv=none; b=WMYXebfHtXqkXMmX2MqJ+NC6p+FxlRWrkpWl3m10UOWeTFcbJ2V4j+OvC+KPC0s601rgVeBHNfaVxkPKOpgp2ue9DfBJDFJL2ZvUHLog1NBMIFFJLLZfJWEU/SqASnkHXlzGMoARLGDaDEK+XMEz6llIezsNVrEAvkCG2USmYCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707118350; c=relaxed/simple; bh=8a7mNomu4KAvp8GdtZl0yZX8OhU+1vQFmQuX6hwpx14=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=j+ulbbDhA8KkOVr2W5NlJ7inBhV0qv2A0XaqqbUXzT2L6RlCDA3nOqF0roCALKdVwgvvksfYVj5U9RzIe2Rte57+1KDJ5Su5ynz3jz7srhvbyyCW/uqu+pdEKV4/k2zudhcFuCEeqcsyxfVmKsgEC8GzYNzIZGacC4AaTWZ0ERQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-40fdd65a9cfso1878625e9.3 for ; Sun, 04 Feb 2024 23:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1707118347; x=1707723147; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=VwWUyodydnS2SwcbL2xONuAyeV/TRb/Pq+foC3tq3Cs=; b=Oz0Plm9AZCZyCHOr5W6ckeHX1Jc/xTHOAfsMUpvqBrbkULuDazMexgrmkxJ89jxfgY +KQUvESDMA7967oyDjYp7W9SLZvIrFyfVoxNrIqOHppPHspiS10c53WHSxi8j27ouS8G lZTIZ0SQTb+UZglioDtqZoUj3nuSTsjSrvZr2K2r/qMgs6pm58Sgxl8P68h+UOH6g6UW C7fX7qLzNZsZ4xRtUJqpw3za+/g9corLDKHjpNiMefJUwL6PX1I2Zd4UBSZzXKqMDPia ts9k+Fui7l66lZHhGwpnyG3wSLyVSAC48QLAGOeCXKpvZu6YyF8lsOVbP/vmPqpH1NeH FlaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707118347; x=1707723147; h=content-transfer-encoding:in-reply-to:autocrypt:from:cc :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VwWUyodydnS2SwcbL2xONuAyeV/TRb/Pq+foC3tq3Cs=; b=IUWUL6BpXxWgm5xzOIffR90kl115xjslKAliY5Ig7POncr/5am4eIdcClApoZiMdZB JAGcsubJSfLpvryIP9Fv/clBRQwgfMbjbl8Tvtp5WaauTYszke/+qtZSxMAL/LFF/vV9 rvXZew5i7S/OLgmKqq8e+49ChVJ+Fn6fg4gm3wseePyrLPeCNG49sYN+5iW1YyP2A+rT s3jcK9fALkpeI3iQFS5/9edU4BgNj+yZ8rfmz2kDwfNO8sj85LBFTmzVFjCYzJljxBB5 igHHdEmrRHy36QiSmASu+teE4EYWxkgqCWJX8GIkAXkG3xmttjoaHa4mPcSnhubPoV6d jKVg== X-Gm-Message-State: AOJu0YyuFOQCAICfhHqG7Dn14L5b/SaVCewUtRAAlmJ8R2W+nplcnQu2 Mo3b3IDvehBZe1G9aDpYV6YM5vX/Vf/ZnY8fm2lRxRuuFHoQSl0Afr8ubvSbAE0HO3Jh+jAr6x8 = X-Google-Smtp-Source: AGHT+IGopIA0rvngE1vsbBOlKmu9FB7n/NQ8epQrJH9XLjx7PzkBRTUfvB6DBYIev5smtn4hCQHH4g== X-Received: by 2002:a05:600c:524d:b0:40e:d1f0:4c6f with SMTP id fc13-20020a05600c524d00b0040ed1f04c6fmr4232390wmb.17.1707118347480; Sun, 04 Feb 2024 23:32:27 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id f15-20020a05600c154f00b0040fc771c864sm7655262wmg.14.2024.02.04.23.32.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Feb 2024 23:32:27 -0800 (PST) Message-ID: <4227b81e-5a62-49fd-a811-0515ea6000e8@suse.com> Date: Mon, 5 Feb 2024 08:32:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gas: scfi: fix failing test on Solaris2 To: Indu Bhagat References: <20240202232542.2282432-1-indu.bhagat@oracle.com> Content-Language: en-US Cc: binutils@sourceware.org From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20240202232542.2282432-1-indu.bhagat@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3025.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03.02.2024 00:25, Indu Bhagat wrote: > It has been observed that the run of scfi-unsupported-1 test with --x32 > arg on a Solaris2 x86_64 system fails: > > Executing on host: sh -c {../as-new --x32 --scfi=experimental <...>/scfi-unsupported-1.s 2>&1} /dev/null dump.out (timeout = 300) > spawn [open ...] > Assembler messages: > Fatal error: no compiled in support for 32bit x86_64 > regexp_diff match failure > regexp "^Fatal error: SCFI is not supported for this ABI$" > line "Fatal error: no compiled in support for 32bit x86_64" > FAIL: x86_64 scfi-unsupported-1 > > Fix the above by adding a check for --x32 support before running the > test. While okay as-is for the purpose at hand, I still have two questions: > --- a/gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp > +++ b/gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp > @@ -14,6 +14,14 @@ > # along with this program; if not, write to the Free Software > # Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA. > > +proc gas_x32_check { } { > + global NM > + global NMFLAGS > + > + set status [gas_host_run "$NM $NMFLAGS --help" ""] > + return [regexp "targets:.*elf32-x86-64" [lindex $status 1]]; > +} > + > if { ![is_elf_format] } then { > return > } > @@ -40,8 +48,11 @@ if { ([istarget "x86_64-*-*"] && ![istarget "x86_64-*-linux*-gnux32"]) } then { > run_list_test "scfi-fp-diag-2" "--scfi=experimental" > run_list_test "scfi-diag-2" "--scfi=experimental" > > + if { [gas_x32_check] } then { > + run_list_test "scfi-unsupported-1" "--x32 --scfi=experimental" > + } > run_list_test "scfi-unsupported-1" "--32 --scfi=experimental" Did it occur to you that this would better also be wrapped in a similar check, seeing that gas/i386/x86-64.exp also uses such a conditional? > - run_list_test "scfi-unsupported-1" "--x32 --scfi=experimental" While minor, I'm also curious about the reason for this re-ordering. Jan