From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31159 invoked by alias); 9 Mar 2005 12:41:20 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 31069 invoked from network); 9 Mar 2005 12:41:14 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org with SMTP; 9 Mar 2005 12:41:14 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j29CfEqU004479 for ; Wed, 9 Mar 2005 07:41:14 -0500 Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j29Cf8n07494; Wed, 9 Mar 2005 07:41:08 -0500 Received: from [172.31.0.98] (vpnuser4.surrey.redhat.com [172.16.9.4]) by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j29Cf3pa028006; Wed, 9 Mar 2005 12:41:05 GMT Message-ID: <422EF1B4.4040104@redhat.com> Date: Wed, 09 Mar 2005 12:41:00 -0000 From: Nick Clifton User-Agent: Mozilla Thunderbird 1.0 (X11/20041206) MIME-Version: 1.0 To: Ben Elliston CC: binutils@sources.redhat.com Subject: Re: PATCH: speed up ar(1) References: <422CE744.7070409@au.ibm.com> In-Reply-To: <422CE744.7070409@au.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00268.txt.bz2 Hi Ben, > The following patch alters the ar cache representation from a singly linked list to a > hash table using the hashtab implementation from libiberty. When archiving files > with thousands of archive members (eg. libjava), this patch results in a 15-25% > performance improvement. > > Tested with an --enable-targets=all build, make check-binutils and a byte-wise > comparison of the libjava libraries built with and without a patched ar. > > Okay to commit? [Tut tut - no ChangeLog entry...] Approved for the mainline, but not the 2.16 branch. Cheers Nick