* [PATCH] VAX: produce valid assembler when disassembling function mask
@ 2005-03-11 22:30 Jan-Benedict Glaw
2005-03-14 9:35 ` Nick Clifton
0 siblings, 1 reply; 3+ messages in thread
From: Jan-Benedict Glaw @ 2005-03-11 22:30 UTC (permalink / raw)
To: binutils
Hi!
When I introduced decoding of VAXens function entry mask some days
ago, I missed to let the output look like assembler. Using .word
and a comment was suggested by Kenn Humborg and I think it's a good
idea.
2005-03-11 Jan-Benedict Glaw <jbglaw@lug-owl.de>
* vax-dis.c: Fix spelling error
(print_insn_vax): Use ".word 0x0012 # Entry mask: r1 r2 >" instead
of just "Entry mask: < r1 ... >"
diff -Nurp ../cvs-repos/binutils/binutils-upstream-HEAD/opcodes/vax-dis.c src/opcodes/vax-dis.c
--- ../cvs-repos/binutils/binutils-upstream-HEAD/opcodes/vax-dis.c 2005-03-09 15:16:46.000000000 +0100
+++ src/opcodes/vax-dis.c 2005-03-11 23:29:01.000000000 +0100
@@ -39,7 +39,7 @@ static char *reg_names[] =
static char *entry_mask_bit[] =
{
/* Registers 0 and 1 shall not be saved, since they're used to pass back
- a function's result to it's caller... */
+ a function's result to its caller... */
"~r0~", "~r1~",
/* Registers 2 .. 11 are normal registers. */
"r2", "r3", "r4", "r5", "r6", "r7", "r8", "r9", "r10", "r11",
@@ -165,7 +165,7 @@ print_insn_vax (memaddr, info)
int i = 0;
int register_mask = buffer[1] << 8 | buffer[0];
- (*info->fprintf_func) (info->stream, "Entry mask 0x%04x = <",
+ (*info->fprintf_func) (info->stream, ".word 0x%04x # Entry mask: <",
register_mask);
for (i = 15; i >= 0; i--)
MfG, JBG
--
AWEK microdata GmbH -- Am Wellbach 4 -- 33609 Bielefeld
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VAX: produce valid assembler when disassembling function mask
2005-03-11 22:30 [PATCH] VAX: produce valid assembler when disassembling function mask Jan-Benedict Glaw
@ 2005-03-14 9:35 ` Nick Clifton
2005-03-14 9:48 ` Jan-Benedict Glaw
0 siblings, 1 reply; 3+ messages in thread
From: Nick Clifton @ 2005-03-14 9:35 UTC (permalink / raw)
To: Jan-Benedict Glaw; +Cc: binutils
Hi Jan-Benedict,
> When I introduced decoding of VAXens function entry mask some days
> ago, I missed to let the output look like assembler. Using .word
> and a comment was suggested by Kenn Humborg and I think it's a good
> idea.
>
> 2005-03-11 Jan-Benedict Glaw <jbglaw@lug-owl.de>
>
> * vax-dis.c: Fix spelling error
> (print_insn_vax): Use ".word 0x0012 # Entry mask: r1 r2 >" instead
> of just "Entry mask: < r1 ... >"
Approved and applied. Although to be fair I think that you ought to
have credited Kenn Humborg in the ChangeLog entry as well.
Cheers
Nick
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] VAX: produce valid assembler when disassembling function mask
2005-03-14 9:35 ` Nick Clifton
@ 2005-03-14 9:48 ` Jan-Benedict Glaw
0 siblings, 0 replies; 3+ messages in thread
From: Jan-Benedict Glaw @ 2005-03-14 9:48 UTC (permalink / raw)
To: Nick Clifton; +Cc: binutils
On Mon, Mar 14, 2005 at 09:47:59AM +0000, Nick Clifton wrote:
> > When I introduced decoding of VAXens function entry mask some days
> > ago, I missed to let the output look like assembler. Using .word
> > and a comment was suggested by Kenn Humborg and I think it's a good
> > idea.
> >
> > 2005-03-11 Jan-Benedict Glaw <jbglaw@lug-owl.de>
> >
> > * vax-dis.c: Fix spelling error
> > (print_insn_vax): Use ".word 0x0012 # Entry mask: r1 r2 >" instead
> > of just "Entry mask: < r1 ... >"
>
> Approved and applied. Although to be fair I think that you ought to
> have credited Kenn Humborg in the ChangeLog entry as well.
You're probably right, I'll do that subsequently if it happens again.
Now I'll go on and look for the next things to fix...
MfG, JBG
--
AWEK microdata GmbH -- Am Wellbach 4 -- 33609 Bielefeld
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-03-14 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-03-11 22:30 [PATCH] VAX: produce valid assembler when disassembling function mask Jan-Benedict Glaw
2005-03-14 9:35 ` Nick Clifton
2005-03-14 9:48 ` Jan-Benedict Glaw
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).