From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id 512A63858D28 for ; Wed, 9 Nov 2022 19:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 512A63858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2A9JCdot003504; Wed, 9 Nov 2022 19:24:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : references : from : cc : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=fYQB44dkOb58Xt7NhgKIXIvSuJx/SgQaDvjcN7R8tEY=; b=Xnut7W2Xji/IBKMEOSI6twDAJgHdqLw+pnLnglgrL8sEEigbyJyhUYond36CIcbecucC UnDreHna15uRrS0O/YYweMUVwDaW2hrckXxpt0CScBXId9ncdbFs9wYJfkGbold/npgi 0xoyusxKvB0mIgz8yBxEZ6tvh2WWFxv2gi8mS8pIt1gdZIZYXq9053vp3AaxKFV93Iq2 vzjAZGmmNc0Z4+Qj2OTzDu7qJd30r6RVILbLiQpofKGxC3TURNxsoiwV+ugIlfauZt5C OMEbYBrgm2jbqP9pSm9TJCR5Kh/6C75Agx0/ewmioqxJs+XwYx2LTNonIXVGJm4KQvuM NA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3krj5qr01s-90 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Nov 2022 19:24:28 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2A9HeUo1019155; Wed, 9 Nov 2022 18:50:46 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2103.outbound.protection.outlook.com [104.47.70.103]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3kpctna3r1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 09 Nov 2022 18:50:46 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fW1OV/PYR8ApMgrTlRd5CPnNCx9vbZlujIcexRARB2bgBQtkLbJYzjAjoiMGdQkFZY4Wwd+ZUxrcVOL35oAardBk03RQmnJ48PtgKanLVB9ssW++9sTi8sFg8JfmVC7JdFDqcShAR7ymMRnWBXN2eWLhIMDb9rnoSzlWuNA5x94FKjYiakkAu9XdWIwtn8B6m8/+jEYtfAYFu56PtdK62HyomXOeXtRy5EfH1BS/ex5YrDEBP/5jHuuheloYURWnjMGa0QgIxHZOCnVT+jUyYPKfut8u7MnJr711i/IIcRMZF2hMMK01cw6KZ5T7sfHjnOwGYjJdpMd2q3LvDqHqMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fYQB44dkOb58Xt7NhgKIXIvSuJx/SgQaDvjcN7R8tEY=; b=CggMpIHhwIn+mpBPPbiZbaHDN/KLObdTjddXbr0DWrCEQEUdHyaIhO/dHJHYydFW7Fr7Xib7fDVSKJF1CovrSVVCu9bHWasgB8yFgIMOrR1PVrrnOGE1dOGt6xQar+KM/8ZNZQ+L4empg2S6YY/ke2rHJM2wKZ1CnOvue/d4iib0iD0TcGLicHq2tOYCTHoqrJoaomNF/8V5bkrAGREoZmv7GQkZ0IBTCsazyUq02zjcMPhHzUNrytJMXmf7BdxqM2gz/A+GN+8vYqku1G1J3UfELeU2WadA/mGUT7O4sfl9eOUcqe3NlrnwXwHwaOF58av7TvZ0p+vjwsM0OKidMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fYQB44dkOb58Xt7NhgKIXIvSuJx/SgQaDvjcN7R8tEY=; b=w+2Nrigwq43+hsb9ZxllofX5o7hz14oHp1nZJXzXVTlQQuXlNuOXHHAIT8LNWfAD280Nb6E6pyu657iVlZRuhJbz0tkC+L9+Z4KyzXDjD3B0KhKFbpQBCVsWTVmcwq1oUHkgCepU69cGllaQQh0UYBnn0dCLXm7QIT3JmzM3aUM= Received: from SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) by PH0PR10MB4677.namprd10.prod.outlook.com (2603:10b6:510:3d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 18:50:44 +0000 Received: from SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a491:8dcb:1259:9aff]) by SA2PR10MB4636.namprd10.prod.outlook.com ([fe80::a491:8dcb:1259:9aff%3]) with mapi id 15.20.5791.027; Wed, 9 Nov 2022 18:50:44 +0000 Message-ID: <423e14f9-6176-230f-aee3-83ce59fd4d7c@oracle.com> Date: Wed, 9 Nov 2022 10:50:42 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: gprofng patch to review Content-Language: en-US To: markus.t.metzger@intel.com, "binutils@sourceware.org" References: <603d55a9-e789-11e7-2cf0-1fde08874cdf@oracle.com> From: Vladimir Mezentsev Cc: Kurt Goebel In-Reply-To: <603d55a9-e789-11e7-2cf0-1fde08874cdf@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN4PR0501CA0057.namprd05.prod.outlook.com (2603:10b6:803:41::34) To SA2PR10MB4636.namprd10.prod.outlook.com (2603:10b6:806:11e::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SA2PR10MB4636:EE_|PH0PR10MB4677:EE_ X-MS-Office365-Filtering-Correlation-Id: c74ddecb-f65f-4ec2-634a-08dac2834ea5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xt8xUNiHuWzxeQWor5vwM833v7PKYEQnjEYvjYL7QfHlrXlueayGAbdSv/OJo05M74ay+ohVqAp3b1YWC3o/ePNlvKKMkvA2V5DVPiY1C7x/xZG8p2lMiKPlbB3wWiN2VhYOers5E4oVoxDYH153NeNDhHNyent16EdAF4L2JY8CPtPG3Vmc06H3tAE6zfF/4FX4F8R3D21Ifx+NKnjOe2XWwYOFLToj5AXjBdJ4931cfSFPdXchtgPFTaApIVbZLWuiSSwfwkH9abDTRObl2BRBqNsJKON8e1DKOHqbOc8PdmCp7Kt1SxbMTNUtDhCX1PKVz0HWmT+73bxBd45g3eMYT2zSQvDfFeQvPVT+ry9/5rHjuTV1+x7I8damp6/cHSRPDWMuuybbbz8s3rjkQVDQwNVK+OwWYPviqFxKsDHcgMkZeLnKmJosk2fTQkm8vDBCyvn5K7c6SVvAwcddz3NC354P3lO0jNd4tBJFHXWSYrfsmYRDPlk5etkM49kll5zk24GzZdLh2CiYPw8JQosZAZPL5R9ofTfa+70grvYOmX54/MRC2mGTwla1uw0eXu4Pjm+9uyM6H0C78o6yQPQF4QwqhFdt5DPE2mNUjfmUGPXMA4FAljhA51FRoo1jZP32M/p6YePxeSU5+tA1WCB4V4OJN3HMc35yAT8tuWI2rvaxSwbMigU1lbVzTulUe/AqrwwAvXOltK3gSCyvFITEhzIO4/x0vdjXgjDfa1yvylakYLgWxBVr/bBkdkQq/p8Gbi62B77UoULnGGvnUHmEuWk1XsdhvjjHek37QvFzM885G4zY20bDJRqItV2p X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SA2PR10MB4636.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(39860400002)(396003)(376002)(346002)(451199015)(31696002)(36756003)(86362001)(84970400001)(4326008)(2906002)(186003)(44832011)(5660300002)(3480700007)(2616005)(83380400001)(53546011)(6506007)(38100700002)(66476007)(66946007)(316002)(66556008)(6486002)(31686004)(6512007)(966005)(6916009)(8936002)(41300700001)(478600001)(8676002)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TkRTc0RjTTRWN21QMmhabDAxOHE4MktJR1RhVXR3OHAyNUdydE5TKzAyVkFS?= =?utf-8?B?Uk9yRlpoandHaXZPVWFhamtCK3ZaTlAvMkdTc1Q5U0J5azhEcGhmMlVsUGlS?= =?utf-8?B?NTRHN0w2RnJNTlZTaDIxNWRZT1VRUmlIYkRGQVdNdFVCTlU2V0hWWE5uaytN?= =?utf-8?B?WnpNU2p5cisvU1RXQnJ1aERocXpiQlFFVXhud2hUNzRlTFFuV1ZNT2d4SzFh?= =?utf-8?B?RllGaXc2a0p6ZW1LTlZ4RExOWjU1dER0ek5ZWXQzUEpVZjdWMUU3UXpFSHJN?= =?utf-8?B?ZWt0ekUwT0EvUjVZSW9CNHNHbk9GcTFNS3BSeE51b2cwY1l5ak4vUi9Idytn?= =?utf-8?B?K2xQMCt3NmgxVVI4SndyTVFVb0sveEhIdnprOS9rQkdOUkV5aGQzUHFGampi?= =?utf-8?B?MEY3bktuWjVzbWprVjdreW1wazRyVlYwb2U1NzN2eHBsUlgrUnZsQ1k4Z3VW?= =?utf-8?B?a29nZVM5SGt0VWh2R1c0RUREMXBISjRTaXJsd3dTbW14MURDS2lEc1RwZldP?= =?utf-8?B?UWxtbytYQWpsVE9ESDNMbWtoWlh5T0xQbXVnUmt4Q3pwZXBLVFJLc0xPSW1L?= =?utf-8?B?Tm5VME51WndaYXFlVVdpWlhEd2l2dmppQklHNzZjNEZ3ckRhKzMzODAzYkV0?= =?utf-8?B?eFNMR1A2S1FWbndBYnlDeTdYeE1vZm1WZEdkNDJuZC9idmkzTUVsSk45V1Z0?= =?utf-8?B?R0RKR1dUVzFpWGRsYVl5enAvKzM2b3dIdzE2Rkx2MWVJVTNGMWx6Vlg2Nkp6?= =?utf-8?B?eTlCem1XdUdyWTNibW1weE1VSS9JWkdKNjgwZ2tMY2ZldVNwZDdPek9Rb0p1?= =?utf-8?B?MEhOV3hzZkJ2aXRXeE1UcHdLYmM5MWFVazcyamI4Vm9LVEhGWXhwSXZYWUJP?= =?utf-8?B?OHUvbEVSaWdabVVUZytiRFVXYkxDaDVMSEJIY2JETFRrQTlzaFQ2Nkh6WUVH?= =?utf-8?B?KzJTcnRnMGtISURTOUVwL2FmbFNmZ29wMXV3ZmdURTdvWVc0ZGhEUEhnaWNk?= =?utf-8?B?UUhTdUJXZGl5Vkg4N0h4YUJJVUNZempsVkpialNSTGRGdU1pQ0ZBY3p6YjhU?= =?utf-8?B?bWMxQ3o2VFFpS08wbmhCeWhyWUJhb055aFdDMjY0ODJodkYwa240Y25UWWJu?= =?utf-8?B?eHYrT1lUd1VHNlpLZ282WElmS0pXbjkyMEFEb1Nmbk5BOEJUd2UwK2RCNU5n?= =?utf-8?B?T25aSjdVZlFqWjhBek52V2paUmIyYVJVRDZmdlFsQVJoY1l3aDVacmJPUHRW?= =?utf-8?B?U0RkVmNRbmIxd0RCNWlaa2htZGRROExKZHk2K2FrSmZ6SGtFWGlCMlRNbXlm?= =?utf-8?B?bDBwaExMMnNCMEVENktSQ2Z0WVFGb0ZXY0w5ZEl5VjlZVUlBZFNnandUZWtX?= =?utf-8?B?VFNEUVpGY0hZcXhMZ2RHSUJxZnFwUEp1Rjd0MnNZT0hMQVZRbjBzK3VKNFBw?= =?utf-8?B?Tklsc2J1NkgzdVBVbFRXd0huNXNvQ1FJN1BNTURvdFJIMXZEaUhkTWJuMDlH?= =?utf-8?B?ekRQUzdjZVRLeUlwMkttQ2c4MVpBMXpHamlNdHFTbW9QY1BlUUVVcWRGY0Yz?= =?utf-8?B?Uk85bWhIeFRyaEJic1N5RlFNY0tjSEpmYlZ0QVRNV2ZFRTRzZ3JwMFBuekRW?= =?utf-8?B?TnhkN1AxK0UzY1dPZnpmaWhCSGtKZjZ5SnhJT2VRdHRhdURvVkhmaW16WWN4?= =?utf-8?B?MlJUMlRXaGxrVFZyV1BnaVFBS2hQT3IxODY5NTk2SXQ0UjRmckxuSkN6ejI4?= =?utf-8?B?UjhZd2U1U1FqZGxwNTJTOUVJaWoxUSs1TVg1Ym1vNFhnd3NLb2lxa3l6T05a?= =?utf-8?B?UFdPblpyekFZQi9GeFd1UUhmWmF2Y1VFckh0OGQ4YXJqR3ZqSkRkR2h5cTRX?= =?utf-8?B?QVBTMG9FcSs4c0phdDJLTkR5UHdDZUt5U2o0Z3ZXTVZrVjMrWFYxQ1F6Mkxw?= =?utf-8?B?cjMxTVd1RzJRT0ZPT1o3dU80OERjS0VjUDYxYnZuclZXTG5vNzdsR0hOclh2?= =?utf-8?B?b01GbmluWVNJcGpKUHFnZDZRbmVEM2Y5UkVIcnRVcjZpQjcwWkF1WjR1YUdO?= =?utf-8?B?UHVPcXdCcFZMR0ZQc0xtTzNtK01GOFdNajZLemJ6aGR4d3ByTU5nRWc5Lzg1?= =?utf-8?B?dUhxQ1ozWHFTeGdSbjFWY2hqUko2RUJ5eXJKcm4xcnAwbGtiUTBMTEM3cjUv?= =?utf-8?Q?q0gTmxvvbRhcbaUdPRwb3m4=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c74ddecb-f65f-4ec2-634a-08dac2834ea5 X-MS-Exchange-CrossTenant-AuthSource: SA2PR10MB4636.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 18:50:44.4187 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: p/RJfaXNxiXKq5BrYjbOzF7D5gV/hqePMtN8JcHpoVodvR/+Bzfi400bAWQqTeSUNIykfR969t7IeHTna+HjSptn5jMkuwNgUqF+/Hlqpk0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4677 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-11-09_06,2022-11-09_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2211090142 X-Proofpoint-GUID: -4mQmOly9-O6w52ggS1YpU-aB4EsTJe- X-Proofpoint-ORIG-GUID: -4mQmOly9-O6w52ggS1YpU-aB4EsTJe- X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/9/22 07:00, Kurt Goebel wrote: > > > https://sourceware.org/pipermail/binutils/2022-November/124238.html Hi Markus, It looks like you sent patch for review to the gdb alias. I am only in binutils@sourceware.org. See my comments below. [PATCH 1/2] gprofng: make cpu identification available to others Markus Metzger markus.t.metzger@intel.com Tue Nov 8 05:45:29 GMT 2022 Previous message (by thread): [PATCH] x86: Correct wrong comments in vex_w_table Next message (by thread): [PATCH 2/2] gdb, btrace: use cpuident.h to implement btrace_this_cpu Messages sorted by: [ date ] [ thread ] [ subject ] [ author ] I ran gprofng.display/display.exp on Fedora 36 x86-64 and I got     UNSUPPORTED: jsynprog It is expected. You built gprofng without java profiling support.     ERROR: comparison of results in mttest failed     UNRESOLVED: mttest     ERROR: comparison of results in mttest failed     UNRESOLVED: mttest     PASS: synprog     PASS: synprog Usually, when synprog passes and mttest fails, it means that pthread_create interposition is broken in libgp-collector.so. In any case, it is not result of your patch. I never run gprofng on Fedora 36. Please create a bug against gprofng and describe how you configure your build. with and without this patch. ---  gprofng/common/hwcdrv.c                      |  2 +-  gprofng/common/cpuid.c => include/cpuident.h | 17 +++++++++++++----  2 files changed, 14 insertions(+), 5 deletions(-)  rename gprofng/common/cpuid.c => include/cpuident.h (96%) diff --git a/gprofng/common/hwcdrv.c b/gprofng/common/hwcdrv.c index 03c3a71c8e2..115638aa623 100644 --- a/gprofng/common/hwcdrv.c +++ b/gprofng/common/hwcdrv.c @@ -32,7 +32,7 @@  /* macros */  #define IS_GLOBAL /* Mark global symbols */ -#include "cpuid.c" /* ftns for identifying a chip */ +#include "cpuident.h" /* ftns for identifying a chip */  static hdrv_pcbe_api_t hdrv_pcbe_core_api;  static hdrv_pcbe_api_t hdrv_pcbe_opteron_api; diff --git a/gprofng/common/cpuid.c b/include/cpuident.h similarity index 96% rename from gprofng/common/cpuid.c rename to include/cpuident.h index 211e09aa8ac..7ab6fc1f2b1 100644 --- a/gprofng/common/cpuid.c +++ b/include/cpuident.h @@ -18,6 +18,11 @@     Foundation, 51 Franklin Street - Fifth Floor, Boston,     MA 02110-1301, USA.  */ +#ifndef _CPUIDENT_H +#define _CPUIDENT_H + +#include +  #if defined(__i386__) || defined(__x86_64)  #include   /* GCC-provided */  #elif defined(__aarch64__) @@ -85,7 +90,7 @@ typedef struct  #if defined(__i386__) || defined(__x86_64) -static uint_t +static unsigned int  cpuid_vendorstr_to_vendorcode (char *vendorstr)  {    if (strcmp (vendorstr, X86_VENDORSTR_Intel) == 0) @@ -101,8 +106,10 @@ my_cpuid (unsigned int op, cpuid_regs_t *regs)  {    regs->eax = regs->ebx = regs->ecx = regs->edx = 0;    int ret = __get_cpuid (op, ®s->eax, ®s->ebx, ®s->ecx, ®s->edx); +#ifdef DBG_LT1    TprintfT (DBG_LT1, "my_cpuid: __get_cpuid(0x%x, 0x%x, 0x%x, 0x%x, 0x%x) returns %d\n",          op, regs->eax, regs->ebx, regs->ecx, regs->edx, ret); +#endif I suggest to just remove TprintfT. This debug output is currently not used by anyone. Thanks for fixing this, and please check it in. -Vladimir    return ret;  }  #endif @@ -184,20 +191,22 @@ get_cpuid_info ()    return cpi;  } -static inline uint_t +static inline unsigned int  cpuid_getvendor ()  {    return get_cpuid_info ()->cpi_vendor;  } -static inline uint_t +static inline unsigned int  cpuid_getfamily ()  {    return get_cpuid_info ()->cpi_family;  } -static inline uint_t +static inline unsigned int  cpuid_getmodel ()  {    return get_cpuid_info ()->cpi_model;  } + +#endif /* _CPUIDENT_H */ -- 2.37.3