From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <binutils-return-39013-listarch-binutils=sources.redhat.com@sources.redhat.com>
Received: (qmail 17546 invoked by alias); 22 Mar 2005 16:34:24 -0000
Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:binutils-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/binutils/>
List-Post: <mailto:binutils@sources.redhat.com>
List-Help: <mailto:binutils-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: binutils-owner@sources.redhat.com
Received: (qmail 17536 invoked from network); 22 Mar 2005 16:34:19 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 22 Mar 2005 16:34:19 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id j2MGYJLI025836
	for <binutils@sources.redhat.com>; Tue, 22 Mar 2005 11:34:19 -0500
Received: from pobox.surrey.redhat.com (pobox.surrey.redhat.com [172.16.10.17])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id j2MGYIO23810;
	Tue, 22 Mar 2005 11:34:18 -0500
Received: from [172.31.0.98] (vpnuser8.surrey.redhat.com [172.16.9.8])
	by pobox.surrey.redhat.com (8.12.8/8.12.8) with ESMTP id j2MGYHBW004881;
	Tue, 22 Mar 2005 16:34:17 GMT
Message-ID: <42404C18.5000007@redhat.com>
Date: Tue, 22 Mar 2005 17:08:00 -0000
From: Nick Clifton <nickc@redhat.com>
User-Agent: Mozilla Thunderbird 1.0 (X11/20041206)
MIME-Version: 1.0
To: Richard Sandiford <rsandifo@redhat.com>
CC: Daniel Jacobowitz <drow@false.org>, binutils@sources.redhat.com
Subject: Re: Binutils builds broken with -Werror
References: <20050316201339.GA17575@nevyn.them.org>	<423E89B0.6000901@redhat.com> <wvnu0n56z8a.fsf@talisman.cambridge.redhat.com>
In-Reply-To: <wvnu0n56z8a.fsf@talisman.cambridge.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2005-03/txt/msg00663.txt.bz2

Hi Richard,

>>+ # Disable -Werror, if it has been enabled, when building generated C
>>source
>>+ # files since old versions of bison & yacc will produce working code which
>>+ # contain compile time warnings.
>>+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
>>+ $(GENERATED_OFILES):
>>+ 	$(COMPILE) -c `basename $@ .o`.c -Wno-error

> I don't think you should hard-code -Wno-error like this.  Isn't binutils
> supposed to buildable with non-gcc compilers?  (And it does build with
> MIPSpro FWIW, or at least it did recently.)

Poo.  Well we can rely upon using a GNU-like make program, right ?  So 
how about this version then ?

Cheers
   Nick

Index: binutils/Makefile.am
===================================================================
RCS file: /cvs/src/src/binutils/Makefile.am,v
retrieving revision 1.55
diff -c -3 -p -r1.55 Makefile.am
*** binutils/Makefile.am	22 Feb 2005 12:57:26 -0000	1.55
--- binutils/Makefile.am	22 Mar 2005 16:32:05 -0000
*************** GENERATED_CFILES = \
*** 101,106 ****
--- 101,114 ----
   	arparse.c arlex.c sysroff.c sysinfo.c syslex.c \
   	defparse.c deflex.c nlmheader.c rcparse.c rclex.c

+ # Disable -Werror, if it has been enabled, when building generated C 
source
+ # files since old versions of bison & yacc will produce working code which
+ # contain compile time warnings.
+ GENERATED_OFILES := $(GENERATED_CFILES:.c=.o)
+ NO_WERROR_COMPILE = $(subst Werror,Wno-error,$(COMPILE))
+ $(GENERATED_OFILES):
+ 	$(NO_WERROR_COMPILE) -c `basename $@ .o`.c
+
   DEBUG_SRCS = rddbg.c debug.c stabs.c ieee.c rdcoff.c
   WRITE_DEBUG_SRCS = $(DEBUG_SRCS) wrstabs.c