public inbox for binutils@sourceware.org
 help / color / mirror / Atom feed
From: "Aaron W. LaFramboise" <aaron98wiridge9@aaronwl.com>
To: binutils <binutils@sources.redhat.com>
Cc: dannysmith@users.sourceforge.net
Subject: PATCH Fix objdump.c warning
Date: Fri, 25 Mar 2005 16:45:00 -0000	[thread overview]
Message-ID: <424382EE.4060309@aaronwl.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1058 bytes --]

On Windows, I get this error on build with GCC 3.4.3.

gcc -DHAVE_CONFIG_H -I.
-I/aaronwl/cs/compilers/binutils/src/cvs/src/binutils -I
. -D_GNU_SOURCE -I.
-I/aaronwl/cs/compilers/binutils/src/cvs/src/binutils -I../b
fd -I/aaronwl/cs/compilers/binutils/src/cvs/src/binutils/../bfd
-I/aaronwl/cs/co
mpilers/binutils/src/cvs/src/binutils/../include -D__USE_MINGW_FSEEK
-I/aaronwl/
cs/compilers/binutils/src/cvs/src/binutils/../intl -I../intl
-DLOCALEDIR="\"/aar
onwl/cs/env/mingw-head/20040323/share/locale\""
-Dbin_dummy_emulation=bin_vanill
a_emulation   -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Werror
-g -O2
-c  /aaronwl/cs/compilers/binutils/src/cvs/src/binutils/objdump.c
/aaronwl/cs/compilers/binutils/src/cvs/src/binutils/objdump.c: In
function `disa
ssemble_bytes':
/aaronwl/cs/compilers/binutils/src/cvs/src/binutils/objdump.c:1379:
warning: der
eferencing type-punned pointer will break strict-aliasing rules
make[4]: *** [objdump.o] Error 1


The warning appears to be spurious, but just removing the unneeded cast
makes it go away.  OK?

[-- Attachment #2: binutils-head-20050324-sfile.patch --]
[-- Type: text/plain, Size: 941 bytes --]

2005-03-24  Aaron W. LaFramboise <aaron98wiridge9@aaronwl.com>

	* objdump.c (disassemble_bytes): Remove cast.

Index: objdump.c
===================================================================
RCS file: /cvs/src/src/binutils/objdump.c,v
retrieving revision 1.102
diff -c -3 -p -r1.102 objdump.c
*** objdump.c	18 Mar 2005 16:28:13 -0000	1.102
--- objdump.c	25 Mar 2005 00:31:21 -0000
*************** disassemble_bytes (struct disassemble_in
*** 1376,1382 ****
  	    {
  	      sfile.pos = 0;
  	      info->fprintf_func = (fprintf_ftype) objdump_sprintf;
! 	      info->stream = (FILE *) &sfile;
  	      info->bytes_per_line = 0;
  	      info->bytes_per_chunk = 0;
  	      info->flags = 0;
--- 1376,1382 ----
  	    {
  	      sfile.pos = 0;
  	      info->fprintf_func = (fprintf_ftype) objdump_sprintf;
! 	      info->stream = &sfile;
  	      info->bytes_per_line = 0;
  	      info->bytes_per_chunk = 0;
  	      info->flags = 0;

             reply	other threads:[~2005-03-25  3:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-25 16:45 Aaron W. LaFramboise [this message]
2005-03-28 22:52 ` Alan Modra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=424382EE.4060309@aaronwl.com \
    --to=aaron98wiridge9@aaronwl.com \
    --cc=binutils@sources.redhat.com \
    --cc=dannysmith@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).