From: Julian Brown <julian@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: binutils@sources.redhat.com
Subject: Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols
Date: Mon, 28 Mar 2005 10:36:00 -0000 [thread overview]
Message-ID: <42474857.7070100@codesourcery.com> (raw)
In-Reply-To: <20050327213906.GA30870@nevyn.them.org>
Daniel Jacobowitz wrote:
> On Sun, Mar 27, 2005 at 09:25:49PM +0100, Julian Brown wrote:
>
>>In the interest of preserving existing behaviour, I have fixed this by
>>adding a new disassemble_info hook which allows the symbol table used
>>for disassembly to have a target-specific hook for altering each symbol
>>(or remove it) in the remove_useless_symbols function. This sets the
>>BSF_FUNCTION flag for mapping symbols, which makes things behave the way
>>they used to, and possibly provides useful functionality for other
>>platforms as well.
>
> How about checking bfd_is_target_special_symbol in remove_useless_syms?
To remove the mapping symbols altogether? That would make sense, but the
output of objdump would still be altered then -- my patch doesn't
actually remove the mapping symbols in remove_useless_symbols, just
munges their type. This was the best way I could come up with to
preserve existing behaviour without affecting other platforms, but I
suspect it might be trying too hard (it is "only" disassembled output
which is affected, presumably meant for human consumption).
Julian
next prev parent reply other threads:[~2005-03-27 22:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-28 8:41 Julian Brown
2005-03-28 10:17 ` Daniel Jacobowitz
2005-03-28 10:36 ` Julian Brown [this message]
2005-03-29 16:54 ` Richard Earnshaw
2005-03-29 17:25 ` Daniel Jacobowitz
2005-03-30 15:31 ` Julian Brown
2005-03-30 17:05 ` Richard Earnshaw
2005-03-30 21:08 ` Paul Brook
2005-03-30 21:11 ` Julian Brown
2005-03-31 0:27 ` Richard Earnshaw
2005-03-31 0:34 ` Julian Brown
2005-03-31 0:58 ` Richard Earnshaw
2005-03-31 2:17 ` Julian Brown
2005-03-31 15:25 ` Richard Earnshaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42474857.7070100@codesourcery.com \
--to=julian@codesourcery.com \
--cc=binutils@sources.redhat.com \
--cc=drow@false.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).