From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19783 invoked by alias); 27 Mar 2005 22:57:23 -0000 Mailing-List: contact binutils-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: binutils-owner@sources.redhat.com Received: (qmail 19765 invoked from network); 27 Mar 2005 22:57:19 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.74.133.9) by sourceware.org with SMTP; 27 Mar 2005 22:57:19 -0000 Received: (qmail 21577 invoked from network); 27 Mar 2005 22:57:18 -0000 Received: from localhost (HELO ?192.168.0.25?) (julian@127.0.0.1) by mail.codesourcery.com with SMTP; 27 Mar 2005 22:57:18 -0000 Message-ID: <42474857.7070100@codesourcery.com> Date: Mon, 28 Mar 2005 10:36:00 -0000 From: Julian Brown User-Agent: Debian Thunderbird 1.0 (X11/20050116) MIME-Version: 1.0 To: Daniel Jacobowitz CC: binutils@sources.redhat.com Subject: Re: [PATCH] Fix type and alignment of ARM/Thumb EABI mapping symbols References: <424716CD.5030909@codesourcery.com> <20050327213906.GA30870@nevyn.them.org> In-Reply-To: <20050327213906.GA30870@nevyn.them.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2005-03/txt/msg00809.txt.bz2 Daniel Jacobowitz wrote: > On Sun, Mar 27, 2005 at 09:25:49PM +0100, Julian Brown wrote: > >>In the interest of preserving existing behaviour, I have fixed this by >>adding a new disassemble_info hook which allows the symbol table used >>for disassembly to have a target-specific hook for altering each symbol >>(or remove it) in the remove_useless_symbols function. This sets the >>BSF_FUNCTION flag for mapping symbols, which makes things behave the way >>they used to, and possibly provides useful functionality for other >>platforms as well. > > How about checking bfd_is_target_special_symbol in remove_useless_syms? To remove the mapping symbols altogether? That would make sense, but the output of objdump would still be altered then -- my patch doesn't actually remove the mapping symbols in remove_useless_symbols, just munges their type. This was the best way I could come up with to preserve existing behaviour without affecting other platforms, but I suspect it might be trying too hard (it is "only" disassembled output which is affected, presumably meant for human consumption). Julian